diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index 7031d7c189f..6cfba58e91d 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -2701,7 +2701,7 @@ func (kl *Kubelet) handlePodResourcesResize(pod *v1.Pod) { //TODO(vinaykul,InPlacePodVerticalScaling): Can we recover from this in some way? Investigate klog.ErrorS(err, "SetPodAllocation failed", "pod", klog.KObj(pod)) } - *pod = *updatedPod + pod = updatedPod } if resizeStatus != "" { // Save resize decision to checkpoint diff --git a/pkg/kubelet/kubelet_test.go b/pkg/kubelet/kubelet_test.go index 8d50c9ec189..57b31b7c1c7 100644 --- a/pkg/kubelet/kubelet_test.go +++ b/pkg/kubelet/kubelet_test.go @@ -2585,8 +2585,10 @@ func TestHandlePodResourcesResize(t *testing.T) { tt.pod.Spec.Containers[0].Resources.Requests = tt.newRequests tt.pod.Status.ContainerStatuses[0].AllocatedResources = v1.ResourceList{v1.ResourceCPU: cpu1000m, v1.ResourceMemory: mem1000M} kubelet.handlePodResourcesResize(tt.pod) - assert.Equal(t, tt.expectedAllocations, tt.pod.Status.ContainerStatuses[0].AllocatedResources, tt.name) - assert.Equal(t, tt.expectedResize, tt.pod.Status.Resize, tt.name) + updatedPod, found := kubelet.podManager.GetPodByName(tt.pod.Namespace, tt.pod.Name) + assert.True(t, found, "expected to find pod %s", tt.pod.Name) + assert.Equal(t, tt.expectedAllocations, updatedPod.Status.ContainerStatuses[0].AllocatedResources, tt.name) + assert.Equal(t, tt.expectedResize, updatedPod.Status.Resize, tt.name) testKubelet.fakeKubeClient.ClearActions() } }