github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 22:17:14 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #78666 from aojea/shellcheck

Browse Source 
Fix verify-shellcheck comments
This commit is contained in:
Kubernetes Prow Robot 2019-06-14 13:26:35 -07:00 committed by GitHub
commit f75bfe9f58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hack/verify-shellcheck.sh
View File

@ -163,7 +163,7 @@ for f in "${all_shell_scripts[@]}"; do
fi fi
done done
# Check to be sure all the packages that should pass lint are. # Check to be sure all the files that should pass lint are.
if [ ${#errors[@]} -eq 0 ]; then if [ ${#errors[@]} -eq 0 ]; then
echo 'Congratulations! All shell files are passing lint (excluding those in hack/.shellcheck_failures).' echo 'Congratulations! All shell files are passing lint (excluding those in hack/.shellcheck_failures).'
else else
@ -183,7 +183,7 @@ fi
if [[ ${#not_failing[@]} -gt 0 ]]; then if [[ ${#not_failing[@]} -gt 0 ]]; then
{ {
echo "Some packages in hack/.shellcheck_failures are passing shellcheck. Please remove them." echo "Some files in hack/.shellcheck_failures are passing shellcheck. Please remove them."
echo echo
for f in "${not_failing[@]}"; do for f in "${not_failing[@]}"; do
echo " $f" echo " $f"
@ -193,7 +193,7 @@ if [[ ${#not_failing[@]} -gt 0 ]]; then
exit 1 exit 1
fi fi
# Check that all failing_packages actually still exist # Check that all failing_files actually still exist
gone=() gone=()
for f in "${failing_files[@]}"; do for f in "${failing_files[@]}"; do
kube::util::array_contains "$f" "${all_shell_scripts[@]}" || gone+=( "$f" ) kube::util::array_contains "$f" "${all_shell_scripts[@]}" || gone+=( "$f" )