From f762e5c8deb4377f0ffa6ad16dcac8b7405641ef Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Thu, 18 Jul 2024 10:54:28 -0400 Subject: [PATCH] Remove an unnecessary comment in nftables output (It's redundant with the chain name.) --- pkg/proxy/nftables/proxier.go | 1 - pkg/proxy/nftables/proxier_test.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/proxy/nftables/proxier.go b/pkg/proxy/nftables/proxier.go index 12c5e2fbd96..c4b9aa803fa 100644 --- a/pkg/proxy/nftables/proxier.go +++ b/pkg/proxy/nftables/proxier.go @@ -1364,7 +1364,6 @@ func (proxier *Proxier) syncProxyRules() { Value: []string{ fmt.Sprintf("goto %s", fwChain), }, - Comment: &svcPortNameString, }) } } diff --git a/pkg/proxy/nftables/proxier_test.go b/pkg/proxy/nftables/proxier_test.go index 1442f63ae60..b22ac0023b1 100644 --- a/pkg/proxy/nftables/proxier_test.go +++ b/pkg/proxy/nftables/proxier_test.go @@ -445,7 +445,7 @@ func TestOverallNFTablesRules(t *testing.T) { add element ip kube-proxy service-ips { 172.30.0.45 . tcp . 80 : goto service-HVFWP5L3-ns5/svc5/tcp/p80 } add element ip kube-proxy service-ips { 5.6.7.8 . tcp . 80 : goto external-HVFWP5L3-ns5/svc5/tcp/p80 } add element ip kube-proxy service-nodeports { tcp . 3002 : goto external-HVFWP5L3-ns5/svc5/tcp/p80 } - add element ip kube-proxy firewall-ips { 5.6.7.8 . tcp . 80 comment "ns5/svc5:p80" : goto firewall-HVFWP5L3-ns5/svc5/tcp/p80 } + add element ip kube-proxy firewall-ips { 5.6.7.8 . tcp . 80 : goto firewall-HVFWP5L3-ns5/svc5/tcp/p80 } # svc6 add element ip kube-proxy cluster-ips { 172.30.0.46 }