From f784eb3cfd051da66332484f71287563ad5d7e8a Mon Sep 17 00:00:00 2001 From: Kishor Joshi Date: Fri, 6 Nov 2020 11:11:46 -0800 Subject: [PATCH] Update UTs --- .../legacy-cloud-providers/aws/aws_test.go | 24 +++++++++++++++---- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/staging/src/k8s.io/legacy-cloud-providers/aws/aws_test.go b/staging/src/k8s.io/legacy-cloud-providers/aws/aws_test.go index 1b04429d8e6..f40dc2e5142 100644 --- a/staging/src/k8s.io/legacy-cloud-providers/aws/aws_test.go +++ b/staging/src/k8s.io/legacy-cloud-providers/aws/aws_test.go @@ -2961,7 +2961,7 @@ func TestCloud_buildNLBHealthCheckConfiguration(t *testing.T) { wantError: false, }, { - name: "invalid interval", + name: "interval not 10 or 30", service: &v1.Service{ ObjectMeta: metav1.ObjectMeta{ Name: "test-svc", @@ -2982,8 +2982,15 @@ func TestCloud_buildNLBHealthCheckConfiguration(t *testing.T) { }, }, }, - want: healthCheckConfig{}, - wantError: true, + want: healthCheckConfig{ + Port: "traffic-port", + Protocol: elbv2.ProtocolEnumTcp, + Interval: 23, + Timeout: 10, + HealthyThreshold: 3, + UnhealthyThreshold: 3, + }, + wantError: false, }, { name: "invalid timeout", @@ -3033,8 +3040,15 @@ func TestCloud_buildNLBHealthCheckConfiguration(t *testing.T) { }, }, }, - want: healthCheckConfig{}, - wantError: true, + want: healthCheckConfig{ + Port: "traffic-port", + Protocol: elbv2.ProtocolEnumTcp, + Interval: 30, + Timeout: 10, + HealthyThreshold: 7, + UnhealthyThreshold: 5, + }, + wantError: false, }, }