From cc2e9394be3ed9c970a46969599071df036532d2 Mon Sep 17 00:00:00 2001 From: Elana Hashman Date: Fri, 4 Jun 2021 16:03:46 -0700 Subject: [PATCH] kubelet: Fix test order in verifyContainerStatuses Per https://pkg.go.dev/github.com/stretchr/testify/assert#Equal expected goes before actual. --- pkg/kubelet/kubelet_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/kubelet_test.go b/pkg/kubelet/kubelet_test.go index 375cc678870..6786e55a460 100644 --- a/pkg/kubelet/kubelet_test.go +++ b/pkg/kubelet/kubelet_test.go @@ -1725,10 +1725,10 @@ func TestGenerateAPIPodStatusWithSortedContainers(t *testing.T) { } } -func verifyContainerStatuses(t *testing.T, statuses []v1.ContainerStatus, state, lastTerminationState map[string]v1.ContainerState, message string) { +func verifyContainerStatuses(t *testing.T, statuses []v1.ContainerStatus, expectedState, expectedLastTerminationState map[string]v1.ContainerState, message string) { for _, s := range statuses { - assert.Equal(t, s.State, state[s.Name], "%s: state", message) - assert.Equal(t, s.LastTerminationState, lastTerminationState[s.Name], "%s: last terminated state", message) + assert.Equal(t, expectedState[s.Name], s.State, "%s: state", message) + assert.Equal(t, expectedLastTerminationState[s.Name], s.LastTerminationState, "%s: last terminated state", message) } }