From f8480f394813db74eb7b82c59d6f1ea6ba2bbb27 Mon Sep 17 00:00:00 2001 From: hangaoshuai Date: Fri, 22 Jun 2018 11:41:33 +0800 Subject: [PATCH] return error when failed to prepull the images --- cmd/kubeadm/app/cmd/upgrade/apply.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/kubeadm/app/cmd/upgrade/apply.go b/cmd/kubeadm/app/cmd/upgrade/apply.go index d659f266b85..abffc9061c2 100644 --- a/cmd/kubeadm/app/cmd/upgrade/apply.go +++ b/cmd/kubeadm/app/cmd/upgrade/apply.go @@ -195,7 +195,9 @@ func RunApply(flags *applyFlags) error { // and block until all DaemonSets are ready; then we know for sure that all control plane images are cached locally glog.V(1).Infof("[upgrade/apply] creating prepuller") prepuller := upgrade.NewDaemonSetPrepuller(upgradeVars.client, upgradeVars.waiter, upgradeVars.cfg) - upgrade.PrepullImagesInParallel(prepuller, flags.imagePullTimeout) + if err := upgrade.PrepullImagesInParallel(prepuller, flags.imagePullTimeout); err != nil { + return fmt.Errorf("[upgrade/prepull] Failed prepulled the images for the control plane components error: %v", err) + } // Now; perform the upgrade procedure glog.V(1).Infof("[upgrade/apply] performing upgrade")