From a724a3df77a2a72bb5a39a11814605878e508280 Mon Sep 17 00:00:00 2001 From: Aditi Sharma Date: Fri, 19 Mar 2021 14:46:40 +0530 Subject: [PATCH] Fix structured logs for dns.go Signed-off-by: Aditi Sharma --- pkg/kubelet/network/dns/dns.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/kubelet/network/dns/dns.go b/pkg/kubelet/network/dns/dns.go index f2608b45af8..7d5dec8a7c2 100644 --- a/pkg/kubelet/network/dns/dns.go +++ b/pkg/kubelet/network/dns/dns.go @@ -121,9 +121,9 @@ func (c *Configurer) formDNSSearchFitsLimits(composedSearch []string, pod *v1.Po } if limitsExceeded { - log := fmt.Sprintf("Search Line limits were exceeded, some search paths have been omitted, the applied search line is: %s", strings.Join(composedSearch, " ")) - c.recorder.Event(pod, v1.EventTypeWarning, "DNSConfigForming", log) - klog.ErrorS(nil, "eventlog", log) + err := fmt.Errorf("Search Line limits were exceeded, some search paths have been omitted, the applied search line is: %s", strings.Join(composedSearch, " ")) + c.recorder.Event(pod, v1.EventTypeWarning, "DNSConfigForming", err.Error()) + klog.ErrorS(err, "Search Line limits exceeded") } return composedSearch } @@ -131,9 +131,9 @@ func (c *Configurer) formDNSSearchFitsLimits(composedSearch []string, pod *v1.Po func (c *Configurer) formDNSNameserversFitsLimits(nameservers []string, pod *v1.Pod) []string { if len(nameservers) > validation.MaxDNSNameservers { nameservers = nameservers[0:validation.MaxDNSNameservers] - log := fmt.Sprintf("Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: %s", strings.Join(nameservers, " ")) - c.recorder.Event(pod, v1.EventTypeWarning, "DNSConfigForming", log) - klog.ErrorS(nil, "eventlog", log) + err := fmt.Errorf("Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: %s", strings.Join(nameservers, " ")) + c.recorder.Event(pod, v1.EventTypeWarning, "DNSConfigForming", err.Error()) + klog.ErrorS(err, "Nameserver limits exceeded") } return nameservers }