github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

apply: fix detection of non-dry-run enabled servers

Browse Source 
Apply only checks that the server supports dry-run in the create path,
not the update path, which is pretty bad.
This commit is contained in:
Antoine Pelisse 2018-12-07 09:46:09 -08:00 committed by Antoine Pelisse
parent 16fb54ef7c
commit f9ca4aafc6
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/kubectl/cmd/apply/apply.go
View File

@ -344,6 +344,13 @@ func (o *ApplyOptions) Run() error {
return err return err
} }
// If server-dry-run is requested but the type doesn't support it, fail right away.
if o.ServerDryRun {
if err := dryRunVerifier.HasSupport(info.Mapping.GroupVersionKind); err != nil {
return err
}
}
if info.Namespaced() { if info.Namespaced() {
visitedNamespaces.Insert(info.Namespace) visitedNamespaces.Insert(info.Namespace)
} }
@ -367,12 +374,6 @@ func (o *ApplyOptions) Run() error {
if !errors.IsNotFound(err) { if !errors.IsNotFound(err) {
return cmdutil.AddSourceToErr(fmt.Sprintf("retrieving current configuration of:\n%s\nfrom server for:", info.String()), info.Source, err) return cmdutil.AddSourceToErr(fmt.Sprintf("retrieving current configuration of:\n%s\nfrom server for:", info.String()), info.Source, err)
} }
// If server-dry-run is requested but the type doesn't support it, fail right away.
if o.ServerDryRun {
if err := dryRunVerifier.HasSupport(info.Mapping.GroupVersionKind); err != nil {
return err
}
}
// Create the resource if it doesn't exist // Create the resource if it doesn't exist
// First, update the annotation used by kubectl apply // First, update the annotation used by kubectl apply