github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

Fix golint issues in pkg/util/env

Browse Source
This commit is contained in:
Stefan Bueringer 2019-09-27 17:25:19 +02:00
parent 898042007c
commit fa36b19e79
No known key found for this signature in database
GPG Key ID: D405233560D47A0A
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/.golint_failures
View File

@ -230,7 +230,6 @@ pkg/serviceaccount
pkg/ssh pkg/ssh
pkg/util/config pkg/util/config
pkg/util/ebtables pkg/util/ebtables
pkg/util/env
pkg/util/goroutinemap/exponentialbackoff pkg/util/goroutinemap/exponentialbackoff
pkg/util/iptables pkg/util/iptables
pkg/util/iptables/testing pkg/util/iptables/testing

6
pkg/util/env/env.go vendored
View File

@ -21,6 +21,8 @@ import (
"strconv" "strconv"
) )
// GetEnvAsStringOrFallback returns the env variable for the given key
// and falls back to the given defaultValue if not set
func GetEnvAsStringOrFallback(key, defaultValue string) string { func GetEnvAsStringOrFallback(key, defaultValue string) string {
if v := os.Getenv(key); v != "" { if v := os.Getenv(key); v != "" {
return v return v
@ -28,6 +30,8 @@ func GetEnvAsStringOrFallback(key, defaultValue string) string {
return defaultValue return defaultValue
} }
// GetEnvAsIntOrFallback returns the env variable (parsed as integer) for
// the given key and falls back to the given defaultValue if not set
func GetEnvAsIntOrFallback(key string, defaultValue int) (int, error) { func GetEnvAsIntOrFallback(key string, defaultValue int) (int, error) {
if v := os.Getenv(key); v != "" { if v := os.Getenv(key); v != "" {
value, err := strconv.Atoi(v) value, err := strconv.Atoi(v)
@ -39,6 +43,8 @@ func GetEnvAsIntOrFallback(key string, defaultValue int) (int, error) {
return defaultValue, nil return defaultValue, nil
} }
// GetEnvAsFloat64OrFallback returns the env variable (parsed as float64) for
// the given key and falls back to the given defaultValue if not set
func GetEnvAsFloat64OrFallback(key string, defaultValue float64) (float64, error) { func GetEnvAsFloat64OrFallback(key string, defaultValue float64) (float64, error) {
if v := os.Getenv(key); v != "" { if v := os.Getenv(key); v != "" {
value, err := strconv.ParseFloat(v, 64) value, err := strconv.ParseFloat(v, 64)