From 2fd87597a43629ba6aa5d2406dc1737f83e5f6b1 Mon Sep 17 00:00:00 2001 From: Yu-Ju Hong Date: Thu, 16 Apr 2015 10:51:33 -0700 Subject: [PATCH] Fix data race in kubelet_test.go Ensure that FakeDockerClient make a copy of the internal list and return it. --- pkg/kubelet/dockertools/fake_docker_client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/dockertools/fake_docker_client.go b/pkg/kubelet/dockertools/fake_docker_client.go index baa1a765916..6746d6efbca 100644 --- a/pkg/kubelet/dockertools/fake_docker_client.go +++ b/pkg/kubelet/dockertools/fake_docker_client.go @@ -139,7 +139,7 @@ func (f *FakeDockerClient) ListContainers(options docker.ListContainersOptions) if options.All { return append(f.ContainerList, f.ExitedContainerList...), err } - return f.ContainerList, err + return append([]docker.APIContainers{}, f.ContainerList...), err } // InspectContainer is a test-spy implementation of DockerInterface.InspectContainer.