github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #78412 from draveness/feature/assign=start-time-for-test-pod

Browse Source 
fix: assign default value for pod.Status.StartTime in TestSelectNodes…
This commit is contained in:
Kubernetes Prow Robot 2019-06-28 08:05:39 -07:00 committed by GitHub
commit fa65154a58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/scheduler/core/generic_scheduler_test.go
View File

@ -977,6 +977,8 @@ func TestSelectNodesForPreemption(t *testing.T) {
} }
for _, test := range tests { for _, test := range tests {
t.Run(test.name, func(t *testing.T) { t.Run(test.name, func(t *testing.T) {
assignDefaultStartTime(test.pods)
nodes := []*v1.Node{} nodes := []*v1.Node{}
for _, n := range test.nodes { for _, n := range test.nodes {
node := makeNode(n, 1000*5, priorityutil.DefaultMemoryRequest*5) node := makeNode(n, 1000*5, priorityutil.DefaultMemoryRequest*5)
@ -1198,6 +1200,8 @@ func TestPickOneNodeForPreemption(t *testing.T) {
} }
for _, test := range tests { for _, test := range tests {
t.Run(test.name, func(t *testing.T) { t.Run(test.name, func(t *testing.T) {
assignDefaultStartTime(test.pods)
nodes := []*v1.Node{} nodes := []*v1.Node{}
for _, n := range test.nodes { for _, n := range test.nodes {
nodes = append(nodes, makeNode(n, priorityutil.DefaultMilliCPURequest*5, priorityutil.DefaultMemoryRequest*5)) nodes = append(nodes, makeNode(n, priorityutil.DefaultMilliCPURequest*5, priorityutil.DefaultMemoryRequest*5))
@ -1641,3 +1645,13 @@ func TestNumFeasibleNodesToFind(t *testing.T) {
}) })
} }
} }
func assignDefaultStartTime(pods []*v1.Pod) {
now := metav1.Now()
for i := range pods {
pod := pods[i]
if pod.Status.StartTime == nil {
pod.Status.StartTime = &now
}
}
}