github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

remove retry logic in initializer AC configuration loader

Browse Source
This commit is contained in:
Chao Xu 2017-06-14 14:58:49 -07:00
parent bcccbc3d0b
commit fa88d08172
1 changed files with 14 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
plugin/pkg/admission/initialization/initialization.go
View File

@ -19,12 +19,7 @@ package initialization
import ( import (
"fmt" "fmt"
"io" "io"
"net"
"net/url"
"os"
"strings" "strings"
"syscall"
"time"
"github.com/golang/glog" "github.com/golang/glog"
@ -64,16 +59,6 @@ type initializer struct {
authorizer authorizer.Authorizer authorizer authorizer.Authorizer
} }
// Retry config loading failures for up to four and a half seconds if the config hasn't been loaded
// yet or if the server is down. Creation requests are delayed during this interval, which prevents
// racy failures during startup until the initializer configuration becomes available.
// TODO: move into InitializationConfigurationManager, since these values depend on the config
// refresh loop.
const (
retryTemporaryConfigFailures = 8
retryTemporaryConfigInterval = 550 * time.Millisecond
)
// NewInitializer creates a new initializer plugin which assigns newly created resources initializers // NewInitializer creates a new initializer plugin which assigns newly created resources initializers
// based on configuration loaded from the admission API group. // based on configuration loaded from the admission API group.
// FUTURE: this may be moved to the storage layer of the apiserver, but for now this is an alpha feature // FUTURE: this may be moved to the storage layer of the apiserver, but for now this is an alpha feature
@ -100,32 +85,9 @@ func (i *initializer) SetAuthorizer(a authorizer.Authorizer) {
var initializerFieldPath = field.NewPath("metadata", "initializers") var initializerFieldPath = field.NewPath("metadata", "initializers")
// temporaryConnectionError returns true if the error is considered temporary // readConfig holds requests instead of failing them if the server is not yet initialized
func temporaryConnectionError(err error) bool {
if urlError, ok := err.(*url.Error); ok {
if urlError.Temporary() {
return true
}
if opError, ok := urlError.Err.(*net.OpError); ok {
if syscallError, ok := opError.Err.(*os.SyscallError); ok {
if errno, ok := syscallError.Err.(syscall.Errno); ok && errno == syscall.ECONNREFUSED {
return true
}
}
}
}
return false
}
// readConfigWithRetry holds requests instead of failing them if the server is not yet initialized
// or is unresponsive. It formats the returned error for client use if necessary. // or is unresponsive. It formats the returned error for client use if necessary.
func (i *initializer) readConfigWithRetry(a admission.Attributes) (*v1alpha1.InitializerConfiguration, error) { func (i *initializer) readConfig(a admission.Attributes) (*v1alpha1.InitializerConfiguration, error) {
var lastErr error
for count := 0; count < retryTemporaryConfigFailures; count++ {
if count > 0 {
time.Sleep(retryTemporaryConfigInterval)
}
// read initializers from config // read initializers from config
config, err := i.config.Initializers() config, err := i.config.Initializers()
if err == nil { if err == nil {
@ -137,23 +99,16 @@ func (i *initializer) readConfigWithRetry(a admission.Attributes) (*v1alpha1.Ini
return &v1alpha1.InitializerConfiguration{}, nil return &v1alpha1.InitializerConfiguration{}, nil
} }
// retry certain errors
lastErr = err
if err != configuration.ErrNotReady && !temporaryConnectionError(err) {
break
}
}
e := errors.NewServerTimeout(a.GetResource().GroupResource(), "create", 1) e := errors.NewServerTimeout(a.GetResource().GroupResource(), "create", 1)
if lastErr == configuration.ErrNotReady { if err == configuration.ErrNotReady {
e.ErrStatus.Message = fmt.Sprintf("Waiting for initialization configuration to load: %v", lastErr) e.ErrStatus.Message = fmt.Sprintf("Waiting for initialization configuration to load: %v", err)
e.ErrStatus.Reason = "LoadingConfiguration" e.ErrStatus.Reason = "LoadingConfiguration"
e.ErrStatus.Details.Causes = append(e.ErrStatus.Details.Causes, metav1.StatusCause{ e.ErrStatus.Details.Causes = append(e.ErrStatus.Details.Causes, metav1.StatusCause{
Type: "InitializerConfigurationPending", Type: "InitializerConfigurationPending",
Message: "The server is waiting for the initializer configuration to be loaded.", Message: "The server is waiting for the initializer configuration to be loaded.",
}) })
} else { } else {
e.ErrStatus.Message = fmt.Sprintf("Unable to refresh the initializer configuration: %v", lastErr) e.ErrStatus.Message = fmt.Sprintf("Unable to refresh the initializer configuration: %v", err)
e.ErrStatus.Reason = "LoadingConfiguration" e.ErrStatus.Reason = "LoadingConfiguration"
e.ErrStatus.Details.Causes = append(e.ErrStatus.Details.Causes, metav1.StatusCause{ e.ErrStatus.Details.Causes = append(e.ErrStatus.Details.Causes, metav1.StatusCause{
Type: "InitializerConfigurationFailure", Type: "InitializerConfigurationFailure",
@ -206,7 +161,7 @@ func (i *initializer) Admit(a admission.Attributes) (err error) {
} else { } else {
glog.V(5).Infof("Checking initialization for %s", a.GetResource()) glog.V(5).Infof("Checking initialization for %s", a.GetResource())
config, err := i.readConfigWithRetry(a) config, err := i.readConfig(a)
if err != nil { if err != nil {
return err return err
} }