github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-08 03:33:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #121670 from kerthcet/bug/add-status-message

Browse Source 
Fix empty status message in logging
This commit is contained in:
Kubernetes Prow Robot 2023-12-13 22:34:51 +01:00 committed by GitHub
commit fb011badd7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/scheduler/framework/interface.go
View File

@ -287,6 +287,10 @@ func (s *Status) Equal(x *Status) bool {
return cmp.Equal(s.plugin, x.plugin) return cmp.Equal(s.plugin, x.plugin)
} }
func (s *Status) String() string {
return s.Message()
}
// NewStatus makes a Status out of the given arguments and returns its pointer. // NewStatus makes a Status out of the given arguments and returns its pointer.
func NewStatus(code Code, reasons ...string) *Status { func NewStatus(code Code, reasons ...string) *Status {
s := &Status{ s := &Status{

2
pkg/scheduler/internal/queue/scheduling_queue.go
View File

@ -515,7 +515,7 @@ func (p *PriorityQueue) runPreEnqueuePlugins(ctx context.Context, pInfo *framewo
if s.Code() == framework.Error { if s.Code() == framework.Error {
logger.Error(s.AsError(), "Unexpected error running PreEnqueue plugin", "pod", klog.KObj(pod), "plugin", pl.Name()) logger.Error(s.AsError(), "Unexpected error running PreEnqueue plugin", "pod", klog.KObj(pod), "plugin", pl.Name())
} else { } else {
logger.Info("Status after running PreEnqueue plugin", "pod", klog.KObj(pod), "plugin", pl.Name(), "status", s) logger.V(4).Info("Status after running PreEnqueue plugin", "pod", klog.KObj(pod), "plugin", pl.Name(), "status", s)
} }
return false return false
} }