From fb4a5c6c420093bf7405ad6ef716eed8d6e93f75 Mon Sep 17 00:00:00 2001 From: Mike Danese Date: Thu, 24 Mar 2016 17:09:37 -0700 Subject: [PATCH] add an event for when a daemonset can't place a pod due to insufficent resource or port conflict --- pkg/controller/daemon/controller.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/controller/daemon/controller.go b/pkg/controller/daemon/controller.go index f148ef58ac6..7ef9eab6c3c 100644 --- a/pkg/controller/daemon/controller.go +++ b/pkg/controller/daemon/controller.go @@ -683,11 +683,13 @@ func (dsc *DaemonSetsController) nodeShouldRunDaemonPod(node *api.Node, ds *exte } _, notFittingCPU, notFittingMemory := predicates.CheckPodsExceedingFreeResources(pods, node.Status.Allocatable) if len(notFittingCPU)+len(notFittingMemory) != 0 { + dsc.eventRecorder.Eventf(ds, api.EventTypeNormal, "FailedPlacement", "failed to place pod on %q: insufficent free resources", node.ObjectMeta.Name) return false } ports := sets.String{} for _, pod := range pods { if errs := validation.AccumulateUniqueHostPorts(pod.Spec.Containers, &ports, field.NewPath("spec", "containers")); len(errs) > 0 { + dsc.eventRecorder.Eventf(ds, api.EventTypeNormal, "FailedPlacement", "failed to place pod on %q: host port conflict", node.ObjectMeta.Name) return false } }