Merge pull request #65927 from BenTheElder/fix-visibility

Automatic merge from submit-queue (batch tested with PRs 65882, 65896, 65755, 60549, 65927). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix visibility of testdata for //test/cmd:legacy-script

**What this PR does / why we need it**: fixes some BUILD visibility, albeit for a relatively unused target

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

build/visible_to/BUILD

@@ -40,6 +40,7 @@ package_group(
         "//hack",
         "//hack/lib",
         "//hack/make-rules",
+        "//test/cmd",
         "//test/e2e/...",
         "//test/integration/...",
     ],

hack/make-rules/BUILD

@@ -21,7 +21,7 @@ sh_binary(
     srcs = ["test-cmd.sh"],
     deps = [
         "//hack/lib",
-        "//test/cmd:all-srcs",
+        "//test/cmd:legacy-script",
     ],
 )
 

test/cmd/BUILD

@@ -1,53 +1,8 @@
-# Scripts runnable from make, e.g.
-#
-#    cd $GOPATH/src/k8s.io/kubernetes
-#    make test-e2e-node
-#
-# The sh_binary rules below exist only to validate
-# dependencies; if a shell dependency is accidentally
-# deleted, a presubmit BUILD will fail.
-#
-# If the scripts sourced their dependencies from
-# $RUNFILES (rather than $BASH_SOURCE/../.. or
-# whatever), then bazel build hack/...  would install
-# runnable, hermetically sealed shell "binaries".
-# E.g. the following command would work:
-#
-#   ./bazel-bin/hack/make-rules/test-e2e-node
-#
-# TODO(#47064): Should be a sh_test instead of sh_binary
-
 sh_library(
     name = "legacy-script",
-    srcs = [
+    srcs = glob(["*.sh"]),
-        "apply.sh",
-        "apps.sh",
-        "authorization.sh",
-        "batch.sh",
-        "certificate.sh",
-        "core.sh",
-        "crd.sh",
-        "create.sh",
-        "diff.sh",
-        "discovery.sh",
-        "generic-resources.sh",
-        "get.sh",
-        "initializers.sh",
-        "kubeconfig.sh",
-        "legacy-script.sh",
-        "node-management.sh",
-        "old-print.sh",
-        "plugins.sh",
-        "proxy.sh",
-        "rbac.sh",
-        "request-timeout.sh",
-        "run.sh",
-        "save-config.sh",
-        "storage.sh",
-        "template-output.sh",
-        "version.sh",
-    ],
     data = ["//pkg/kubectl/validation:testdata/v1/validPod.yaml"],
+    visibility = ["//visibility:public"],
 )
 
 filegroup(