mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-22 18:16:52 +00:00
Merge pull request #53366 from tcharding/cloud-controller
Automatic merge from submit-queue (batch tested with PRs 53418, 53366, 53115, 53402, 53130). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cmd: cloud-controller-manager: remove golint_failures entry **What this PR does / why we need it**: `cmd/cloud-controller-manager/app` and `cmd/cloud-controller-manager/app/options` currently appear in `.golint_failures`. We can lint these packages. `golint` emits the following two warnings ``` comment on exported type CloudControllerManagerServer should be of the form "CloudControllerManagerServer ..." comment on exported const ControllerStartJitter should be of the form "ControllerStartJitter ..." ``` Fix the documentation comments and remove entries from `.golint_failures` **Special notes for your reviewer**: Don't know which sig to label this PR with? **Release note**: ```release-note NONE ``` /kind cleanup
This commit is contained in:
commit
fc6120cc48
@ -56,7 +56,7 @@ import (
|
||||
)
|
||||
|
||||
const (
|
||||
// Jitter used when starting controller managers
|
||||
// ControllerStartJitter is the jitter value used when starting controller managers.
|
||||
ControllerStartJitter = 1.0
|
||||
)
|
||||
|
||||
|
@ -31,7 +31,7 @@ import (
|
||||
"github.com/spf13/pflag"
|
||||
)
|
||||
|
||||
// CloudControllerMangerServer is the main context object for the controller manager.
|
||||
// CloudControllerManagerServer is the main context object for the controller manager.
|
||||
type CloudControllerManagerServer struct {
|
||||
componentconfig.KubeControllerManagerConfiguration
|
||||
|
||||
|
@ -1,6 +1,4 @@
|
||||
cluster/images/etcd-version-monitor
|
||||
cmd/cloud-controller-manager/app
|
||||
cmd/cloud-controller-manager/app/options
|
||||
cmd/genutils
|
||||
cmd/gke-certificates-controller/app
|
||||
cmd/hyperkube
|
||||
|
Loading…
Reference in New Issue
Block a user