From fc6bbf991e03892353a3ee806eb2f2616d94f095 Mon Sep 17 00:00:00 2001 From: muyangren2 <624376142@qq.com> Date: Thu, 28 Jul 2022 15:07:18 +0800 Subject: [PATCH] add test in cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go for ValidatePort modify --- .../kubeadm/validation/validation_test.go | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go b/cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go index 3fe3c2e3875..77840ba2572 100644 --- a/cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go +++ b/cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go @@ -18,6 +18,7 @@ package validation import ( "os" + "strings" "testing" "github.com/spf13/pflag" @@ -183,6 +184,34 @@ func TestValidateIPFromString(t *testing.T) { } } +func TestValidatePort(t *testing.T) { + var tests = []struct { + name string + port int32 + expectedErr bool + }{ + {"negative number port", -1234, true}, + {"zero number port", 0, true}, + {"minimum valid value port", 1, false}, + {"valid value port", 300, false}, + {"maximum valid value port", 65535, false}, + {"if port greater than 65535", 65538, true}, + } + for _, rt := range tests { + t.Run(rt.name, func(t *testing.T) { + allErrs := ValidatePort(rt.port, nil) + if len(allErrs) > 0 { + find := strings.Contains(allErrs[0].Error(), "port number is not valid") + if find != rt.expectedErr { + t.Errorf( + "test case failed :\n\t err(s): %v\n\t", allErrs[0].Error(), + ) + } + } + }) + } +} + func TestValidateIPNetFromString(t *testing.T) { var tests = []struct { name string