From fc9f02e25415153dbbf7a9f846a97821cb50fe09 Mon Sep 17 00:00:00 2001 From: lukasmetzner Date: Thu, 6 Nov 2025 09:24:05 +0100 Subject: [PATCH] refactor: rename and suitable docstring --- .../controllers/route/route_controller.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/staging/src/k8s.io/cloud-provider/controllers/route/route_controller.go b/staging/src/k8s.io/cloud-provider/controllers/route/route_controller.go index 4f390fcbfec..c7e6c57e7da 100644 --- a/staging/src/k8s.io/cloud-provider/controllers/route/route_controller.go +++ b/staging/src/k8s.io/cloud-provider/controllers/route/route_controller.go @@ -119,9 +119,9 @@ func New( // - Node .Status.Addresses is changed // - Node .Spec.PodCIDRs is changed cache.ResourceEventHandlerFuncs{ - AddFunc: rc.enqueueReconcile, + AddFunc: rc.enqueueClusterReconcile, UpdateFunc: rc.handleNodeUpdate, - DeleteFunc: rc.enqueueReconcile, + DeleteFunc: rc.enqueueClusterReconcile, }, ) if err != nil { @@ -132,9 +132,8 @@ func New( return rc, nil } -func (rc *RouteController) enqueueReconcile(_ interface{}) { - // reconcileNodeRoutes always reconciles the full cluster. It does not make sense to have - // separate entries in the workqueue per node, but a single one for the whole cluster is enough. +// enqueueClusterReconcile enqueues a route reconciliation of the cluster. +func (rc *RouteController) enqueueClusterReconcile(_ interface{}) { rc.workqueue.AddRateLimited("routes") } @@ -155,7 +154,7 @@ func (rc *RouteController) handleNodeUpdate(oldObj, newObj interface{}) { diffInNodeAddresses := !reflect.DeepEqual(oldNode.Status.Addresses, newNode.Status.Addresses) if diffInPodCIDR || diffInNodeAddresses || resync { - rc.enqueueReconcile(newObj) + rc.enqueueClusterReconcile(newObj) } }