github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #35352 from MrHohn/e2e-service-todo

Browse Source 
Automatic merge from submit-queue

service e2e: remove TODO and subtle changes in logging

Removes the stale `TODO` for external source IP preservation as the e2e test of ESIPP was added.

Changes logging in create service functions: namespace/namespace -> namespace/serviceName.

@bprashanth
This commit is contained in:
Kubernetes Submit Queue 2016-10-21 23:46:18 -07:00 committed by GitHub
commit fdce738113
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/e2e/service.go
View File

@ -239,7 +239,6 @@ var _ = framework.KubeDescribe("Services", func() {
validateEndpointsOrFail(c, ns, serviceName, PortsByPodName{})
})
// TODO: verify source IP preservation for LoadBalancer type services when applicable
It("should preserve source pod IP for traffic thru service cluster IP", func() {
serviceName := "sourceip-test"
@ -2102,7 +2101,7 @@ func (j *ServiceTestJig) ChangeServiceType(namespace, name string, newType api.S
// nodePort. If createPod is true, it also creates an RC with 1 replica of
// the standard netexec container used everywhere in this test.
func (j *ServiceTestJig) createOnlyLocalNodePortService(namespace, serviceName string, createPod bool) *api.Service {
By("creating a service " + namespace + "/" + namespace + " with type=NodePort and annotation for local-traffic-only")
By("creating a service " + namespace + "/" + serviceName + " with type=NodePort and annotation for local-traffic-only")
svc := j.CreateTCPServiceOrFail(namespace, func(svc *api.Service) {
svc.Spec.Type = api.ServiceTypeNodePort
svc.ObjectMeta.Annotations = map[string]string{
@ -2122,7 +2121,7 @@ func (j *ServiceTestJig) createOnlyLocalNodePortService(namespace, serviceName s
// acquire an ingress IP. If createPod is true, it also creates an RC with 1
// replica of the standard netexec container used everywhere in this test.
func (j *ServiceTestJig) createOnlyLocalLoadBalancerService(namespace, serviceName string, timeout time.Duration, createPod bool) *api.Service {
By("creating a service " + namespace + "/" + namespace + " with type=LoadBalancer and annotation for local-traffic-only")
By("creating a service " + namespace + "/" + serviceName + " with type=LoadBalancer and annotation for local-traffic-only")
svc := j.CreateTCPServiceOrFail(namespace, func(svc *api.Service) {
svc.Spec.Type = api.ServiceTypeLoadBalancer
// We need to turn affinity off for our LB distribution tests