From fdd7322b38e95f170c8ce6a7b8844539bd1261ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sat, 26 Sep 2015 11:52:44 -0700 Subject: [PATCH] Use DeleteDropWatch instead of Delete in test Using the latter resulted in receiving extra OnDelete event callbacks. Using DeleteDropWatch removed the flake. Fixes #14138. --- pkg/controller/framework/controller_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controller/framework/controller_test.go b/pkg/controller/framework/controller_test.go index e1523790bb7..7adc169b30d 100644 --- a/pkg/controller/framework/controller_test.go +++ b/pkg/controller/framework/controller_test.go @@ -133,7 +133,7 @@ func ExampleInformer() { time.Millisecond*100, framework.ResourceEventHandlerFuncs{ AddFunc: func(obj interface{}) { - source.Delete(obj.(runtime.Object)) + source.DeleteDropWatch(obj.(runtime.Object)) }, DeleteFunc: func(obj interface{}) { key, err := framework.DeletionHandlingMetaNamespaceKeyFunc(obj) @@ -327,7 +327,7 @@ func TestUpdate(t *testing.T) { if !allowedTransitions[pair{from, to}] { t.Errorf("observed transition %q -> %q for %v", from, to, n.Name) } - source.Delete(n) + source.DeleteDropWatch(n) }, DeleteFunc: func(obj interface{}) { testDoneWG.Done()