From f0ec8c8644997e3cc12be968c2341fc67dff6a5f Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Thu, 9 May 2019 13:56:02 -0700 Subject: [PATCH 1/2] Promote oomichi to approver in test/ --- test/OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/OWNERS b/test/OWNERS index 14bbffa0418..a228a8d9339 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -30,7 +30,6 @@ reviewers: - zmerlynn - vishh - MaciekPytel # for test/e2e/common/autoscaling_utils.go - - oomichi - xichengliudui - andrewsykim - neolit123 @@ -58,6 +57,7 @@ approvers: - mikedanese - msau42 # for test/e2e/commmon/{*volume,empty_dir}.go and test/e2e/framework/{pv|volume}_util.go - ncdc + - oomichi - pwittrock # for test/e2e/kubectl.go - saad-ali - shyamjvs From 69eab5f04b4542b933b4735aec09642ae8abc6c9 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Thu, 9 May 2019 16:30:58 -0700 Subject: [PATCH 2/2] Prune test/OWNERS Move approvers who haven't reviewed any PRs touching test/ in over six months to emeritus_approvers (and remove from reviewers as well to avoid assigning to inactive people) --- test/OWNERS | 40 ++++++++++++++++------------------------ 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/test/OWNERS b/test/OWNERS index a228a8d9339..53ca857e1c0 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -6,30 +6,20 @@ reviewers: - MrHohn - deads2k - enisoc - - enj # for test/integration/etcd/etcd_storage_path_test.go - - erictune - - foxish # for test/e2e/network-partition.go - - gmarek - janetkuo - - kow3ns # for test/e2e/statefulset.go - - krousey - liggitt - - madhusudancs - - marun - mikedanese - - msau42 # for test/e2e/commmon/{*volume,empty_dir}.go and test/e2e/framework/{pv|volume}_util.go + - msau42 - ncdc - pwittrock # for test/e2e/kubectl.go - saad-ali - shyamjvs - smarterclayton - - soltysh - sig-testing-reviewers - sttts - timothysc - zmerlynn - vishh - - MaciekPytel # for test/e2e/common/autoscaling_utils.go - xichengliudui - andrewsykim - neolit123 @@ -43,19 +33,10 @@ approvers: - MrHohn - deads2k - enisoc - - enj # for test/integration/etcd/etcd_storage_path_test.go - - eparis - - erictune - - foxish # for test/e2e/network-partition.go - - gmarek - janetkuo - - kow3ns # for test/e2e/statefulset.go - - krousey - liggitt - - madhusudancs - - marun - mikedanese - - msau42 # for test/e2e/commmon/{*volume,empty_dir}.go and test/e2e/framework/{pv|volume}_util.go + - msau42 - ncdc - oomichi - pwittrock # for test/e2e/kubectl.go @@ -63,12 +44,23 @@ approvers: - shyamjvs - sig-testing-approvers - smarterclayton - - soltysh - sttts - timothysc - - zmerlynn - vishh - - MaciekPytel # for test/e2e/common/autoscaling_utils.go +emeritus_approvers: + - enj + - eparis + - erictune + - foxish + - gmarek + - krousey + - kow3ns + - madhusudancs + - marun + - soltysh + - zmerlynn + - MaciekPytel + labels: - area/test - sig/testing