From aee73d67294c6cb8b152c5934ad4a139812c28f7 Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Sat, 4 Apr 2015 11:32:09 -0400 Subject: [PATCH] Do not log "event already exists" errors When the server rejects an event because it has already been created, log it at a very high level (debug) instead of the default level. Duplicate events typically only occur due to programmer error or failure conditions, so they can safely be ignored in production environments. --- pkg/client/record/event.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/client/record/event.go b/pkg/client/record/event.go index 58792133d40..3c1aa67fae2 100644 --- a/pkg/client/record/event.go +++ b/pkg/client/record/event.go @@ -176,7 +176,11 @@ func recordEvent(sink EventSink, event *api.Event, updateExistingEvent bool) boo glog.Errorf("Unable to construct event '%#v': '%v' (will not retry!)", event, err) return true case *errors.StatusError: - glog.Errorf("Server rejected event '%#v': '%v' (will not retry!)", event, err) + if errors.IsAlreadyExists(err) { + glog.V(5).Infof("Server rejected event '%#v': '%v' (will not retry!)", event, err) + } else { + glog.Errorf("Server rejected event '%#v': '%v' (will not retry!)", event, err) + } return true case *errors.UnexpectedObjectError: // We don't expect this; it implies the server's response didn't match a