From 70f82f0dda836b253cff653ac8bfc09987e64c2f Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Wed, 24 Jul 2019 17:44:22 +0300 Subject: [PATCH] kubeadm: add forgotten error check 'kubeadm config images pull' command ignores pulling errors due to forgotten error check. Added the check to correctly output errors if they occur. --- cmd/kubeadm/app/cmd/config.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/kubeadm/app/cmd/config.go b/cmd/kubeadm/app/cmd/config.go index 8d1e13a9034..e37a91dc815 100644 --- a/cmd/kubeadm/app/cmd/config.go +++ b/cmd/kubeadm/app/cmd/config.go @@ -438,7 +438,8 @@ func NewCmdConfigImagesPull() *cobra.Command { kubeadmutil.CheckErr(err) containerRuntime, err := utilruntime.NewContainerRuntime(utilsexec.New(), internalcfg.NodeRegistration.CRISocket) kubeadmutil.CheckErr(err) - PullControlPlaneImages(containerRuntime, &internalcfg.ClusterConfiguration) + err = PullControlPlaneImages(containerRuntime, &internalcfg.ClusterConfiguration) + kubeadmutil.CheckErr(err) }, } AddImagesCommonConfigFlags(cmd.PersistentFlags(), externalClusterCfg, &cfgPath, &featureGatesString)