From fef5c0c1a63d6d1bd2bf20a24dd1ae6d8a2ce16a Mon Sep 17 00:00:00 2001 From: Juan Escobar Date: Thu, 22 Jul 2021 21:42:30 -0500 Subject: [PATCH] Improve storage test skipping pattern. Including a skip method as the first line of a test does not prevent the test to fail in the BeforeEach function. If the test is skipped because of a tag in the name, then we can prevent such odd behavior. --- test/e2e/storage/persistent_volumes-local.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/storage/persistent_volumes-local.go b/test/e2e/storage/persistent_volumes-local.go index 0af3a711331..854bf416d77 100644 --- a/test/e2e/storage/persistent_volumes-local.go +++ b/test/e2e/storage/persistent_volumes-local.go @@ -283,8 +283,8 @@ var _ = utils.SIGDescribe("PersistentVolumes-local ", func() { e2epod.DeletePodOrFail(config.client, config.ns, pod2.Name) }) - ginkgo.It("should set different fsGroup for second pod if first pod is deleted", func() { - e2eskipper.Skipf("Disabled temporarily, reopen after #73168 is fixed") + ginkgo.It("should set different fsGroup for second pod if first pod is deleted [Flaky]", func() { + // TODO: Disabled temporarily, remove [Flaky] tag after #73168 is fixed. fsGroup1, fsGroup2 := int64(1234), int64(4321) ginkgo.By("Create first pod and check fsGroup is set") pod1 := createPodWithFsGroupTest(config, testVol, fsGroup1, fsGroup1)