github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 22:17:14 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #80477 from mborsz/eventssize

Browse Source 
Add 'apiserver_watch_events_sizes'
This commit is contained in:
Kubernetes Prow Robot 2019-08-21 17:38:32 -07:00 committed by GitHub
commit ff1e1127e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/watch.go
View File

@ -238,6 +238,7 @@ func (s *WatchServer) ServeHTTP(w http.ResponseWriter, req *http.Request) {
// type // type
unknown.Raw = buf.Bytes() unknown.Raw = buf.Bytes()
event.Object = &unknown event.Object = &unknown
metrics.WatchEventsSizes.WithLabelValues(kind.Group, kind.Version, kind.Kind).Observe(float64(len(unknown.Raw)))
*outEvent = metav1.WatchEvent{} *outEvent = metav1.WatchEvent{}

9
staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
View File

@ -148,6 +148,14 @@ var (
}, },
[]string{"group", "version", "kind"}, []string{"group", "version", "kind"},
) )
WatchEventsSizes = prometheus.NewHistogramVec(
prometheus.HistogramOpts{
Name: "apiserver_watch_events_sizes",
Help: "Watch event size distribution in bytes",
Buckets: prometheus.ExponentialBuckets(1024, 2.0, 8), // 1K, 2K, 4K, 8K, ..., 128K.
},
[]string{"group", "version", "kind"},
)
// Because of volatality of the base metric this is pre-aggregated one. Instead of reporing current usage all the time // Because of volatality of the base metric this is pre-aggregated one. Instead of reporing current usage all the time
// it reports maximal usage during the last second. // it reports maximal usage during the last second.
currentInflightRequests = prometheus.NewGaugeVec( currentInflightRequests = prometheus.NewGaugeVec(
@ -171,6 +179,7 @@ var (
DeprecatedDroppedRequests, DeprecatedDroppedRequests,
RegisteredWatchers, RegisteredWatchers,
WatchEvents, WatchEvents,
WatchEventsSizes,
currentInflightRequests, currentInflightRequests,
} }
) )