github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #104761 from lauchokyip/improveCM

Browse Source 
Improve create configmap test
This commit is contained in:
Kubernetes Prow Robot 2021-09-16 16:11:45 -07:00 committed by GitHub
commit ff593c89a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
staging/src/k8s.io/kubectl/pkg/cmd/create/create_configmap_test.go
View File

@ -21,6 +21,8 @@ import (
"os" "os"
"testing" "testing"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1" corev1 "k8s.io/api/core/v1"
apiequality "k8s.io/apimachinery/pkg/api/equality" apiequality "k8s.io/apimachinery/pkg/api/equality"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@ -441,21 +443,18 @@ func TestCreateConfigMap(t *testing.T) {
} }
} }
err := configMapOptions.Validate() err := configMapOptions.Validate()
if err == nil { if err == nil {
configMap, err = configMapOptions.createConfigMap() configMap, err = configMapOptions.createConfigMap()
} }
if test.expectErr == "" {
if test.expectErr == "" && err != nil { require.NoError(t, err)
t.Errorf("unexpected error: %v", err) if !apiequality.Semantic.DeepEqual(configMap, test.expected) {
} t.Errorf("\nexpected:\n%#v\ngot:\n%#v", test.expected, configMap)
if test.expectErr != "" && err == nil { }
t.Errorf("was expecting an error but no error occurred") } else {
} require.Error(t, err)
if test.expectErr != "" && test.expectErr != err.Error() { require.EqualError(t, err, test.expectErr)
t.Errorf("\nexpected error:\n%s\ngot error:\n%s", test.expectErr, err.Error())
}
if !apiequality.Semantic.DeepEqual(configMap, test.expected) {
t.Errorf("\nexpected:\n%#v\ngot:\n%#v", test.expected, configMap)
} }
}) })
} }