From ff5a0ccb3650a6de29c8559aee10188b9457c2f3 Mon Sep 17 00:00:00 2001 From: Kevin Wiesmueller Date: Fri, 26 Feb 2021 21:19:04 +0100 Subject: [PATCH] fix validation tests --- .../apis/meta/v1/validation/validation_test.go | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation_test.go b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation_test.go index fd7f8be17db..33c42357418 100644 --- a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation_test.go +++ b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation_test.go @@ -247,20 +247,29 @@ func TestValidateManagedFieldsInvalid(t *testing.T) { { Operation: metav1.ManagedFieldsOperationUpdate, FieldsType: "RandomVersion", + APIVersion: "v1", }, { Operation: "RandomOperation", FieldsType: "FieldsV1", + APIVersion: "v1", }, { // Operation is missing FieldsType: "FieldsV1", + APIVersion: "v1", }, { Operation: metav1.ManagedFieldsOperationUpdate, FieldsType: "FieldsV1", // Invalid fieldManager - Manager: "field\nmanager", + Manager: "field\nmanager", + APIVersion: "v1", + }, + { + Operation: metav1.ManagedFieldsOperationUpdate, + FieldsType: "FieldsV1", + // APIVersion missing }, } @@ -277,20 +286,24 @@ func TestValidateManagedFieldsInvalid(t *testing.T) { func TestValidateMangedFieldsValid(t *testing.T) { tests := []metav1.ManagedFieldsEntry{ { - Operation: metav1.ManagedFieldsOperationUpdate, + Operation: metav1.ManagedFieldsOperationUpdate, + APIVersion: "v1", // FieldsType is missing }, { Operation: metav1.ManagedFieldsOperationUpdate, FieldsType: "FieldsV1", + APIVersion: "v1", }, { Operation: metav1.ManagedFieldsOperationApply, FieldsType: "FieldsV1", + APIVersion: "v1", }, { Operation: metav1.ManagedFieldsOperationApply, FieldsType: "FieldsV1", + APIVersion: "v1", Manager: "🍔", }, }