From ccf488fe117ebb9799099723c6915f090fad7fcf Mon Sep 17 00:00:00 2001 From: mattjmcnaughton Date: Tue, 18 Feb 2020 08:24:25 -0500 Subject: [PATCH] Delete TODO around implementing rate limiting to protect against DOS From discussions in https://github.com/kubernetes/kubernetes/pull/83784, it appears there actually isn't a ton of risk around a DOS. Delete the TODO. --- pkg/kubelet/pluginmanager/pluginwatcher/plugin_watcher.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/kubelet/pluginmanager/pluginwatcher/plugin_watcher.go b/pkg/kubelet/pluginmanager/pluginwatcher/plugin_watcher.go index d6ba3687f25..8e8c546a4b3 100644 --- a/pkg/kubelet/pluginmanager/pluginwatcher/plugin_watcher.go +++ b/pkg/kubelet/pluginmanager/pluginwatcher/plugin_watcher.go @@ -191,7 +191,6 @@ func (w *Watcher) handlePluginRegistration(socketPath string) error { if runtime.GOOS == "windows" { socketPath = util.NormalizePath(socketPath) } - //TODO: Implement rate limiting to mitigate any DOS kind of attacks. // Update desired state of world list of plugins // If the socket path does exist in the desired world cache, there's still // a possibility that it has been deleted and recreated again before it is