Lubomir I. Ivanov
32fbb23f3b
kubeadm: remove usage of the TryRunCommand() function
...
The function TryRunCommand() uses an exponential backoff,
which is good, but it's inconsistent and only used in a couple
of places.
Remove its usage in the token.go#UpdateOrCreateTokens()
and switch to using the standard function used in other places -
PollUntilContextTimeout().
Remove wait.go#TryRunCommand(), as there are no other usages.
2023-12-20 08:51:00 +02:00
Lubomir I. Ivanov
557118897d
kubeadm: drop concurrency when waiting for kubelet /healthz
...
The function wait.go#WaitForKubeletAndFunc() has been used in
a number of places in kubeadm. It starts a go routine to wait for
the kubelet /healthz and in parallel starts another go routine
to wait for an custom function.
This logic is problematic. If kubeadm is waiting for the kubelet
in parallel with something that requires the kubelet, the right
solution would be to first wait for the kubelet in serial and only
then proceed with the other action. The parallelism here particularly
during "init" required a unwanted "initial timeout" of 40s, before
the kubelet waiting even starts. In most cases, this makes the kubelet
waiter to not even start, while the main point of waiting becomes
the "other action".
- Remove the function WaitForKubeletAndFunc() from the Waiter interface.
- Rename the function WaitForHealthyKubelet() to just WaitForKubelet()
to be consistent with the naming WaitForAPI().
- Update WaitForKubelet() to not use TryRunCommand() and instead
use PollUntilContextTimeout().
- Remove the "initial timeout" of 40s in WaitForKubelet().
- Make both WaitForKubelet() and WaitForAPI() use similar error
handling and output.
- Update all usage of WaitForKubelet() to be a serial call before
any other action, such as another wait* call.
- Make the default wait timeout for the kubelet
/healthz to be 1 minute (kubeadmconstants.DefaultKubeletTimeout).
- Apply updates to all implementations of the Waiter interface.
2023-12-20 08:51:00 +02:00
wen.rui
4a7592f8a4
Remove GA feature gate LegacyServiceAccountTokenTracking in 1.30
2023-12-20 13:41:10 +08:00
Kubernetes Prow Robot
0a54839370
Merge pull request #122387 from kerthcet/cleanup/change-error
...
More understandable error for scheduler configuration validation
2023-12-20 06:19:37 +01:00
Kubernetes Prow Robot
27c127403c
Merge pull request #122265 from SataQiu/kubeadm-etcd-1.30
...
kubeadm: add supported etcd version for v1.30
2023-12-20 06:19:30 +01:00
Kubernetes Prow Robot
4111bef430
Merge pull request #122386 from kerthcet/cleanup/add-test
...
Add more testcases when setting up scheduler
2023-12-20 04:11:16 +01:00
Kubernetes Prow Robot
c39414c3b4
Merge pull request #122372 from stevekuznetsov/skuznets/provide-all-meta-apply-configurations
...
k8s.io/code-generator: include all metav1 applyconfigs
2023-12-20 04:11:06 +01:00
kerthcet
1f3e668e18
Use semantic comparation for API
...
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-12-20 10:23:29 +08:00
Jongwoo Han
725b107f49
Correct typo from 'gingko' to 'ginkgo'
...
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
2023-12-20 10:31:53 +09:00
Dan Winship
626f349fef
Drop PendingChanges methods from change trackers, move into UpdateResults
...
This fixes a race condition where the tracker could be updated in
between us calling .PendingChanges() and .Update().
2023-12-19 18:27:33 -05:00
Dan Winship
5d0656b1f6
Squash some unnecessarily-chained methods in the change trackers
...
ServicePortMap.Update() and EndpointsMap.Update() were just a tiny
wrappers around the corresponding apply() methods, which had no other
callers. So squash them together.
(Also fix the variable naming in ServicePortMap.Update() to match
other methods.)
2023-12-19 18:27:33 -05:00
Kubernetes Prow Robot
755b4e2bc4
Merge pull request #121576 from huww98/opti-aswp
...
ad controller: optimize populateActualStateOfWorld
2023-12-19 17:43:45 +01:00
Patrick Ohly
c8f9ebfb72
dependencies: gomega v1.30.0 + ginkgo v2.13.2
...
The new gomega.BeTrueBecause and gomega.BeFalseBecause are going to be useful
for https://github.com/kubernetes/kubernetes/issues/105678 .
2023-12-19 16:18:05 +01:00
Kubernetes Prow Robot
d647d19f6a
Merge pull request #122233 from mzaian/etcd-3511-image
...
etcd: Build image 3.5.11
2023-12-19 14:23:48 +01:00
kerthcet
538248df0d
More understandable error for scheduler configuration validation
...
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-12-19 19:13:30 +08:00
SataQiu
64da434523
kubeadm: hide unwanted global klog flags
2023-12-19 18:49:01 +08:00
kerthcet
b6eac505fb
Add testcase setup scheduler
...
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-12-19 17:53:24 +08:00
SataQiu
2edb334993
kubeadm: hide unwanted global klog flags
2023-12-19 16:32:30 +08:00
Kubernetes Prow Robot
b5ba7bc4f5
Merge pull request #122126 from liggitt/duplicate-warning
...
Update duplicate env var warning
2023-12-19 04:37:27 +01:00
Kubernetes Prow Robot
42ab3b7b40
Merge pull request #121833 from borg-land/fix-lb-logic
...
Look for the ingress-uid cm after the Loadbalancer is created
2023-12-19 00:26:39 +01:00
Anish Ramasekar
75695dae10
move encryption config types to standard API server config location
...
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
2023-12-18 20:54:24 +00:00
Steve Kuznetsov
868114a41d
k8s.io/code-generator: include all metav1 applyconfigs
...
When users of `applyconfiguration-gen` use any of the `metav1` types in
their own types, they expect to have correct apply configurations
generated without having to explicitly pass anything to the tool. In the
same way that we used to include `metav1.ObjectMeta` and
`metav1.TypeMeta`, we now include all of the `metav1` types that have
apply-configurations generated for them in `client-go`. There's no
downside to loading these types, so there's no reason to omit any.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2023-12-18 13:39:27 -07:00
Kubernetes Prow Robot
2b5c0c281d
Merge pull request #122310 from weilaaa/use_buildin_max_min_instead
...
use build-in max and min func to instead of k8s.io/utils/integer funcs
2023-12-18 19:25:34 +01:00
Kubernetes Prow Robot
d74705119d
Merge pull request #122334 from carlory/fix-118893-4
...
NodeUnschedulable: scheduler queueing hints
2023-12-18 18:13:52 +01:00
Kubernetes Prow Robot
296e1bfb40
Merge pull request #122332 from SataQiu/drop-127-api-testdata
...
Drop v1.27.0 API testdata
2023-12-18 18:13:43 +01:00
Kubernetes Prow Robot
c8047a604a
Merge pull request #122331 from SataQiu/v1.29.0-api-testdata
...
Add v1.29.0 API testdata
2023-12-18 18:13:34 +01:00
Kubernetes Prow Robot
9dc0dbe878
Merge pull request #122195 from nayihz/feat_queuinghints
...
podtopologyspread: scheduler queueing hints
2023-12-18 16:58:12 +01:00
Kubernetes Prow Robot
56d0da546a
Merge pull request #121950 from sanposhiho/doc-postfilter
...
fix(framework): elaborate the document on PostFilter
2023-12-18 16:57:49 +01:00
Jordan Liggitt
b6e34187ca
Update duplicate env var warning
2023-12-18 10:06:30 -05:00
Kubernetes Prow Robot
368dfe3a88
Merge pull request #122036 from linxiulei/cleanup
...
Minor cleanup for handlers/watch
2023-12-18 13:16:03 +01:00
Kensei Nakada
1d0453127d
feature(NodeAffinity): return Skip in PreScore when nothing to do in Score
2023-12-18 12:00:10 +00:00
Kubernetes Prow Robot
b46e436e18
Merge pull request #121684 from jmhbnz/fix-etcd-repo
...
Fix etcd repository path to prevent redirects
2023-12-18 10:27:04 +01:00
Kubernetes Prow Robot
38e715de26
Merge pull request #122083 from mengjiao-liu/cleanup-HealthcheckType
...
Clean up unused type `HealthcheckType`.
2023-12-18 08:33:40 +01:00
Kubernetes Prow Robot
138ac71fb1
Merge pull request #122011 from carlory/fix-121752
...
fix falky test pkg/registry/core/persistentvolume/storage TestUpdateStatus
2023-12-18 06:21:00 +01:00
Kubernetes Prow Robot
e94a712fbd
Merge pull request #122359 from bart0sh/PR128-cluster-gce-upgrade-cos-image-family
...
cluster/gce: upgrade cos-97-lts -> cos-109-lts
2023-12-18 01:12:13 +01:00
Ed Bartosh
85cc2b3833
cluster/gce: upgrade cos-97-lts -> cos-109-lts
2023-12-17 20:58:13 +02:00
Kubernetes Prow Robot
054cacf2eb
Merge pull request #122358 from borg-land/release-tar-patch
...
Add extra locations to check for release-tars
2023-12-17 17:57:58 +01:00
upodroid
1ee8183903
add extra locations to check for release-tars
2023-12-17 15:36:33 +00:00
nayihz
09a80df1d1
podtopologyspread: scheduler queueing hints
2023-12-17 14:30:53 +08:00
Kubernetes Prow Robot
e6acd1caf5
Merge pull request #122330 from dims/remove-unused-code-in-kubelet
...
Remove unused code in kubelet - DockerContainer / ContainerInfo / SubcontainerInfo / WatchEvents
2023-12-16 23:46:02 +01:00
carlory
d36a7089cd
scheduler/NodeUnschedulable: reduce pod scheduling latency
...
Co-authored-by: wackxu <xushiwei5@huawei.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
2023-12-16 20:50:11 +08:00
Kubernetes Prow Robot
76cd7521aa
Merge pull request #121912 from JoelSpeed/cel-ip-addr
...
CEL library extensions for IP Address and CIDR network parsing
2023-12-16 11:06:04 +01:00
James Blair
b6c1f8ef08
Fix etcd repository path to prevent redirects.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2023-12-16 19:50:02 +13:00
Kubernetes Prow Robot
162599da69
Merge pull request #122311 from nayihz/fix_122304
...
add unit test for the scheduling queue for QueueingHint disabled
2023-12-16 03:48:58 +01:00
Davanum Srinivas
642574e964
WatchEvents seems useless
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 17:07:20 -05:00
Davanum Srinivas
aee1d54a0d
Drop SubcontainerInfo
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 16:58:00 -05:00
Davanum Srinivas
c865ad532a
fixing based on feedback in PR
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 16:51:15 -05:00
Kubernetes Prow Robot
4cff5e8d2d
Merge pull request #122329 from jpbetz/fix-crd-drop-fields
...
Bug fix: Enable CRD field dropping for validation ratcheting
2023-12-15 20:55:48 +01:00
Jefftree
9d1829c33a
Make OpenAPIGetter tolerant of nil
2023-12-15 13:44:54 -05:00
Kubernetes Prow Robot
55f1e21fdc
Merge pull request #122341 from jsafrane/fix-vsphere-migration
...
Fix CSI migration for vSphere volumes
2023-12-15 18:33:14 +01:00