Commit Graph

6978 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
f051670a47 Merge pull request #133087 from atiratree/terminating-replicas-beta
promote DeploymentReplicaSetTerminatingReplicas to Beta
2025-10-27 04:47:37 -07:00
Kubernetes Prow Robot
82e2a3e117 Merge pull request #134763 from jpbetz/api-machinery-controller-owners
Clean up OWNERS for all api machinery owned controllers
2025-10-24 12:15:34 -07:00
Kubernetes Prow Robot
60e1f61a63 Merge pull request #133511 from BenTheElder/no-md5
eliminate md5 usage, block new usage
2025-10-24 10:59:35 -07:00
Joe Betz
0e7d42dd45 Clean up OWNERS for all api machinery owned controllers 2025-10-24 13:38:10 -04:00
Kubernetes Prow Robot
3c4a7184d8 Merge pull request #134231 from michaelasp/svmRobustness
feat: Improve the robustness of SVM
2025-10-24 10:09:38 -07:00
Kubernetes Prow Robot
ee58e792cc Merge pull request #134812 from skitt/enable-gocritic-unlambda
Avoid no-change lambdas
2025-10-23 15:43:34 -07:00
Kubernetes Prow Robot
57c243f33c Merge pull request #134450 from mayank-agrwl/controller-contextual-logs
Replace HandleCrash and HandleError calls to use context-aware alternatives
2025-10-23 00:49:02 -07:00
Stephen Kitt
1e2817d589 Avoid no-change lambdas
This replaces functions that wrap another function with no change with
a direct reference to the wrapped function.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2025-10-23 09:46:15 +02:00
Benjamin Elder
a99a5c4bdc avoid updating when endpoint subsets are merely sorted differently 2025-10-22 08:07:19 -07:00
Kubernetes Prow Robot
497ed03ae7 Merge pull request #134525 from omerap12/hpa-monitor-test-flake
Remove flaky HPA deletion assertion in TestMultipleHPAs
2025-10-22 06:36:41 -07:00
Kubernetes Prow Robot
0ba43e9f5e Merge pull request #134739 from shyamjvs/epslice-controller-fix
Introduce pod queuing in endpoint/slice controllers
2025-10-22 00:44:39 -07:00
Shyam Jeedigunta
8346bed9e7 Introduce pod queuing in endpoint/slice controllers 2025-10-21 17:08:01 -07:00
Joe Betz
d54f3b56ed Add OWNERS for controller/storageversionmigrator 2025-10-21 17:06:53 -04:00
Jordan Liggitt
91d135f344 Include relevant dimensions in pod controller indexing 2025-10-16 13:27:50 -04:00
Kubernetes Prow Robot
2453394c0a Merge pull request #134267 from zk-123/optimization/serviceaccount-token-controller
refactor(serviceaccount-tokens-controller): Change MutationCache to SecretLister
2025-10-16 00:15:37 -07:00
Kubernetes Prow Robot
db63a581ca Merge pull request #134366 from tallclair/feature-gates-test
Set multiple feature gates simultaneously in test
2025-10-13 13:11:33 -07:00
Filip Křepinský
dd3a713f6c fix ReplicaSet and Deployment tests for DeploymentReplicaSetTerminatingReplicas FG enablement 2025-10-10 21:47:02 +02:00
PersistentJZH
b738e8c3ca fix panic in cron.ParseStandard
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

fix

optimize logic

fix unit test
2025-10-10 23:51:05 +08:00
Omer Aplatony
4f8757b4c0 Remove flaky HPA deletion assertion in TestMultipleHPAs
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2025-10-10 12:00:35 +00:00
Kubernetes Prow Robot
ee1ff4866e Merge pull request #134479 from pohly/dra-device-taint-no-execute-toleration-fix
DRA device taints: fix toleration of NoExecute
2025-10-10 00:47:00 -07:00
zhengkai
233ad2071c refactor(serviceaccount-tokens-controller): Change the secret's MutationCache to SecretLister 2025-10-10 11:30:34 +08:00
Michael Aspinwall
4616d749a3 feat: Improve the robustness of SVM
Add handling for retriable errors, terminal cases and unit tests for SVM. Also move the comparisons of resource version to use the built in helper provided by apimachinery.
2025-10-09 15:13:05 +00:00
Patrick Ohly
6f51446802 DRA device taints: fix toleration of NoExecute
As usual, consumers of an allocated claim react to the information stored in
the status. In this case, the scheduler did not copy the tolerations into the
status and as a result a pod with a toleration for NoExecute got scheduled and
then immediately evicted.

Some additional logging gets added to make the handling easier to track in the
eviction controller. Example YAMLs allow reproducing the use case manually.
2025-10-08 13:13:47 +02:00
Mayank Agrawal
5e216ae34d Replace HandleCrash and HandleError calls to use context-aware alternatives 2025-10-07 22:40:10 -07:00
Adrian Moisey
ae25979790 Use a dedicated delete channel in HPA test
This is an attempt to fix a flake
2025-10-02 21:22:10 +02:00
Kubernetes Prow Robot
16eebeb5ee Merge pull request #134379 from liggitt/gc-race
Lock all mutable fields when printing gc node
2025-10-02 11:40:56 -07:00
Jordan Liggitt
6d3d7553fb Lock all mutable fields when printing gc node 2025-10-02 08:50:17 -04:00
Tim Allclair
4986abe0b8 Automated refactoring to use SetFeatureGatesDuringTest 2025-10-01 21:10:53 -07:00
Kubernetes Prow Robot
ef95e1fd7e Merge pull request #134318 from xigang/disruption
disruption: remove unused pdb parameter from getExpectedScale method
2025-10-01 07:38:27 -07:00
Kubernetes Prow Robot
6bb0bd55a3 Merge pull request #134295 from omerap12/hpa-desiredReplicasCount-metric
Add desired_replicas gauge metric to HPA controller
2025-10-01 05:16:17 -07:00
Kubernetes Prow Robot
7353b6a93d Merge pull request #134312 from alaypatel07/gc-resourceclaim-extendedresource
fix resource claims deallocation for extended resource when pod is completed
2025-09-30 01:38:20 -07:00
Alay Patel
8a03067211 fix resource claims deallocation for extended resource when pod is completed
Signed-off-by: Alay Patel <alayp@nvidia.com>
2025-09-29 15:15:40 -04:00
xigang
574ac5b497 disruption: remove unused pdb parameter from getExpectedScale method
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-09-28 17:41:36 +08:00
xigang
574b09b7de nodelifecycle: fix ComputeZoneState method comment
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-09-28 10:56:56 +08:00
Omer Aplatony
7af3377900 Add desired_replicas histogram metric to HPA controller
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2025-09-27 09:30:03 +00:00
Kubernetes Prow Robot
1eb2c4182d Merge pull request #134102 from mayank-agrwl/namespace-nodelifecycle-contextual
Replace HandleError with HandleErrorWithContext
2025-09-23 18:50:17 -07:00
Omer Aplatony
a8a21aaf85 Add hpa object count metric (#134140)
* Add hpa object count metrics

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* change name to num_horizontal_pod_autoscalers

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* remove log line

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2025-09-22 06:10:19 -07:00
Kubernetes Prow Robot
b4943a9dc9 Merge pull request #134104 from aditigupta96/refactor-cloud-node-controllers
refactor(controller): Use WithContext variants in cloud node controllers
2025-09-18 10:32:22 -07:00
Kubernetes Prow Robot
d7bd2b0343 Merge pull request #134030 from richabanker/update-metrics-docs
Update metrics docs list for v1.34
2025-09-18 08:04:15 -07:00
Edwin Hernandez
fa9071302f Adding metrics for Maxunavailable feature in StatefulSet (#130951)
* adding maxunavailable_violation metric

added metric to list of stable metrics

changed when metric gets incremented

addressed comments

fixed stable metrics list

* Update pkg/controller/statefulset/metrics/metrics.go

Co-authored-by: Filip Křepinský <fkrepins@redhat.com>

* Update the metric and log verbosity level

* Address false positives metric count

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* Implement maxUnavailable and UnavailableReplicas metrics

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* fix lint fmt

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* update tests

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* se metrics to 1 as a default

* log for true validation only and update func sig.

* Move maxUnavailable metric to the updateStatefulSetStatus

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* change metrics stability level to Alpha

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* fix unit test

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* fix linting issue

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* Address code review feedback

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

---------

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
Co-authored-by: Filip Křepinský <fkrepins@redhat.com>
Co-authored-by: Heba Elayoty <heelayot@microsoft.com>
2025-09-17 05:34:14 -07:00
Aditi Gupta
f58d1e101f refactor(controller): Use WithContext variants in cloud node controllers
This change refactors the cloud-specific versions of the node lifecycle
and node IPAM controllers to use a context.Context for cancellation and
contextual logging, replacing the legacy stopCh pattern.

This is a follow-up to PR #133985, where these controllers were
separated out due to their use in the legacy Cloud Controller Manager
(CCM).

It is a known issue that the CCM's startup logic does not pass the
controller name via the context. This change proceeds with the
refactoring to unify the cancellation logic across controllers, while
acknowledging that contextual logs will be less detailed when these
controllers are run in the CCM.

Signed-off-by: Aditi Gupta <aditigpta@google.com>
2025-09-17 00:17:38 -07:00
Mayank Agrawal
d12eeb98d0 Replace HandleError with HandleErrorWithContext 2025-09-16 23:47:23 -07:00
Kubernetes Prow Robot
69e92c6827 Merge pull request #134022 from aditigupta96/cleanup-waitfornamedcachesync
refactor(controller): Use context-aware WaitForNamedCacheSync in resourcequota and HPA tests
2025-09-16 17:18:16 -07:00
Kubernetes Prow Robot
d03d25f47c Merge pull request #133985 from aditigupta96/api-waitfornamedcachesync-with-context
Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/
2025-09-16 17:18:09 -07:00
Aditi Gupta
af231d2153 Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/ 2025-09-16 14:51:34 -07:00
Kubernetes Prow Robot
12ddfaa5c7 Merge pull request #133984 from aditigupta96/add-context-to-waitfornamedcachesync
Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/garbagecollector
2025-09-16 13:48:10 -07:00
Richa Banker
c51a8734b1 Update documented metrics list 2025-09-16 11:52:14 -07:00
Aditi Gupta
1ce12710ec refactor(controller): Use context-aware WaitForNamedCacheSync in resourcequota and HPA tests 2025-09-12 12:37:54 -07:00
Kubernetes Prow Robot
118e833a0d Merge pull request #133687 from soltysh/drop_PodIndexLabel
Drop PodIndexLabel after the feature GA-ed in 1.32
2025-09-12 07:30:11 -07:00
Kubernetes Prow Robot
44544abdc7 Merge pull request #133612 from michaelasp/discoveryCheck
feat: Add discovery check to SVM to ensure migration doesn't get stuck
2025-09-11 18:32:07 -07:00