Commit Graph

76350 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
ec64aef25f Merge pull request #74321 from yastij/signal-undecorated-storage-event
use cache size to signal undecorated storage
2019-03-24 03:21:05 -07:00
Kubernetes Prow Robot
9f15368c5c Merge pull request #75576 from smarterclayton/bad_2
Remove use of `%#v` in frequently accessed code
2019-03-22 23:59:05 -07:00
Kubernetes Prow Robot
29e74dc58c Merge pull request #75021 from cwdsuzhou/protectionutil
Move protection common funcs to protectionutil
2019-03-22 22:15:07 -07:00
Kubernetes Prow Robot
206ecb4ab8 Merge pull request #71326 from shomron/issue-71277-polluntil-leak
Fix goroutine leak in pkg/util/wait PollUntil()
2019-03-22 20:57:06 -07:00
Jonathan Basseri
1b447e8d19 Scheduler: Logging cleanup in predicates.go.
This is some light cleanup of logs in predicates.go. In particular, some
log lines have details clarified that will make debugging easier.

I have not touched any VLOG messages, since those usually have plenty of
detail.
2019-03-22 17:33:18 -07:00
Kubernetes Prow Robot
3dfe9072ad Merge pull request #75615 from oomichi/golint-e2e-framework
Fix golint failures of e2e/framework/[a-c].go
2019-03-22 17:02:35 -07:00
Kubernetes Prow Robot
9c53f24012 Merge pull request #75179 from rosti/kill-v1alpha3
kubeadm: remove v1alpha3
2019-03-22 17:02:21 -07:00
Kubernetes Prow Robot
ffd8f3dacb Merge pull request #73255 from ds-ms/golint
Fix linting issues in pkg/kubectl/cmd/version
2019-03-22 17:02:08 -07:00
Kubernetes Prow Robot
18ac575d9b Merge pull request #75611 from neolit123/e2e-fw-owners
test/e2e/framework: add OWNERS file
2019-03-22 15:46:46 -07:00
Kubernetes Prow Robot
3312da83c9 Merge pull request #75602 from smarterclayton/kubelet_proto
Kubelet should request protobuf from the apiserver
2019-03-22 15:46:34 -07:00
Kubernetes Prow Robot
994582965d Merge pull request #75496 from andrewsykim/area-cloudprovider-label
add area/cloudprovider label for changes in pkg/cloudprovider & k8s.i…
2019-03-22 15:46:21 -07:00
Kubernetes Prow Robot
a3bc56fffb Merge pull request #74746 from oomichi/golint-e2e-framework-gce
Fix golint failures under test/e2e/[..]/gce
2019-03-22 15:46:08 -07:00
Kenichi Omichi
63f44a0bbf Fix golint failures of e2e/framework/[a-c].go
This fixes golint failures on the following files:
- test/e2e/framework/authorizer_util.go
- test/e2e/framework/cleanup.go
- test/e2e/framework/create.go
2019-03-22 21:16:45 +00:00
Kubernetes Prow Robot
290cf142e1 Merge pull request #75302 from liggitt/apps-v1-test
Use apps/v1 APIs in integration tests
2019-03-22 14:09:49 -07:00
Kubernetes Prow Robot
fcb102b2a4 Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh
fix eliminate shellcheck failures in hack/lib/golang.sh
2019-03-22 14:09:37 -07:00
Lubomir I. Ivanov
e0f0d4c9f8 test/e2e/framework: add OWNERS file 2019-03-22 21:00:07 +02:00
Kubernetes Prow Robot
b3824cd094 Merge pull request #75570 from smarterclayton/fix_performance
Fix a regression in watch performance and reduce allocations in the GET path
2019-03-22 11:42:51 -07:00
Clayton Coleman
0489d0b1cf Unify runtime.SerializerInfo with negotiate.AcceptedMediaTypes
There was no reason to have two types and this avoids ~10% of allocations
on the GET code path.

```
BenchmarkGet-12          	  100000	    109045 ns/op	   17608 B/op	     146 allocs/op

BenchmarkGet-12          	  100000	    108850 ns/op	   15942 B/op	     132 allocs/op
```
2019-03-22 13:24:25 -04:00
Clayton Coleman
59b4f47b22 Avoid 3 object creations when no dryRun parameter is provided
These allocations should only occur rarely.

```
BenchmarkGet-12          	  100000	    108013 ns/op	   17732 B/op	     149 allocs/op

BenchmarkGet-12          	  100000	    109045 ns/op	   17608 B/op	     146 allocs/op
```
2019-03-22 13:24:24 -04:00
Clayton Coleman
83c41eab1d Avoid an allocation on all requests when checking for an old user agent
ReplaceAllStrings always allocates, while scanning a relatively short
regex twice is slightly more CPU immediately but less later.

```
BenchmarkGet-12          	  100000	    108824 ns/op	   17818 B/op	     152 allocs/op

BenchmarkGet-12          	  100000	    108013 ns/op	   17732 B/op	     149 allocs/op
```
2019-03-22 13:24:24 -04:00
Clayton Coleman
58fb665646 IsListType uses reflection and is expensive for hot paths
IsListType was causing ~100 allocations for a non list object. It is
used in a wide range of code, so perform a more targeted check.

The use of `%#v` in a hot return path for `fmt.Errorf()` was the main
victim.

Replace `%#v` with a typed error and create a cache of types that are
lists with a bounded size (probably not necessary, but safer).

```
BenchmarkGet-12          	  100000	    119635 ns/op	   20110 B/op	     206 allocs/op
BenchmarkWatchHTTP-12    	  100000	     65761 ns/op	    7296 B/op	     139 allocs/op

BenchmarkGet-12          	  100000	    109085 ns/op	   17831 B/op	     152 allocs/op
BenchmarkWatchHTTP-12    	  200000	     33966 ns/op	    1913 B/op	      30 allocs/op
```
2019-03-22 13:24:24 -04:00
Clayton Coleman
7d53ad1fb0 Kubelet should request protobuf from the apiserver
The kubelet was not asking for application/vnd.kubernetes.protobuf
on list and get calls. It looks like we lost that code when we
moved to cert rotation. Clean up the client initialization path
and make sure that all non-dynamic clients use protobuf by default.
2019-03-22 12:42:20 -04:00
Kenichi Omichi
da7c9f70c3 Fix golint failures under test/e2e/[..]/gce
This fixes golint failures under test/e2e/framework/providers/gce/.

Cleanup:
* FirewallTimeoutDefault is not used at all, so remove it.
* FirewallTestTcpTimeout, FirewallTestHttpPort and FirewallTestUdpPort
  are used at test/e2e/network/firewall.go only. So move them.
2019-03-22 15:59:17 +00:00
Clayton Coleman
2e1506558a Add benchmark for naive endpoint Get so we can measure it
Baseline:

```
BenchmarkGet-12          	  100000	    119635 ns/op	   20110 B/op	     206 allocs/op
BenchmarkWatchHTTP-12    	  100000	     65761 ns/op	    7296 B/op	     139 allocs/op
```
2019-03-22 11:43:39 -04:00
Kubernetes Prow Robot
e739b55374 Merge pull request #75585 from tiffanyfay/cache
Updated client-go expiration cache to take in expiration policies
2019-03-22 07:06:20 -07:00
Kubernetes Prow Robot
1e184775aa Merge pull request #75214 from deads2k/health
provide verbose output when health check fails
2019-03-22 05:22:31 -07:00
Kubernetes Prow Robot
265f80eef9 Merge pull request #75176 from mars1024/bugfix/hpa_not_working_in_kubectl_since_v1.13
make describers of different versions work properly when autoscaling/v2beta2 is not supported
2019-03-22 05:22:17 -07:00
Kubernetes Prow Robot
057ad6d4ce Merge pull request #75571 from Huang-Wei/shorten-alias
shorten scheduler package alias for better readability
2019-03-22 02:34:17 -07:00
tiffany jernigan
bc226a2a89 Updated client-go expiration cache to take in expiration policies 2019-03-22 07:38:35 +00:00
Kubernetes Prow Robot
ab35bd0668 Merge pull request #75577 from mars1024/bugfix/use_add_in_enqueue
replace AddRateLimited with Add in enqueue func
2019-03-22 00:04:57 -07:00
Kubernetes Prow Robot
efaf4f3bdb Merge pull request #75507 from hex108/skip
Avoid unnecessary sort for some cases in selectVictimsOnNode
2019-03-22 00:04:44 -07:00
Kubernetes Prow Robot
dfe2e0e705 Merge pull request #75349 from brahmaroutu/cifailure_daemonset
Daemon Set Conformance test fails in CI process using ci-kubernetes-c…
2019-03-22 00:04:30 -07:00
Kubernetes Prow Robot
83d467c22e Merge pull request #75270 from justincormack/uuid4
Use UUIDv4 not UUIDv1
2019-03-22 00:04:17 -07:00
Kubernetes Prow Robot
0118630abf Merge pull request #75072 from lblackstone/dynamic-get-name-validation
Check for required name parameter in dynamic client
2019-03-21 22:51:10 -07:00
Kubernetes Prow Robot
657951c3ed Merge pull request #74889 from akutz/feature/get-kube-binaries-client-choice
Allow choice of os/arch when downloading client
2019-03-21 22:50:57 -07:00
Kubernetes Prow Robot
22621ca415 Merge pull request #74739 from moshe010/nokubeproxy
Add nokubeproxy option in START_MODE
2019-03-21 22:50:44 -07:00
Kubernetes Prow Robot
8ef336c05a Merge pull request #74568 from hex108/pv
Remove redundant checker whether pod has claims in func FindPodVolumes
2019-03-21 22:50:31 -07:00
Kubernetes Prow Robot
51b5d28c15 Merge pull request #74333 from SataQiu/fix-shell-20190221
Fix some shellcheck failures in hack
2019-03-21 22:50:18 -07:00
Kubernetes Prow Robot
4c16fb78b3 Merge pull request #74242 from xichengliudui/fixshellcheck19021903
fix shellcheck in hack/make-rules/...
2019-03-21 21:36:17 -07:00
toyoda
a52af3a9d5 fix shellcheck failure golang.sh 2019-03-22 13:29:26 +09:00
Bruce Ma
0335867b56 replace AddRateLimited with Add in enqueue func 2019-03-22 11:40:23 +08:00
Clayton Coleman
435db312e1 Avoid using %#v for errors when %T is more informative
`%#v` may have significant performance costs in frequently invoked code.
2019-03-21 22:54:06 -04:00
Clayton Coleman
ecd43f13cf Avoid using %#v for errors when %T or %s would be more accurate
`%#v` may have significant performance costs in frequently invoked code.
2019-03-21 22:53:43 -04:00
Clayton Coleman
082aee343e Avoid using %#v for errors when %T is clearer
`%#v` may have significant performance costs in frequently invoked code.
2019-03-21 22:53:07 -04:00
Clayton Coleman
b28e82ad4a Avoid using %#v for errors when using only a portion of the object
`%#v` may have significant performance costs in frequently invoked code.
2019-03-21 22:52:09 -04:00
Kubernetes Prow Robot
c48ed1c5ac Merge pull request #74356 from oomichi/golint-e2e-framework-kubemark
Fix golint failures for e2e/[..]/kubemark
2019-03-21 19:26:32 -07:00
Kubernetes Prow Robot
4499275cb9 Merge pull request #72800 from stewart-yu/stewart-component-base
Move config local to every controller in KCM
2019-03-21 19:26:19 -07:00
Wei Huang
49346c1e04 shorten scheduler package alias for better readability
- schedulerinternalcache -> internalcache
2019-03-21 18:14:19 -07:00
Kubernetes Prow Robot
775d298cb0 Merge pull request #75347 from kanwar-saad/secret_negative_test_fix
test/e2e: Fix double error in secret negative testcase
2019-03-21 17:32:30 -07:00
Kubernetes Prow Robot
e5d99f893b Merge pull request #75280 from pontiyaraja/volumes
removed time flaky and added default pod delete timeout
2019-03-21 17:32:17 -07:00