Since we never use the cobras "SilenceErrors" or "SilenceUsage",
a command executed with "cmd.Execute()" will never return an error
without printing it.
The current behavior results in all error messages being printed twice:
Example:
$ kubectl abc
Error: unknown command "abc" for "kubectl"
Run 'kubectl --help' for usage.
unknown command "abc" for "kubectl"
This applies to all cli commands using Cobra. To verify, follow the code
path of the Execute function:
https://github.com/spf13/cobra/blob/c439c4fa0937/command.go#L793
Signed-off-by: Odin Ugedal <odin@ugedal.com>
Fixed the way Stop identified the fakeClockWaiter to remove, and the
logic for the bool to return.
Fixed Reset to side-effect the waiter in the clock's slice rather than
the original copy.
Added a test func for FakeClock timers.
Fixed Reset too
Improved comments in clock.go to address reviewer comments
Hopefully the updated comments make clear the answers to recent
reviewer comments.
The driver and provisioner runs as privileged, so make all the other
sidecar containers privileged too.
This helps on system with SELinux, non-privileged container can't access
socket of a privileged one.
Some of the entrypoint-tester related tests overrides agnhost's default entrypoint
with agnhost-2, and this function's args will only contain the subcommand's
args (./agnhost entrypoint-tester these args), but we need to print *all* the
args, which is why os.Args should be printed instead.
If kubelet never gets past sandbox creation (i.e., never attempted to
create containers for a pod), it should retry the sandbox creation on
failure, regardless of the restart policy of the pod.
- comment out Liz and Chuck until further notice.
Feel free to come back to kubeadm!!
- Add SataQiu as reviewer. Welcome.
- Add ereslibre as approver. Congrats!
Quite a few images are only used a few times in a few tests. Thus,
the images are being centralized into the agnhost image, reducing
the number of images that have to be pulled and used.
This PR replaces the usage of the following images with agnhost:
- audit-proxy
- crd-conversion-webhook
- entrypoint-tester
- inclusterclient
- iperf
- porter
- serve-hostname
