Tim Hockin
067a328284
Move import-boss: k/code-generator/cmd -> k/k/cmd
2024-02-29 22:07:36 -08:00
Tim Hockin
7776496309
EOL code-generator/generate-groups scripts
...
There's no easy way to make it work in the new model. Callers add flags
to the commandline like:
```
"${CODEGEN_PKG}/generate-internal-groups.sh" "client,conversion,deepcopy,defaulter,informer,lister,openapi" \
k8s.io/code-generator/examples/apiserver \
k8s.io/code-generator/examples/apiserver/apis \
k8s.io/code-generator/examples/apiserver/apis \
"example:v1 example2:v1 example3.io:v1" \
--output-base "${SCRIPT_DIR}/../../../.." \
--go-header-file "${SCRIPT_DIR}/boilerplate.go.txt"
```
To support this we would need to parse these flags in these scripts and
try to adapt them to the new CLI tool interfaces. Not impossible, but
seeing as we deprecated these a few releases ago AND that we have other
breaking changes to the tools, let's just rip this bandaid off?
2024-02-29 22:07:35 -08:00
Tim Hockin
9cf189f4e0
Fix lint found by golangci-lint
2024-02-29 22:07:34 -08:00
Tim Hockin
14321ef959
Move doc-generation funcs into only caller
2024-02-29 22:07:33 -08:00
Tim Hockin
8288c06b2b
Make hack scripts use go install and assume PATH
...
Now that they all call setup_env, we don't need find-binary (I think).
That was originally meant to hide the diff between docker and local
builds but all these tools do local builds anyway.
2024-02-29 22:07:32 -08:00
Tim Hockin
ea3696dbcf
Remove legacy references to './output'
2024-02-29 22:07:31 -08:00
Tim Hockin
242b4e27c0
No need to check nil iterating gengo Inputs
2024-02-29 22:07:31 -08:00
Tim Hockin
7a084b3352
Renamed gengo SourcePath -> Dir
2024-02-29 22:07:30 -08:00
Tim Hockin
96b91f364a
Renamed gengo Builder -> Parser
2024-02-29 22:07:29 -08:00
Tim Hockin
cb86010d20
Gengo utils moved
2024-02-29 22:07:28 -08:00
Tim Hockin
236ce54aa8
The gengo "args" package is gone
2024-02-29 22:07:27 -08:00
Tim Hockin
b40e4d7e70
Get rid of gengo CustomArgs
2024-02-29 22:07:26 -08:00
Tim Hockin
86d2ecbf9a
Move gengo/examples/defaulter -> code_generator
...
This includes tests, which all pass. Also fixes a bunch of lint.
2024-02-29 22:07:25 -08:00
Tim Hockin
cb7f0593ae
Move gengo/examples/deepcopy -> code_generator
...
Merge comments in main.go and fix a bunch of pre-existing lint errors.
2024-02-29 22:07:24 -08:00
Tim Hockin
01a1865934
Fix lint in code-generator/cmd/...
...
Later commits touch code around here, which triggers verify. This
commit JUST fixes lint.
2024-02-29 22:07:24 -08:00
Tim Hockin
b68340e5b6
Get rid of gengo InputDirs flag
2024-02-29 22:07:23 -08:00
Tim Hockin
299b045307
codegen: Remove most uses of InputDirs
...
This clears the path to getting rid of it completely.
2024-02-29 22:07:22 -08:00
Tim Hockin
e78dc86288
Move import-boss to k/k, retool to not use gengo
...
* Moved code and tests out of gengo -> code_generator
* Reworked it to use packages.Load
* Reworked tests (still not comprehensive but pretty good?)
* Dropped test support from gengo (support for tests in
x/tools/go/packages is pretty hostile to gengo, and nobody used it)
2024-02-29 22:07:21 -08:00
Tim Hockin
08ce6a0f14
Get rid of gengo WithoutDefaultFlagParsing
2024-02-29 22:07:20 -08:00
Tim Hockin
5b2d4384c7
codegen: Make import-boss do it's own flags
2024-02-29 22:07:19 -08:00
Tim Hockin
1fed36b984
codegen: Minor: fix wrong comments
2024-02-29 22:07:18 -08:00
Tim Hockin
6420e64662
Move go-header-file flag to each tool
...
Also remove the build-tag flag (unused, untested).
This changes some output comments (less redundant).
2024-02-29 22:07:17 -08:00
Tim Hockin
3a77592b2c
Remove gengo verify-only - unused and untested
...
All of our own tools emit into a tmp tree and then diff that.
2024-02-29 22:07:17 -08:00
Tim Hockin
d0dd72b01e
Move OutputFileBase flag to each tool
2024-02-29 22:07:16 -08:00
Tim Hockin
26a1a13b80
Rename output-package -> output-pkg
...
To parallel "output-dir".
2024-02-29 22:07:15 -08:00
Tim Hockin
6a375b8f4c
Move the OutputBase flag to each tool
...
...and rename to --output-dir
2024-02-29 22:07:14 -08:00
Tim Hockin
875566f997
Type-assert gengo CustomArgs blindly
...
If it does fail, it is catastophic. Don't bother trying to handle it.
2024-02-29 22:07:13 -08:00
Tim Hockin
0ff7dd1943
Rename gengo DefaultGen -> GolangGenerator
2024-02-29 22:07:12 -08:00
Tim Hockin
2ac119bea9
Rename gengo Target.SourcePath() -> Dir()
2024-02-29 22:07:11 -08:00
Tim Hockin
fcd6c19c24
Rename gengo generator.Package -> Target
2024-02-29 22:07:10 -08:00
Tim Hockin
d2c7401910
Drop generator.Packages type
2024-02-29 22:07:10 -08:00
Tim Hockin
b2832697d5
Rename DefaultPackage to SimplePackage
2024-02-29 22:07:09 -08:00
Tim Hockin
bd31265d23
Make update-vendor log the go env
2024-02-29 22:07:08 -08:00
Tim Hockin
4627a15ac0
Get rid of vendor baggage in go-to-proto
2024-02-29 22:07:07 -08:00
Tim Hockin
4320631265
codegen: Don't need to pass --logtostderr
...
All the tools already set it internally
2024-02-29 22:07:06 -08:00
Tim Hockin
2c0da11c0a
Make verify-shellcheck take optional args
2024-02-29 22:07:05 -08:00
Tim Hockin
19b37f046f
Rename update-generated-* dockerized
...
Now they don't start with "update" and confuse dumb scripts which try to
run all the updates.
2024-02-29 22:07:04 -08:00
Tim Hockin
94b709c0e2
codegen: Use single-dash for '-v'
2024-02-29 22:07:04 -08:00
Tim Hockin
dd4e456875
codegen:proto: Use revised API to gengo parser
2024-02-29 22:07:03 -08:00
Tim Hockin
4b55936ab0
Remove defunct trim-path-prefix
2024-02-29 22:07:02 -08:00
Tim Hockin
2348e94908
Conversion: Better logging
2024-02-29 22:07:01 -08:00
Tim Hockin
6dbc754ed6
Retool typecheck to be simpler
...
Instead of walking paths ourselves, just let Go's packages library do
it. This is a slight CLI change - it wants "./foo" rather than "foo".
This also flagged a few things which seem to be legit failures.
2024-02-29 22:07:00 -08:00
Tim Hockin
4d37426a3a
Update Makefile comments
2024-02-29 22:06:59 -08:00
Tim Hockin
965341390f
Remove KUBE_GO_PACKAGE
...
Almost nobody should need it, and if you do, it should be an immediate
smell.
2024-02-29 22:06:58 -08:00
Tim Hockin
5a96a56c80
Fix make test-integration for workspaces
2024-02-29 22:06:57 -08:00
Tim Hockin
4b20f81c19
Fix verify-conformance-yaml for workspaces
2024-02-29 22:06:57 -08:00
Tim Hockin
d61f299614
Call verify_go_version at the END of setup_env
...
Prior to this it would download Go, setup the environment, then (maybe)
download Go again.
I renamed verify_go_version to be internal and fixed all callers.
2024-02-29 22:06:56 -08:00
Tim Hockin
e84adf611f
Remove references to "GO111MODULE"
2024-02-29 22:06:55 -08:00
Tim Hockin
2a1147a434
Call setup_env from verify-vendor
2024-02-29 22:06:54 -08:00
Tim Hockin
d2a4a1958f
Tidy update-vendor-licenses for workspaces
2024-02-29 22:06:53 -08:00
