Commit Graph

63214 Commits

Author SHA1 Message Date
Ashley Gau
ebd54ea5e3 test ensureInternalLoadBalancer and ensureInternalLoadBalancerDeleted 2018-03-13 11:13:41 -07:00
Ashley Gau
f625b4a2d9 add hooks to add, remove, insert instances from instancegroups 2018-03-13 11:13:41 -07:00
Ashley Gau
ad1f206329 isolate logic to be shared with internal lb tests into separate file 2018-03-13 11:13:41 -07:00
Yongkun Anfernee Gui
5bad68ac58 Use pod UID as cache key instead of namespace/name
UID uniquely identifies pods across lifecycles, while namespace/name
could be 2 different pods across lifecycles. This could result in
tricky scheduler bugs.

Fixes #60966
2018-03-13 10:25:37 -07:00
Kubernetes Submit Queue
b651ed5ea7
Merge pull request #60998 from jpbetz/etcd-3.1.12
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Bump to etcd 3.1.12 to pick up critical fix

etcd [3.1.12](https://github.com/coreos/etcd/releases/tag/v3.1.12) (as well as 3.2.17 and 3.3.2) was released yesterday to fix a bug critical to kubernetes:

Fix [mvcc "unsynced" watcher restore operation](https://github.com/coreos/etcd/pull/9297).
- "unsynced" watcher is watcher that needs to be in sync with events that have happened.
- That is, "unsynced" watcher is the slow watcher that was requested on old revision.
- "unsynced" watcher restore operation was not correctly populating its underlying watcher group.
- Which possibly causes [missing events from "unsynced" watchers](https://github.com/coreos/etcd/issues/9086).

This will be backported to 1.9 as well.

Release note:
```release-note
Upgrade the default etcd server version to 3.1.12 to pick up critical etcd "mvcc "unsynced" watcher restore operation" fix.
```

cc @gyuho @wojtek-t @shyamjvs @timothysc @jdumars
2018-03-13 09:11:10 -07:00
Kubernetes Submit Queue
b11ff01168
Merge pull request #60981 from bmoyles0117/use-grpc-for-performance
Automatic merge from submit-queue (batch tested with PRs 61004, 60981). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use grpc to improve the CPU utilization of the logging agent.

Fixes #60762

**What this PR does / why we need it**:
Using gRPC improves the CPU utilization of the logging agent be reducing 
serialization overhead and reusing TCP connections.

**Release note**:
```release-note
NONE
```
2018-03-13 09:00:47 -07:00
Shyam JVS
b43b621690
Increase apiserver mem-threshold in density test 2018-03-13 16:47:14 +01:00
Slava Semushin
cee37f2f72 Fix strategy name in the error messages. 2018-03-13 16:21:43 +01:00
Slava Semushin
4621948ed8 kubectl get psp: modify header to show PRIV instead of DATA for column with privileged flag. 2018-03-13 16:08:33 +01:00
Kubernetes Submit Queue
25c8871bd0
Merge pull request #61004 from CaoShuFeng/audit_webhook_initialBackoff
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix option --audit-webhook-initial-backoff

Before this change, --audit-webhook-initial-backoff has no effect

@crassirostris @sttts 



**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-13 08:07:14 -07:00
Karol Wychowaniec
c61093480c Add Troubleshooting sections to Heapster and Metrics Server addons documentation 2018-03-13 15:10:13 +01:00
Jan Safranek
c44e135442 Fix subpath e2e tests on multizone cluster.
Use dynamically provisioned PV to run GCE PD tests. This will make sure
that the pod is scheduled to the right zone and GCE PD can be attached
to a node.
2018-03-13 14:26:37 +01:00
Jordan Liggitt
806f6772c6
Add atomic writer subpath e2e tests 2018-03-13 08:53:50 -04:00
lcfang
9be76ec461 remove the outdated TODO 2018-03-13 20:31:01 +08:00
xuzhonghu
70d5af6e7b stop using AlwaysAdmit admission 2018-03-13 20:02:56 +08:00
Nikhita Raghunath
b1d29e0d98 remove hack/test-cmd.sh: make is the main build tool
The script suggests to use `make test-cmd` anyway and
we don't use this script anywhere.
2018-03-13 14:55:00 +05:30
hzxuzhonghu
f12647e16d pkg/api/unversioned related cleanup 2018-03-13 17:20:16 +08:00
tanshanshan
5e57ae73a8 fix little 2018-03-13 16:39:48 +08:00
lcfang
93aa73e492 remove check d >= 0 since go 1.8 is no longer supported on master branch 2018-03-13 15:22:30 +08:00
hzxuzhonghu
79ee69c27e remove unused pkg unversioned 2018-03-13 15:06:38 +08:00
hzxuzhonghu
f66c9b388f fix bug in apiserver.k8s.io install 2018-03-13 14:47:05 +08:00
Jordan Liggitt
3fafdb7001
Detect backsteps correctly in base path detection
Avoid false positives with atomic writer ..<timestamp> directories
2018-03-13 02:23:06 -04:00
hzxuzhonghu
80872881ed remove dead code in kubelet 2018-03-13 11:57:02 +08:00
Kubernetes Submit Queue
a7d6340ad2
Merge pull request #61068 from ixdy/git-export-subst-tag-fix
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Exclude commas when pulling the tag out of the git export-subst format string

**What this PR does / why we need it**: the version tag is not guaranteed to be the last item in the ref names substituted into the format string, so we need to be sure not to match on the trailing comma.

For example, v1.9.3 was exported with `HEAD -> release-1.9, tag: v1.9.3, origin/release-1.9`, where we only want to match `v1.9.3`, not `v1.9.3,`.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #61029, though we need to backport this to all active branches.

**Release note**:

```release-note
NONE
```

/assign @david-mcmahon 
/priority important-soon
2018-03-12 17:34:11 -07:00
Kubernetes Submit Queue
6571be1311
Merge pull request #60962 from technicianted/flex_race_fix
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Added missing error check that could cause kubelet to crash

**What this PR does / why we need it**:
Adds missing error check. An error can happen due to a race condition when watched files change, or become inaccessible. This can happen if a file was added to the driver directory then quickly removed, in which case the callback will be called with non-nil `err` and nil `info`, which is not checked, causing kubelet to crash.

**Which issue(s) this PR fixes**:
Fixes #60861

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-12 16:17:02 -07:00
Kubernetes Submit Queue
a1c693418c
Merge pull request #60994 from joejulian/add_remote_flag_option
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add missing container-runtime "remote" option

**What this PR does / why we need it**:
Added the "remote" option to the auto-generated documentation for the
`--container-runtime` flag.

The kubelet flag `--container-runtime` lists the possible values as part of the auto-generated documentation but is missing the "remote" possibility.

**Which issue(s) this PR fixes** :
Fixes #60992

**Release note**:

```release-note
NONE
```
2018-03-12 15:24:38 -07:00
Jeff Grafton
7713453356 Exclude commas when pulling the tag out of the git export-subst format string 2018-03-12 15:20:22 -07:00
Anago GCB
ddbd573029 Update CHANGELOG-1.10.md for v1.10.0-beta.3. 2018-03-12 22:05:00 +00:00
Mehdy Bohlool
1e0b552f2f
Merge pull request #61061 from david-mcmahon/changelog-1.7-update
Add missing v1.7.14 release note entries.
2018-03-12 13:40:40 -07:00
Mehdy Bohlool
956afc5fee
Merge pull request #61059 from david-mcmahon/changelog-1.9-update
Add missing v1.9.4 release note entries.
2018-03-12 13:40:11 -07:00
Kubernetes Submit Queue
f01dde7691
Merge pull request #61053 from andrewsykim/kubelet-fix-flag-not-normalized
Automatic merge from submit-queue (batch tested with PRs 60772, 61011, 61053). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubelet initial flag parse should normalize flags instead of exiting

**What this PR does / why we need it**:
Sets normalize func for kubelet cleanFlagSet, otherwise kubelet will exit if non-normalized flag is used. For example, this happened on a kubelet running v1.10.0-beta.2:
```
F0312 17:59:03.138986   25317 server.go:144] unknown flag: --cluster_dns
```

This is where the kubelet exits: https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L142-L145. This would be a breaking change for anyone upgrading Kubernetes and using `_` in their flag names. 

```release-note
kubelet initial flag parse should normalize flags instead of exiting. 
```
2018-03-12 13:37:45 -07:00
Kubernetes Submit Queue
557de1e3e0
Merge pull request #61011 from mlmhl/csi_readonly
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Set readOnly for CSI mounter

**What this PR does / why we need it**:

Currently the `csiMountMgr .readOnly` field is never set, we should set it to `Spec.ReadOnly`.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #61008 

**Special notes for your reviewer**:

Currently, most of the volume plugins use a `getVolumeSourceFromSpec` method to fetch `VolumeSource` and `ReadOnly` from `volume.Spec`. If the volume is an inline volume, `ReadOnly` is fetched from `Spec.Volume.<SpecificVolumeSource>.ReadOnly`, and if the volume is a `PersistentVolume`, `ReadOnly` is set to `Spec.Readonly`, which comes from `PersistentVolumeClaimVolumeSource.ReadOnly`.

However, as CSI volume plugin is only supported in `PersistentVolume`, so we can just set `ReadOnly` to `Spec.ReadOnly`.

**Release note**:

```release-note
NONE
```

/sig storage
2018-03-12 13:34:11 -07:00
Joe Julian
8f4438b869 Add missing container-runtime "remote" option
Add the "remote" option to the auto-generated documentation for the
`--container-runtime` flag.

Fixes #60992
2018-03-12 13:33:37 -07:00
David McMahon
da281decd7 Add missing v1.7.14 release note entries. 2018-03-12 13:30:17 -07:00
David McMahon
5fb5202b05 Add missing v1.9.4 release note entries. 2018-03-12 13:19:08 -07:00
Kubernetes Submit Queue
17195553cc
Merge pull request #60772 from feiskyer/const-cleanup
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Code cleanup: group consts togather

**What this PR does / why we need it**:

This is a code cleanup, which groups all consts togather.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-12 12:42:34 -07:00
Bryan Moyles
a844523c20 Find most recent modified date for fluentd buffers recursively.
Due to updates in Fluent v0.14, the buffers directory modified date is no
longer updated when files inside the directory are changed. Therefore we
must find the most recent modified date recursively to fix liveness probe.
2018-03-12 15:28:55 -04:00
Kubernetes Submit Queue
3d1331f297
Merge pull request #61044 from liggitt/subpath-master
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

subpath fixes

fixes #60813 for master / 1.10

```release-note
Fixes CVE-2017-1002101 - See https://issue.k8s.io/60813 for details
```
2018-03-12 11:51:59 -07:00
Anago GCB
e88a0cebfb Update CHANGELOG-1.7.md for v1.7.14. 2018-03-12 11:35:18 -07:00
Tim Allclair
9afc4242d3 Grant sig leads feature approval powers 2018-03-12 11:34:33 -07:00
Anago GCB
61ec392b54 Update CHANGELOG-1.9.md for v1.9.4. 2018-03-12 11:32:59 -07:00
Anago GCB
5026c65d1a Update CHANGELOG-1.8.md for v1.8.9. 2018-03-12 11:28:32 -07:00
andrewsykim
cd1717ea09 kubelet initial flag parse should normalize flags 2018-03-12 14:06:17 -04:00
Kubernetes Submit Queue
31b4719066
Merge pull request #60859 from verult/remount-kube-env
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Setting REMOUNT_VOLUME_PLUGIN_DIR for COS images in kube-env

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60725

**Special notes for your reviewer**: Not sure if it's the best place to set `REMOUNT_VOLUME_PLUGIN_DIR`.

/sig storage
/sig cluster-lifecycle
2018-03-12 10:54:31 -07:00
jennybuckley
3b2472a305 Add e2e test for watch 2018-03-12 10:48:43 -07:00
Kubernetes Submit Queue
ba535d57f6
Merge pull request #60774 from feiskyer/augmented-nsg
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update documentation for azure-shared-securityrule

**What this PR does / why we need it**:

Azure augmented rules for NSGs has been GA https://azure.microsoft.com/en-us/updates/agumented-rules-ga-nsg/. This PR updates documentation for "service.beta.kubernetes.io/azure-shared-securityrule" to reflect this.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-12 08:39:10 -07:00
juanvallejo
d1cb6e36f2
distinguish which labels belong to resource 2018-03-12 11:10:27 -04:00
Kubernetes Submit Queue
75e1bf8393
Merge pull request #61022 from WanLinghao/show-all-description-fix
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix show-all option description

**What this PR does / why we need it**:
The default value of kubectl show-all option has been changed from false to true, but its description didn't change accordingly. This patch fix it. 
 
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-12 07:57:36 -07:00
Kubernetes Submit Queue
fd3cbc9bbf
Merge pull request #60995 from caesarxuchao/webhook-serializer
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Let webhook controller uses a local scheme that understand admissionReview

An alternative to #60965.
Fix #60963.
Fix kubernetes/sample-apiserver#21.

Created a scheme that only understands admission/v1beta1 and use it to
encode/decode admissionReviews.

cc @sttts
2018-03-12 07:02:27 -07:00
Kubernetes Submit Queue
a3f40dd8df
Merge pull request #60856 from jiayingz/race-fix
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fixes the races around devicemanager Allocate() and endpoint deletion.

There is a race in predicateAdmitHandler Admit() that getNodeAnyWayFunc()
could get Node with non-zero deviceplugin resource allocatable for a
non-existing endpoint. That race can happen when a device plugin fails,
but is more likely when kubelet restarts as with the current registration
model, there is a time gap between kubelet restart and device plugin
re-registration. During this time window, even though devicemanager could
have removed the resource initially during GetCapacity() call, Kubelet
may overwrite the device plugin resource capacity/allocatable with the
old value when node update from the API server comes in later. This
could cause a pod to be started without proper device runtime config set.

To solve this problem, introduce endpointStopGracePeriod. When a device
plugin fails, don't immediately remove the endpoint but set stopTime in
its endpoint. During kubelet restart, create endpoints with stopTime set
for any checkpointed registered resource. The endpoint is considered to be
in stopGracePeriod if its stoptime is set. This allows us to track what
resources should be handled by devicemanager during the time gap.
When an endpoint's stopGracePeriod expires, we remove the endpoint and
its resource. This allows the resource to be exported through other channels
(e.g., by directly updating node status through API server) if there is such
use case. Currently endpointStopGracePeriod is set as 5 minutes.

Given that an endpoint is no longer immediately removed upon disconnection,
mark all its devices unhealthy so that we can signal the resource allocatable
change to the scheduler to avoid scheduling more pods to the node.
When a device plugin endpoint is in stopGracePeriod, pods requesting the
corresponding resource will fail admission handler.

Tested:
Ran GPUDevicePlugin e2e_node test 100 times and all passed now.



**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes https://github.com/kubernetes/kubernetes/issues/60176

**Special notes for your reviewer**:

**Release note**:

```release-note
Fixes the races around devicemanager Allocate() and endpoint deletion.
```
2018-03-12 02:50:13 -07:00