Commit Graph

127343 Commits

Author SHA1 Message Date
Patrick Ohly
ac3d43a8a6 scheduler_perf: work around incorrect gotestsum failure reports
Because Go does not a "pass" action for
benchmarks (https://github.com/golang/go/issues/66825#issuecomment-2343229005),
gotestsum reports a successful benchmark run as failed
(https://github.com/gotestyourself/gotestsum/issues/413#issuecomment-2343206787).

We can work around that in each benchmark and sub-benchmark by emitting the
output line that `go test` expects on stdout from the test binary for success.
2024-11-18 12:35:05 +01:00
Patrick Ohly
369a18a3a1 scheduler_perf: simplify flags, fix output
The "disabled by label filter" message for benchmarks printed the pointer to
the filter string, not the filter string itself. This mistake gets avoided and
the code becomes simpler when not using pointers.
2024-11-18 12:32:59 +01:00
Kubernetes Prow Robot
cf480a3a1a
Merge pull request #128800 from soltysh/flake_128742
Add timeout for port-forward test
2024-11-15 18:02:53 +00:00
Maciej Szulik
9e87e99587
Add timeout for port-forward test
After removing a pod in port-forward test we wait for an error from POST
request. Since the POST doesn't have a timeout it hangs indefinitely, so
instead we're hitting a DefaultPodDeletionTimeout. To make sure the POST
fails this adds a timeout to ensure we'll always get that expected
error, rather than nil.

Signed-off-by: Maciej Szulik <soltysh@gmail.com>
2024-11-15 17:48:24 +01:00
Abhishek Kr Srivastav
179fa16f46 Remove user privilege checks from preflight tests 2024-11-15 19:52:27 +05:30
Kubernetes Prow Robot
23e76432a9
Merge pull request #128720 from mengjiao-liu/update-metrics-1-32
Update metrics docs for v1.32 release(Note this must be committed after the code freeze)
2024-11-15 04:30:51 +00:00
googs1025
c725e18e07 feature(scheduler): more fine-grained QHints for interpodaffinity plugin 2024-11-14 20:00:38 +08:00
carlory
cd6f4153e0 Fix a bug in framework.IgnoreNotFound where it will panic when a function type's final input parameter is a "..." parameter. 2024-11-14 16:44:04 +08:00
Kubernetes Prow Robot
475ee33f69
Merge pull request #128765 from sanposhiho/split-tests
fix: split TestCoreResourceEnqueue to deal with the timeout issue
2024-11-14 00:12:46 +00:00
Kubernetes Prow Robot
deecaf73eb
Merge pull request #128763 from srivastav-abhishek/fix-err-string
Fixed failing UT TestWriteKubeletConfigFiles by removing privilege check and adding proper error handling
2024-11-13 18:54:47 +00:00
Kensei Nakada
429abe33f1 fix: split TestCoreResourceEnqueue to deal with the timeout issue 2024-11-13 11:53:42 -07:00
Abhishek Kr Srivastav
56e3c787a5 Fixed failing test by removing privilege check and some refactor
Addressed review comments
2024-11-13 23:13:33 +05:30
Kubernetes Prow Robot
5ee686b6cf
Merge pull request #128559 from lauralorenz/crashloopbackoff-refactorimagepullbackoff-e2enodecriproxytest
E2E Node tests for image pull backoff and crashloopbackoff behavior
2024-11-13 17:34:47 +00:00
Maciej Skoczeń
de8e8c5404 Add integration tests for event handling cases in scheduler_perf 2024-11-13 13:17:48 +00:00
Kubernetes Prow Robot
f59dd4bce3
Merge pull request #128777 from SataQiu/fix-upgrade-dryrun-20241113
kubeadm: fix a bug where upgrade dryrun can not select the network interface correctly
2024-11-13 08:14:46 +00:00
SataQiu
d81e8beaea kubeadm: fix a bug where upgrade dryrun can not select the network interface correctly 2024-11-13 11:54:30 +08:00
Kubernetes Prow Robot
0926587bf0
Merge pull request #128771 from tallclair/min-quota
[FG:InPlacePodVerticalScaling] Equate CPU limits below the minimum effective limit (10m)
2024-11-13 03:48:53 +00:00
Kubernetes Prow Robot
af7581e8ec
Merge pull request #128761 from ah8ad3/revert-126533
Revert PR #126533 and add a test case for broken case
2024-11-13 03:48:46 +00:00
Kubernetes Prow Robot
420c6982ef
Merge pull request #128764 from pohly/dra-kubelet-grpc-api-package-name
DRA kubelet: use unique protobuf package name
2024-11-13 02:00:46 +00:00
Laura Lorenz
9ab0d81d76 Now that sleep is shorter, only expect to reach 3 within 30s
Focused too much on the container restart one in commit that fixed that

Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-13 01:39:58 +00:00
Tim Allclair
18600f43e0 Min cpu limit resize e2e test 2024-11-12 17:23:36 -08:00
Tim Allclair
8342d39956 Equate CPU limits below the minimum effective limit (10m) 2024-11-12 17:23:17 -08:00
Laura Lorenz
59f9858086 Move function specific to container restart test inline
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 23:59:30 +00:00
Laura Lorenz
529d5ba9d3 Don't overly indirect image name
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 23:34:57 +00:00
Laura Lorenz
8e7b2af712 Use a better util
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 23:30:03 +00:00
Laura Lorenz
285d433dea Clearer image pull test and utils
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 23:30:00 +00:00
Laura Lorenz
e03d0f60ef Orient tests to run faster, but tolerate infra slowdowns up to 5 minutes
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 21:48:28 +00:00
Laura Lorenz
d293c5088f Fix spelling
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 21:12:20 +00:00
Kubernetes Prow Robot
252e9cbb23
Merge pull request #128754 from vivzbansal/sidecar-3
Add AllowSidecarResizePolicy to relax resize policy validation check of sidecar containers
2024-11-12 20:28:48 +00:00
Laura Lorenz
1da8ca816e Extract restart number properly
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 20:00:11 +00:00
Laura Lorenz
2732d57e33 Missed refactor of container name here
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 19:50:11 +00:00
Laura Lorenz
e6059d7386 Fix typecheck and verify
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 19:48:38 +00:00
Kubernetes Prow Robot
79e5584257
Merge pull request #128682 from tallclair/ippr-beta
[FG:InPlacePodVerticalScaling] Graduate to Beta
2024-11-12 19:00:46 +00:00
Patrick Ohly
6c27e8dc8f DRA kubelet: use unique protobuf package name
As mentioned in https://protobuf.dev/programming-guides/style, package names
"should be unique". For generated API pb files, Kubernetes uses
"k8s.io.api.<api group>.<version>". The same approach is now used for the
kubelet DRA v1beta1 API. This can be changed without a breaking change because
the API is still unreleased.

This avoids a conflict between the DevicePlugin and the DRA API when both get
used by kubelet:

    2024/11/10 12:51:40 proto: duplicate proto type registered: v1beta1.Device

The exact impact of that conflict is unknown but it seems better to
pro-actively avoid the problem.
2024-11-12 18:06:50 +01:00
Kubernetes Prow Robot
8115baca00
Merge pull request #128666 from macsko/fix_scale_down_in_eventhandlingpodupdate_scheduler_perf_test_case
Fix pod scale down failure in EventHandlingPodUpdate scheduler_perf test
2024-11-12 16:28:47 +00:00
Dan Winship
49080bf02a Document the existence of nftables as a kube-proxy mode. 2024-11-12 09:51:52 -05:00
Omer Aplatony
80ed375e37 Fixed time
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-11-12 14:36:22 +02:00
Omer Aplatony
8b90c9e885 lint
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-11-12 13:45:26 +02:00
Omer Aplatony
991651353d lint
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-11-12 13:12:17 +02:00
ah8ad3
7580e6ac00 Revert PR #126533 and add a test case for the case where there is yaml
structed texts in the description.
We should find a way to both relign line breaks and not break these kind
of texts.

Signed-off-by: ah8ad3 <ah8ad3@gmail.com>
2024-11-12 14:23:03 +03:30
Omer Aplatony
fe46e47bd1 chore: update deprecated polling methods in apiextensions-apiserver
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-11-12 12:01:40 +02:00
Laura Lorenz
f032068ef7 Focus on restart numbers instead of timing
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 07:12:24 +00:00
vivzbansal
95591abd02 Add AllowSidecarResizePolicy to relax resize policy validation check of sidecar containers 2024-11-12 05:08:51 +00:00
Laura Lorenz
bad037b505 Formatting
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 04:48:10 +00:00
Laura Lorenz
15bae1eadf Add container restart test too
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 04:30:46 +00:00
Laura Lorenz
fc4ac5efeb Move image pull backoff test to be with other image pull tests
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 01:27:44 +00:00
Laura Lorenz
2479d91f2a Fix test to count pull tries
Signed-off-by: Laura Lorenz <lauralorenz@google.com>
2024-11-12 01:27:34 +00:00
Kubernetes Prow Robot
6b031e50b2
Merge pull request #128713 from tallclair/ippr-debug-events
[FG:InPlacePodVerticalScaling] Emit events for Deferred and Infeasible statuses
2024-11-11 23:22:45 +00:00
Kubernetes Prow Robot
f5d1fdf772
Merge pull request #128718 from tallclair/no-cpu-limit
[FG:InPlacePodVerticalScaling] Enable resizing containers without limits
2024-11-11 22:08:46 +00:00
Stephen Kitt
3d069b2a8a
Add myself to client-go reviewers
Given the ongoing work on generifying client-go, it might make sense
for me to be a reviewer (at least to keep better track of changes
being made before they go in).

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2024-11-11 15:03:14 -07:00