Clayton Coleman
ed48dcd2d7
kubelet: Ensure pods that have not started track a pendingUpdate
...
A pod that cannot be started yet (due to static pod fullname
exclusion when UIDs are reused) must be accounted for in the
pod worker since it is considered to have been admitted and will
eventually start.
Due to a bug we accidentally cleared pendingUpdate for pods that
cannot start yet which means we can't report the right metric to
users in kubelet_working_pods and in theory we might fail to start
the pod in the future (although we currently have not observed
that in tests that should catch such an error). Describe, implement,
and test the invariant that when startPodSync returns in every path
that either activeUpdate OR pendingUpdate is set on the status, but
never both, and is only nil when the pod can never start.
This bug was detected by a "programmer error" assertion we added
on metrics that were not being reported, suggesting that we should
be more aggressive on using log assertions and automating detection
in tests.
2023-03-29 15:29:59 -04:00
scott
db92cc1388
ftr(etcd): add benchmarks
2023-03-29 21:52:38 +08:00
Wojciech Tyczyński
05f4e497f1
Deflake TestGetListNonRecursive
2023-03-29 13:46:49 +02:00
Rita Zhang
906f0607ef
Clean up kms test
...
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
2023-03-28 22:36:41 -07:00
Aldo Culquicondor
f7765eb0d4
Add damemi to emeritus SIG scheduling approvers
2023-03-28 14:24:34 -04:00
Aldo Culquicondor
bbbd366cf3
Move damemi to sig-scheduling reviewers
2023-03-28 14:08:31 -04:00
HirazawaUi
397cc73dc9
delete unused functions in pkg/controller directory
2023-03-28 22:41:20 +08:00
Cecile Robert-Michon
47f8d42a6b
Add CecileRobertMichon to sig-cluster-lifecycle-leads
2023-03-27 21:46:10 +00:00
Anish Ramasekar
449f847630
[KMSv2] update ci script and add readme
...
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
2023-03-27 20:43:37 +00:00
Kubernetes Prow Robot
c3e7eca7fd
Merge pull request #116945 from soltysh/skip_vendor
...
Skip vendor directory when removing generated files
2023-03-27 11:00:29 -07:00
Maciej Szulik
27ad623b3d
Skip vendor directory when removing generated files
2023-03-27 19:07:43 +02:00
Ryan Phillips
86e1f4b9d1
e2e node: bump all nodes ready timeout
2023-03-27 11:22:18 -05:00
Kubernetes Prow Robot
3a46f26115
Merge pull request #116948 from MadhavJivrajani/fix-verify-vendor
...
.*: update vendor dir and cleanup
2023-03-27 08:56:28 -07:00
Antoni Zawodny
beb329f4bf
Do not look at VPC-related resources outside the cluster's network
2023-03-27 17:44:25 +02:00
Mike Spreitzer
8d92cfb131
Added conversions to/from NamespacedName
...
Also renamed file to something more on-point.
2023-03-27 11:22:09 -04:00
HirazawaUi
df0a253820
generate ReportingInstance and ReportingController in Event
2023-03-27 22:23:45 +08:00
Madhav Jivrajani
63b5ca69f1
.*: update vendor dir and cleanup
...
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2023-03-27 19:18:05 +05:30
Hao Ruan
f638e2849f
replaced spew.Sprintf with a util pretty print function
2023-03-27 09:24:22 +08:00
Kubernetes Prow Robot
8f15859afc
Merge pull request #116919 from dims/publishing-bot-rules-for-new-release-1.27-branch
...
publishing-bot rules for the new release-1.27 branch
2023-03-24 18:59:53 -07:00
Kubernetes Prow Robot
f393e7da7f
Merge pull request #116877 from enj/enj/i/validate_encrypt_resp_early
...
kmsv2: validate encrypt response at DEK generation time
2023-03-24 15:18:03 -07:00
Davanum Srinivas
1ad7cacba5
publishing-bot rules for the new release-1.27 branch
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-03-24 18:08:53 -04:00
Jordan Liggitt
f6fa250e30
Add API approvers
2023-03-24 16:15:55 -04:00
Kubernetes Prow Robot
0c62b122c0
Merge pull request #116857 from vinaykul/restart-free-pod-vertical-scaling-fixes
...
Call function that validates resize policy for in-place pod resize feature
2023-03-24 10:42:21 -07:00
Matthew Huxtable
03be789851
Fix sample-controller docs after moving to context-based cancellation
...
Since the stop channels were replaced in e346475
, the commentary is
incorrect and confusing.
2023-03-24 15:39:20 +00:00
Kubernetes Prow Robot
0f373abb6a
Merge pull request #116906 from pacoxu/fix-deprecated-metrics
...
Fix deprecated metrics
2023-03-24 05:10:32 -07:00
Paco Xu
b83600de01
fix nil pointer dereference panic for deprecated metrics
2023-03-24 18:50:43 +08:00
mantuliu
99ad88a261
Remove unnecessary int type conversion
...
Signed-off-by: mantuliu <240951888@qq.com>
2023-03-24 15:43:25 +08:00
Kubernetes Release Robot
f33498a825
CHANGELOG: Update directory for v1.27.0-rc.0 release
2023-03-23 19:51:32 +00:00
Anish Ramasekar
f2fe1fff65
[KMSv2] add tests for generate transformer
...
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
2023-03-23 16:40:16 +00:00
Monis Khan
479fcf0b13
kmsv2: validate encrypt response at DEK generation time
...
Prior to this change, we wait until the DEK is used to perform an
encryption before validating the response. This means that the
plugin could report healthy but all TransformToStorage calls would
fail. Now we correctly cause the plugin to become unhealthy and do
not attempt to use the newly generated DEK.
Signed-off-by: Monis Khan <mok@microsoft.com>
2023-03-23 16:22:56 +00:00
Kubernetes Prow Robot
d73b3a696a
Merge pull request #116866 from LiorLieberman/remove-grpc-standard-protocol
...
Remove references to kubernetes.io/grpc appProtocol
2023-03-23 09:04:33 -07:00
kidddddddddddddddddddddd
8d644fbc72
return skip in volumerestrictions
2023-03-23 23:14:24 +08:00
Moshe Levi
1031977b7d
kubelet PodResources API: follow-up review comments
...
Signed-off-by: Moshe Levi <moshele@nvidia.com>
2023-03-23 09:36:52 +02:00
Monis Khan
5469c198e5
kmsv2: validate encrypt response at DEK generation time
...
Prior to this change, we wait until the DEK is used to perform an
encryption before validating the response. This means that the
plugin could report healthy but all TransformToStorage calls would
fail. Now we correctly cause the plugin to become unhealthy and do
not attempt to use the newly generated DEK.
Signed-off-by: Monis Khan <mok@microsoft.com>
2023-03-22 21:48:53 -04:00
Mike Spreitzer
ec9515a828
Add structured alternatives to strings in client-go/tools/cache
2023-03-22 16:21:17 -04:00
Lior Lieberman
6843c52060
remove kubernetes.io/grpc standard protocol
2023-03-22 18:33:49 +00:00
Alexander Zielenski
2b01f63b11
move check for noop managed field timestamp updates
...
this check needs to go after any mutations. After the mutating admission chain, rest.BeforeUpdate (which is responsible for reverting updates to immutable timestamp fields, among other things.) is called in the store.Update function. Without moving this check, it will be possible for an object to be written to etcd with only a change to its managed fields timestamp.
2023-03-22 11:29:33 -07:00
Kubernetes Prow Robot
d2be69ac11
Merge pull request #116860 from liggitt/test-binary
...
Drop development dependencies from test targets
2023-03-22 11:20:36 -07:00
vinay kulkarni
0e9dd5c51d
Call function that validates in-place vpa resize policy
2023-03-22 16:19:19 +00:00
Jordan Liggitt
a2bba333cc
Drop development dependencies from test targets
2023-03-22 10:38:42 -04:00
Akihiro Suda
af95a76bb2
cri-api: fix comment lines about PROPAGATION_PRIVATE
...
The current CRI implementations treat `PROPAGATION_PRIVATE` as "rprivate", not "private":
- https://github.com/containerd/containerd/blob/v1.6.16/pkg/cri/opts/spec_linux.go#L181
- https://github.com/cri-o/cri-o/blob/v1.26.1/server/container_create_linux.go#L982
However, this is not always true for cri-dockerd, which treats `PROPAGATION_PRIVATE` as
noop and lets dockerd use its default propagation mode:
- https://github.com/Mirantis/cri-dockerd/blob/v0.3.1/libdocker/helpers.go#L235-L236
(The "private is default" comment in L236 is inaccurate)
dockerd's default propagation mode is "rprivate" for most cases, but dockerd changes
its default propagation mode to "rslave" when the mount source contains the daemon root
(`/var/lib/docker`):
- https://github.com/moby/moby/blob/v20.10.23/volume/mounts/linux_parser.go#L145
- https://github.com/moby/moby/blob/v20.10.23/daemon/volumes.go#L137-L143
- https://github.com/moby/moby/blob/v20.10.23/daemon/volumes_linux.go#L11-L36
This behavior was introduced in Docker 18.03 (moby/moby PR 36055).
Related:
- kubernetes/website PR 39385
- Mirantis/cri-dockerd PR 159
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-03-22 21:37:30 +09:00
major1201
daa1d287e4
fix GetPodVolumeClaims in comments
2023-03-22 17:23:05 +08:00
Kubernetes Prow Robot
3cf9f66e90
Merge pull request #116743 from thockin/docs-clarify-publish-not-ready-endpoints
...
Clarify EPSlice docs wrt the Ready conditions
2023-03-21 23:14:35 -07:00
Tim Allclair
7537cec567
Fix MatchConditions webhook validation testing ( #116784 )
...
* Fix MatchConditions webhook validation testing
* #squash verify error type
* #squash fix duplicate registration
* #squash uncomment validation test
2023-03-21 21:38:35 -07:00
Paco Xu
c14068c202
deflake: Add retry with timeout to wait for final conditions
2023-03-22 11:24:09 +08:00
Maxim Patlasov
fbf33e32e6
Fix memory leak in kubelet volume_manager populator processedPods
...
`findAndRemoveDeletedPods()` processes only pods from volume_manager cache: `dswp.desiredStateOfWorld.GetVolumesToMount()`. `podWorker` calls volume_manager `WaitForUnmount()` asynchronously. If it happens after populator cleaned up resources, an entry is added to `processedPods` and will never be seen. Let's cleanup such entries if they don't have a pod and marked for deletion.
2023-03-21 20:16:02 -07:00
Mengjiao Liu
27f84b755e
Migrated the volumezone scheduler plugin to use contextual logging
2023-03-22 11:09:31 +08:00
Qirui
ddc13e983b
Chore: add selector labels tweak function
2023-03-22 11:02:25 +08:00
Qirui
4cab11f26f
Chore: add persistent volume claim retention policy tweak function
2023-03-22 11:02:01 +08:00
Qirui
ba9dfe686f
Chore: add persistent volume claim template tweak function
2023-03-22 11:01:37 +08:00