Commit Graph

109660 Commits

Author SHA1 Message Date
Wojciech Tyczyński
f3996039ef Clean shutdown of cloud controllers in integration tests 2022-07-26 14:34:04 +02:00
Stanislav Laznicka
682ee2908a
Make scheduling e2e tests run PSa-restricted pods
The "pause" pods that are being run in the scheduling tests are
sometimes launched in system namespaces. Therefore even if a test
is considered to be running on a "baseline" Pod Security admission
level, its "baseline" pods would fail to run if the global PSa
enforcement policy is set to "restricted" - the system namespaces
have no PSa labels.

The "pause" pods run by this test can actually easily run with
"restricted" security context, and so this patch turns them
into just that.
2022-07-26 14:32:51 +02:00
Kubernetes Prow Robot
28fc2991a5
Merge pull request #111317 from wojtek-t/fix_leaking_goroutines_12
Clean shutdown of cloud controllers in integration tests
2022-07-26 04:45:09 -07:00
Kubernetes Prow Robot
00ace95226
Merge pull request #111046 from wongearl/omit-comparison
omit comparison to bool constant
2022-07-26 03:37:09 -07:00
Sebastiaan van Stijn
82a765c52f
downgrade github.com/matttproud/golang_protobuf_extensions to v1.0.1
This dependency was updated in 6b864dc4e1, but using
a version that's 1 commit ahead of the latest (v1.0.1) release. As a consequence,
any project that uses k8s.io/component-base as a dependency, but that prefers to
use tagged releases, will be required to add a `replace` rule in their `go.mod`.

Looking at the difference between the currently used version and the last release,
the only difference is the addition of a `go.mod`:
https://github.com/matttproud/golang_protobuf_extensions/compare/v1.0.1...c182affec369

While it can help to have a `go.mod` to resolve the minimum version of (indirect)
dependencies, in this case, the (minimum) versions of dependencies defined in this
module's `go.mod` are quite a bit behind the version defined in k8s' own go.mod,
so would already be up-to-date.

Based on the above, it looks like the `go.mod` (currently) doesn't provide much
value, and it would be safe to roll back 1 commit to use the tagged/released
version of this module.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-07-26 11:43:20 +02:00
SataQiu
6cab9800a7 kubeadm: prefer to use pkg/errors package and cleanup fmt.Errorf 2022-07-26 16:56:16 +08:00
Kubernetes Prow Robot
a72032f9b3
Merge pull request #111395 from wojtek-t/cleanup_run_apiserver
Remove RunAnAPIServer from integration tests
2022-07-26 01:55:53 -07:00
ialidzhikov
cb4a3d2ca4 Update the feature state in the help text of the --seccomp-default flag 2022-07-26 10:53:24 +03:00
SataQiu
107dee6f04 scheduler: ValidateNodeResourcesFitArgs will check ScoringStrategy.Type field and print supported ScoringStrategyType list on error 2022-07-26 13:23:03 +08:00
Lee Verberne
1dc040082c Refactor container validation
Refactor common validation into methods that validate a single container
and call these methods when iterating the three types of container
lists. Move initContainer-specific validation from validateContainers to
validateInitContainers.

This resolves issues where init and ephemeral containers would return
duplicate or incorrectly formatted errors for problems detected by
validateContainers.
2022-07-26 07:19:56 +02:00
Lee Verberne
dbbbf8502e Improve container validation test coverage
Adds missing tests based on KUBE_COVER and checks that errors returned
by validation are of the type and for the field expected. Fixes tests
that had multiple errors so later failures aren't masked if there's
a regression in only one of the errors.
2022-07-26 07:05:02 +02:00
Lee Verberne
4a7fd2a614 Use structs for container validation test
This introduces no changes to unit tests other than to switch from
map-based to struct-based tables in TestValidateContainers and
TestValidateInitContainers in order to make diffs for later commits
easier to read.
2022-07-26 06:47:43 +02:00
Kubernetes Prow Robot
12b22ede41
Merge pull request #111406 from bennerv/update-max-azuredisk-count
Update Azure max data disk count map
2022-07-25 19:43:53 -07:00
muyangren2
7435085fe1 Fix test order staging/src/k8s.io/component-base/logs/json/json_test.go 2022-07-26 10:26:16 +08:00
muyangren2
42765566e1 Fix test order pkg/kubelet/winstats/winstats_test.go 2022-07-26 10:05:59 +08:00
Kubernetes Prow Robot
4a05a32c30
Merge pull request #111412 from bobbypage/bump-cos97
test: cluster: Bump to COS 97 image
2022-07-25 18:34:05 -07:00
Kubernetes Prow Robot
8f30a3bb29
Merge pull request #111156 from DangerOnTheRanger/cel-traversal-optimization
Remove estimateMinSizeJSON calls for CEL
2022-07-25 18:33:53 -07:00
Lee Verberne
d238e67ba6 Remove EphemeralContainers feature-gate checks 2022-07-26 02:55:30 +02:00
Lee Verberne
bc3c5ae269 Remove EphemeralContainers beta disclaimer 2022-07-26 02:53:45 +02:00
Lee Verberne
ee596a88d9 Mark EphemeralContainers feature gate as GA 2022-07-26 02:53:44 +02:00
Kubernetes Prow Robot
f88f76f444
Merge pull request #111404 from verb/111025-ec-node-conformance
Add Ephemeral Containers to node conformance tests
2022-07-25 15:30:34 -07:00
Kermit Alexander
ae2319b6db Replace estimateMinSizeJSON with DeclType.MinSerializedSize. 2022-07-25 21:48:57 +00:00
David Porter
ead45ba74d test: cluster: Bump to COS 97 image
COS-85 is very old OS image and is EoL in September 2022. Update to the
latest stable LTS version of COS.

Signed-off-by: David Porter <david@porter.me>
2022-07-25 14:48:27 -07:00
Divyen Patel
1d4ba69ae4 updated warning message for CSI Migration and vSphere upgrade requirement 2022-07-25 13:46:57 -07:00
Kubernetes Prow Robot
d48c067771
Merge pull request #110164 from MikeSpreitzer/supply-denominators
Supply denominators
2022-07-25 13:32:34 -07:00
Kubernetes Prow Robot
17efdc6efb
Merge pull request #111377 from chendave/v1beta3
No need to assert an error when the error is not nil
2022-07-25 12:22:45 -07:00
Kubernetes Prow Robot
99e34dc572
Merge pull request #111348 from wojtek-t/pf_cleanup_observations
Eliminate MaintainObservations function in P&F
2022-07-25 12:22:34 -07:00
bennerv
3cc3ac56d8 Update Azure max data disk count map 2022-07-25 14:51:50 -04:00
Wojciech Tyczyński
5b042f0bf4 Remove RunAnAPIServer from integration tests 2022-07-25 17:52:31 +02:00
Mike Spreitzer
fdd921cad0 Fix APF metric denominator problems
Co-authored-by: JUN YANG <yang.jun22@zte.com.cn>
2022-07-25 11:52:17 -04:00
Kubernetes Prow Robot
7b9a20b587
Merge pull request #111378 from kerthcet/revert/remove-plugin-logic
Revert "Cleanup: remove validation of removedPlugins"
2022-07-25 08:48:34 -07:00
Kubernetes Prow Robot
88251c050a
Merge pull request #111365 from akankshakumari393/fix_typos
[Minor] Fix typos in the variable name in scheduling_queue_test.go
2022-07-25 07:40:46 -07:00
Kubernetes Prow Robot
37311a2eed
Merge pull request #103663 from bells17/fix-priority-plugin-comment
Fix Priority plugin comment
2022-07-25 07:40:35 -07:00
Kubernetes Prow Robot
7156c96e5d
Merge pull request #111194 from ravisantoshgudimetla/promote-maxSurge-ga
Promote DS max surge to GA
2022-07-25 06:20:46 -07:00
Kubernetes Prow Robot
a6afdf45dd
Merge pull request #110359 from MadhavJivrajani/remove-api-call-under-lock
controller/nodelifecycle: Refactor to not make API calls under lock
2022-07-25 06:20:34 -07:00
Kubernetes Prow Robot
bc974c8ab9
Merge pull request #111383 from p0lyn0mial/kubeadm-etcd-progress-notificaiton
kubeadm: pass etcd progress notification flag to etcd
2022-07-25 04:32:35 -07:00
Lukasz Szaszkiewicz
81dec8bc6a kubeadm: pass etcd progress notification flag to etcd
The experimental-watch-progress-notify-interval flag specifies an interval
at which etcd sends data to the kube-api server.

It is used by the WatchBookmark feature which is GA since 1.17.
It will be used by a new WatchList feature which is Alpha since 1.25

In addition to that the feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes
2022-07-25 12:28:51 +02:00
Kubernetes Prow Robot
96e22f28db
Merge pull request #110032 from bells17/fix-changelog-typo
Fix CHANGELOG-1.22.md: Cluster Storage Interface -> Container Storage…
2022-07-25 03:26:34 -07:00
Madhav Jivrajani
3c0bc26d90 controller/nodelifecycle: Refactor to not make API calls under lock
The evictorLock only protects zonePodEvictor and zoneNoExecuteTainter.
processTaintBaseEviction showed indications of increased lock contention
among goroutines (see issue 110341 for more details).

The refactor done is to ensure that all codepaths in that function that
hold the evictorLock AND make API calls under the lock, are now making
API calls outside the lock and the lock is held only for accessing either
zonePodEvictor or zoneNoExecuteTainter or both.

Two other places where the refactor was done is the doEvictionPass and
doNoExecuteTaintingPass functions which make multiple API calls under
the evictorLock.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2022-07-25 15:16:26 +05:30
Wojciech Tyczyński
1f4f98e40d Clean shutdown of cloud controllers in integration tests 2022-07-25 11:28:50 +02:00
Kubernetes Prow Robot
c633f7124d
Merge pull request #111374 from seans3/force-prune-fix
disallow --force and --prune in client-side apply
2022-07-25 01:50:34 -07:00
Sean Sullivan
d84abe868d gofmt update 2022-07-24 23:46:44 -07:00
Wojciech Tyczyński
badf436ac4 Eliminate MaintainObservations function in P&F 2022-07-25 08:02:08 +02:00
Dave Chen
79cac48b30 No need to assert an error when the error is not nil
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-07-25 12:26:35 +08:00
kerthcet
aa04472f54 Refactor: rename removedPlugin to invalidPlugin
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-25 11:19:44 +08:00
kerthcet
a2229691a9 Revert "Cleanup: remove validation of removedPlugins"
This reverts commit 0971577c3e.
2022-07-25 10:56:05 +08:00
Sean Sullivan
e02a26d74a disallow --force and --prune in client-side apply 2022-07-24 16:26:57 -07:00
Lee Verberne
4ad08e13b2 Add Ephemeral Containers to node conformance tests 2022-07-24 17:31:16 +02:00
Kubernetes Prow Robot
5f6b60bb13
Merge pull request #111369 from Nordix/remove-fallocate
Replace fallocate with dd in e2e tests
2022-07-23 11:02:57 -07:00
Lars Ekman
e93f1161ea Replace fallocate with dd in e2e tests 2022-07-23 17:22:49 +02:00