The goal of this move is related to issue 89930, to break the dependence
of scheduling plugins on internal helpers. This function can easily move to
component-helpers where it will be used by other components as well.
The protocol buffer [styleguide] says field names should use
underscore_separated_names.
Code generation tools rely on this convention to split words and
generate language-specific accessors/properties in the local style
conventions (ie: it's more than just a style convention). For
example, the previous `deviceIDs` name caused Rust proto tools to
generate field names like `device_i_ds` which is just weird.
[styleguide]: https://developers.google.com/protocol-buffers/docs/style#message-and-field-names
Rename `deviceIDs` field to `device_ids`, and use a gogo-specific
option to keep the existing `DeviceIDs` golang name (otherwise it
would generate `DeviceIds`).
Note this doesn't affect protocol buffer / gRPC wire encoding, which
uses numeric values.
The original intent of the Recognizer interface was to take a stream
and peek into the contents. Over time all of the callers migrated
to instead performing their own peek and then passing the buffer
as a bytes.NewBuffer to the interface as a stream, which was then
implemented as a read on the other side. This resulted in an
excess buffer allocation in general decoder usage.
Update the interface to take a []bytes slice and change all callers
to stop creating buffered readers, then update the JSON serializer
to check the buffer directly for "json-ness".
Since this invalid Semantic Version messages redirecting to stdout
will be captured by line 790 at hack/lib/golang.sh:
`goldflags="${GOLDFLAGS=-s -w -buildid=} $(kube::version::ldflags)"`
This happens when only no valid tag exists in repo
If Containerd is used on Windows, then we can also mount individual
files into containers (e.g.: /etc/hosts), which was not possible with Docker.
Checks if the container runtime is containerd, and if it is, then also
mount /etc/hosts file (to C:\Windows\System32\drivers\etc\hosts).
This patch uses shell internals instead of sed and awk where suitable
and also uses lower/upper classes for tr instead of a-z and A-Z.
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
A few details about the image builder postsubmit jobs changed, so the README had to
be updated as well.
Added a few extra bits of information regarding the Windows images.
