Commit Graph

93232 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
0a7050f531
Merge pull request #93043 from aramase/vmss-dualstack-ipconfig
fix: determine the correct ip config based on ip family
2020-07-17 15:02:50 -07:00
Dan Winship
e46572ef4b Improve EndpointController's handling of headless services under dual-stack
EndpointController was accidentally requiring all headless services to
be IPv4-only in clusters with IPv6DualStack enabled.

This still leaves "legacy" (ie, IPFamily-less) headless services as
always IPv4-only because the controller doesn't currently have easy
access to the information that would allow it to fix that.
(EndpointSliceController had the same problem already, and still
does.) This can be fixed, if needed, by manually setting IPFamily,
and the proposed API for 1.20 will handle this situation better.
2020-07-17 15:26:21 -04:00
Dan Winship
9023d19c57 Improve EndpointController dual-stack testing
Rewrite some of the test helpers to better support single-stack IPv4
vs single-stack IPv6 vs dual-stack IPv4 primary vs dual-stack IPv6
primary, and update TestPodToEndpointAddressForService to test some
more cases.
2020-07-17 15:26:21 -04:00
Dan Winship
9fb6e2ef55 Fix Endpoint/EndpointSlice pod change detection
The endpoint controllers responded to Pod changes by trying to figure
out if the generated endpoint resource would change, rather than just
checking if the Pod had changed, but since the set of Pod fields that
need to be checked depend on the Service and Node as well, the code
ended up only checking for a subset of the changes it should have.

In particular, EndpointSliceController ended up only looking at IPv4
Pod IPs when processing Pod update events, so when a Pod went from
having no IP to having only an IPv6 IP, EndpointSliceController would
think it hadn't changed.
2020-07-17 15:22:59 -04:00
Stephen Augustus
3bbcba9b84 Update Golang to v1.14.6
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-17 14:47:21 -04:00
Stephen Augustus
bddd52046d Update repo-infra to v0.0.8 (to support go1.14.6 and go1.13.14)
Includes:
- bazelbuild/bazel-toolchains@3.4.0
- bazelbuild/rules_go@v0.22.8

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-17 14:30:02 -04:00
Kubernetes Prow Robot
f9ad7db9a6
Merge pull request #92349 from jingyih/update_etcd_server_3p4p9
Update default etcd server to 3.4.9
2020-07-17 07:53:01 -07:00
Jordan Liggitt
3b323b2ef0 Limit critical pods to kube-system by default 2020-07-17 09:52:19 -04:00
Kubernetes Prow Robot
a3e3b355fa
Merge pull request #92619 from ii/heyste-get-apigroup-list-test
Write checkAPIGroupPreferredVersion Test - +16 Endpoint coverage
2020-07-17 02:51:01 -07:00
Ed Bartosh
016eb06d8b go.mod: update etcd to fix e2e tests
Updated etcd to v3.4.10 to include this fix:
 - change protobuf field type from int to int64

This should fix increased flakyness in a lot of node e2e tests.
2020-07-17 12:15:43 +03:00
Kubernetes Prow Robot
23b66eaabd
Merge pull request #93038 from ii/fix-ingress-status
Write readNetworkingV1NamespacedIngressStatus test - +1 endpoint coverage
2020-07-16 23:05:00 -07:00
Kubernetes Prow Robot
58893f3443
Merge pull request #93052 from andyzhangx/fix-initial-delay
fix: initial delay in mounting azure disk & file
2020-07-16 17:27:00 -07:00
Stephen Heywood
ca550a280a Relocate preferred version e2e test to discovery.go 2020-07-16 21:13:55 +00:00
Stephen Heywood
6e3919fae7 Check that empty sets are passed through the test 2020-07-16 20:50:14 +00:00
Stephen Heywood
a0410c8789 Claify the intention of the e2e test 2020-07-16 20:50:14 +00:00
Stephen Heywood
f886164491 Validate that PreferredVersion contains a valid option 2020-07-16 20:50:14 +00:00
Stephen Heywood
e81b6dce15 Update BUILD 2020-07-16 20:50:14 +00:00
Stephen Heywood
bc873c192c Fix naming for apigroup list 2020-07-16 20:50:14 +00:00
Stephen Heywood
dcf72dfd32 Update bazel BUILD 2020-07-16 20:50:14 +00:00
Stephen Heywood
a9cb510c7f Fix test name and log formatting 2020-07-16 20:50:14 +00:00
Stephen Heywood
6a6ccbc45c Add e2e test for get*APIGroupList endpoints 2020-07-16 20:50:14 +00:00
Han Kang
f3c02d7221 auto triage sig-instrumentation tagged PRs
Change-Id: Ibae7373fb197485aeb222f1455515178cc3b4d13
2020-07-16 13:48:25 -07:00
Han Kang
9129dbc98b automatically assign triage labels to api-machinery tagged PRs
Change-Id: Ifcc8a85d190d6370423af27f6e6c4c90b8472981
2020-07-16 13:13:59 -07:00
Dan Williams
e24f9ed1cd test/e2e/ingress: add missing return to fix panics on !GCE
A missing 'return' causes the AfterEach() to try to clean up
GCE ingress objects when they haven't been created, because
the test was skipped in BeforeEach().

2020-07-15T17:21:10.3690332Z [BeforeEach] GCE [Slow] [Feature:kubemci]
2020-07-15T17:21:10.3690715Z   /home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:592
2020-07-15T17:21:10.3690970Z Jul 15 17:21:10.368: INFO: Only supported for providers [gce gke] (not )
2020-07-15T17:21:10.3694003Z [AfterEach] GCE [Slow] [Feature:kubemci]
2020-07-15T17:21:10.3696927Z   /home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:614
2020-07-15T17:21:10.3697845Z [1mSTEP[0m: No ingress created, no cleanup necessary
2020-07-15T17:21:10.3698213Z [1mSTEP[0m: Cleaning up cloud resources
2020-07-15T17:21:15.3709789Z E0715 17:21:15.370134   78875 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
2020-07-15T17:21:15.3710883Z goroutine 63 [running]:
2020-07-15T17:21:15.3711892Z [AfterEach] [sig-network] Loadbalancing: L7
2020-07-15T17:21:15.3712802Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime.logPanic(0x40215e0, 0x7b71700)
2020-07-15T17:21:15.3713654Z   /home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:179
2020-07-15T17:21:15.3714871Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:74 +0xa3
2020-07-15T17:21:15.3715130Z Jul 15 17:21:15.370: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready
2020-07-15T17:21:15.3715703Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
2020-07-15T17:21:15.3716215Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:48 +0x82
2020-07-15T17:21:15.3716610Z panic(0x40215e0, 0x7b71700)
2020-07-15T17:21:15.3717184Z 	/opt/hostedtoolcache/go/1.13.4/x64/src/runtime/panic.go:679 +0x1b2
2020-07-15T17:21:15.3717803Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).deleteForwardingRule(0x0, 0x0, 0xc0034cce04, 0x2)
2020-07-15T17:21:15.3718372Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:158 +0x20b
2020-07-15T17:21:15.3718859Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).Cleanup(0x0, 0x0, 0x1, 0xc0034ccd68)
2020-07-15T17:21:15.3719369Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:724 +0x38
2020-07-15T17:21:15.3719947Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).CleanupIngressControllerWithTimeout.func1(0xc0034ccd78, 0xc00315e8a0, 0xc0002acf88)
2020-07-15T17:21:15.3720474Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:88 +0x33
2020-07-15T17:21:15.3720968Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtection(0xc0034ccfa0, 0xc0034cce00, 0x0, 0x0)
2020-07-15T17:21:15.3721508Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:211 +0x6f
2020-07-15T17:21:15.3722020Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.WaitFor(0xc003393120, 0xc0034ccfa0, 0xc00341ae40, 0x0, 0x0)
2020-07-15T17:21:15.3722542Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:528 +0x159
2020-07-15T17:21:15.3723233Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.pollInternal(0xc003393120, 0xc0034ccfa0, 0x0, 0x0)
2020-07-15T17:21:15.3723771Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:414 +0x9f
2020-07-15T17:21:15.3724305Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.Poll(0x12a05f200, 0xd18c2e2800, 0xc0034ccfa0, 0xc0000a4940, 0xc0034ccfb0)
2020-07-15T17:21:15.3724872Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:408 +0x4d
2020-07-15T17:21:15.3725377Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).CleanupIngressControllerWithTimeout(0x0, 0xd18c2e2800, 0x0, 0x0)
2020-07-15T17:21:15.3726709Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:87 +0x69
2020-07-15T17:21:15.3743725Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).CleanupIngressController(...)
2020-07-15T17:21:15.3744385Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:81
2020-07-15T17:21:15.3744822Z k8s.io/kubernetes/test/e2e/network.glob..func10.4.2()
2020-07-15T17:21:15.3745340Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:626 +0x12a
2020-07-15T17:21:15.3745868Z k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc000e17740, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
2020-07-15T17:21:15.3746756Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113 +0xb8

Fixes: 0f81362fa0
2020-07-16 14:56:08 -05:00
Kubernetes Prow Robot
fbbc3ed359
Merge pull request #92490 from neolit123/1.19-increase-kubeadm-cmd-test-timeout
kubeadm: increase the timeout for cmd integration tests
2020-07-16 12:18:14 -07:00
Han Kang
45af3ae0cb refactor wrapped functions into variables
Change-Id: I1eec309c537920ba520c7a90f9a1f557ec53cf2c
2020-07-16 09:54:23 -07:00
Han Kang
6b994af680 port over apiserver metric handler to use the instrumentation library
Change-Id: Ifabb726120c1c4f90ff3e4d71fdbba468fe74e8a
2020-07-16 09:26:47 -07:00
Han Kang
ef00707ccf add metric reset to wrapped prometheus registry
Change-Id: I035863210e19184eb2e8861772e58d2d1de8ec5e
2020-07-16 09:26:34 -07:00
Kubernetes Prow Robot
96c057ab48
Merge pull request #92001 from huffmanca/include-csidriver-fsgroup
Include CSIDriver capability to indicate fsGroup support
2020-07-16 09:11:42 -07:00
Gaurav Singh
744ea3a930 [staging/azure] azure_utils: fix range iterator issue in convertMaptoMapPointer
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>

Use local variable for the copy of iterator variable
2020-07-16 11:10:45 -04:00
Kubernetes Prow Robot
75b5552415
Merge pull request #93034 from matthias50/matthias50/ensure-vmss-fix
Skip ensuring VMSS in pool for nodes which should be excluded from lb
2020-07-16 06:31:56 -07:00
Kubernetes Prow Robot
6a8129f7f6
Merge pull request #92957 from r4f4/override-volume-images
Make nested /volume/ repo images overridable
2020-07-16 06:31:41 -07:00
Kubernetes Prow Robot
03509f3087
Merge pull request #92974 from Ghazgkull/patch-1
Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter
2020-07-16 02:03:41 -07:00
Kubernetes Prow Robot
bd9be7b544
Merge pull request #93113 from hasheddan/integration-skip
Skip failing scheduler integration tests until they can be run successfully
2020-07-16 00:07:41 -07:00
Kubernetes Prow Robot
1f4da99f69
Merge pull request #92813 from ii/heyste-create-delete-core-v1-collection-namespaced-event-test
Promote deleteCoreV1CollectionNamespacedEvent test - +1 endpoint coverage
2020-07-15 19:16:34 -07:00
elweb9858
593e32ae53 Updating hcsshim version to introduce updated version check for dsr mode in winkernel kube-proxy 2020-07-15 16:53:22 -07:00
Kubernetes Prow Robot
8c300565c2
Merge pull request #90941 from ii/ii-promote-configmap-lifecycle
Promote: ConfigMap Lifecycle test - +2 conformance endpoint coverage
2020-07-15 15:28:48 -07:00
Mike Spreitzer
57ecea2229 Introduce more metrics on concurrency
Introduce min, average, and standard deviation for the number of
executing mutating and readOnly requests.

Introduce min, max, average, and standard deviation for the number
waiting and number waiting per priority level.

Later:

Revised to use a series of windows

Use three individuals instead of array of powers

Later:

Add coarse queue count metrics, removed windowed avg and stddev

Add metrics for number of queued mutating and readOnly requests,
to complement metrics for number executing.

Later:

Removed windowed average and standard deviation because consumers can
derive such from integrals of consumer's chosen window.

Also replaced "requestKind" Prometheus label with "request_kind".

Later:

Revised to focus on sampling

Make the clock intrinsic to a TimedObserver

... so that the clock can be read while holding the observer's lock;
otherwise, forward progress is not guaranteed (and violations were
observed in testing).

Bug fixes and histogram buckets revision

SetX1 to 1 when queue length limit is zero, beause dividing by zero is nasty.

Remove obsolete argument in gen_test.go.

Add a bucket boundary at 0 for sample-and-water-mark histograms, to
distinguish zeroes from non-zeros.

This includes adding Integrator test.

Simplified test code.

More pervasively used "ctlr" instead of "ctl" as abbreviation for
"controller".
2020-07-15 15:46:05 -04:00
Anago GCB
4b2cb072db CHANGELOG: Update directory for v1.17.9 release 2020-07-15 18:58:06 +00:00
Anago GCB
b7d4a8abf5 CHANGELOG: Update directory for v1.16.13 release 2020-07-15 18:54:29 +00:00
Anago GCB
85a066754b CHANGELOG: Update directory for v1.18.6 release 2020-07-15 18:46:25 +00:00
Kubernetes Prow Robot
afecf524dd
Merge pull request #93088 from justaugustus/go1145
Update Golang to v1.14.5
2020-07-15 10:22:37 -07:00
hasheddan
a70b78e49a
Skip failing scheduler integration tests until they can be run successfully
The IPAM and scheduler performance tests are currently causing
integration-master job to fail because of timeouts. They were not
previously running as part of integration-master, so we can disable them
without loss of test coverage. They should be re-enabled as part of fix
for #93112.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-15 10:28:35 -05:00
Kubernetes Prow Robot
30b0ebd6d4
Merge pull request #91761 from MikeSpreitzer/test-uneven-fairness
Add test for windup problem in APF
2020-07-15 06:04:37 -07:00
Davanum Srinivas
16fb6733a1
Adding dims as reviewer for test/
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-07-15 07:19:53 -04:00
Kubernetes Prow Robot
d9c3d15018
Merge pull request #92986 from gnufied/fix-in-use-errors
Handle volume-in-use error during volume expansion
2020-07-15 00:30:37 -07:00
Stephen Augustus
99c29de8fc Update repo-infra to 0.0.7 (to support go1.14.5 and go1.13.13)
Includes:
- bazelbuild/bazel-toolchains@3.3.2
- bazelbuild/rules_go@v0.22.7

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-15 00:14:32 -04:00
Stephen Augustus
c4b6678757 Update Golang to v1.14.5
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-15 00:10:05 -04:00
Kubernetes Prow Robot
633ab1ca61
Merge pull request #92880 from cici37/importCloudProvider
Import cloud provider from k8s.io/legacy-cloud-provider
2020-07-14 18:12:37 -07:00
Anish Ramasekar
b1f0e9884a determine the correct ip config based on ip family 2020-07-15 00:27:20 +00:00