github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 06:54:01 +00:00
Code Issues Projects Releases Wiki Activity
21,934 Commits 42 Branches 7,905 Tags 1.3 GiB
69439149ed
Commit Graph

21934 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jan Chaloupka
9590b23264 LowThresholdPercent can not be higher than HighThresholdPercent 
if LowThresholdPercent > HighThresholdPercent, amountToFree at image_manager.go:208 is negative and image GC will not free memory properly.

Justification:

1) LowThresholdPercent > HighThresholdPercent implies (LowThresholdPercent * capacity / 100) > (HighThresholdPercent * capacity / 100)
2) usage is at least (HighThresholdPercent * capacity / 100)
3) amountToFree = usage - (LowThresholdPercent * capacity / 100)

Combining 1), 2) and 3) implies amountToFree can be negative.

What happens if amountToFree is negative? in freeSpace method, "for _, image := range images " loops at least once
and if everything goes fine, "delete(im.imageRecords, image.id)" is executed.
When checking for condition "if spaceFreed >= bytesToFree", it is always true as bytesToFree is negative
and spaceFreed is positive. The loop is finished, so is image GC.

At the end, only the oldest image is deleted. In situations where there is a lot of dead containers,
each container corresponing to distinct image, number of unused images can get higher.
If two new images get pulled in every 5 minutes, image GC will not work properly and will not free enough space.
Secondly, it will take a lot of time to free all unused images (hours depending on a number of unused images).

This is an incorrect configuration. Image GC should report it and refuse to work.
 2015-12-02 14:28:51 +01:00
Sergiusz Urbaniak
91cbd5ff46 node: replace node lookup via node list watch with node store 
Fixes https://github.com/mesosphere/kubernetes-mesos/issues/656
 2015-12-02 14:12:56 +01:00
jhadvig
f7785bcdb4 Typo fix 2015-12-02 13:59:58 +01:00
Dr. Stefan Schimanski
271eeb008b Merge pull request #52 from mesosphere/sttts-task-lost-during-kubelet-pod-launch 
MESOS: scheduler: handle lost task status updates during kubelet pod launch
 2015-12-02 13:50:28 +01:00
k8s-merge-robot
e28404b23b Merge pull request #17946 from jhadvig/label_msg 
Auto commit by PR queue bot
 2015-12-02 04:46:26 -08:00
gmarek
459131fd92 Use KubeletPort reported in NodeStatus instead of cluster-wide master config, take 2. 2015-12-02 13:38:17 +01:00
k8s-merge-robot
c76ff237d9 Merge pull request #18069 from mesosphere/sttts-cherry-pick-tasks-killed-by-master 
Auto commit by PR queue bot
 2015-12-02 04:31:47 -08:00
k8s-merge-robot
b3846ea748 Merge pull request #17862 from feihujiang/ensureHeadlessServicePortEqualToTargetPort 
Auto commit by PR queue bot
 2015-12-02 03:35:36 -08:00
k8s-merge-robot
b69018eab2 Merge pull request #17844 from eosrei/kube-util-minion-node 
Auto commit by PR queue bot
 2015-12-02 03:06:27 -08:00
Dr. Stefan Schimanski
d2c86c847c Merge pull request #51 from mesosphere/sttts-tasks-killed-by-master 
MESOS: scheduler: handle terminal tasks killed by the master
 2015-12-02 12:02:50 +01:00
Wojciech Tyczynski
6eb76b34d1 Fix compile errors in benchmark 2015-12-02 11:36:26 +01:00
k8s-merge-robot
ac68536d44 Merge pull request #17832 from wojtek-t/list_options_in_list 
Auto commit by PR queue bot
 2015-12-02 02:34:17 -08:00
k8s-merge-robot
5e53e281e5 Merge pull request #17545 from yujuhong/no_auto_updates 
Auto commit by PR queue bot
 2015-12-02 02:03:08 -08:00
k8s-merge-robot
60925e67fe Merge pull request #17920 from abutcher/check-endpoints 
Auto commit by PR queue bot
 2015-12-02 01:35:00 -08:00
Marek Grabowski
11c878e17c Merge pull request #18057 from kubernetes/revert-15645-oneNS 
Revert "SkyDNS is the only NS for Pods with DNSPolicy=ClusterFirst"
 2015-12-02 09:20:10 +01:00
Alex Robinson
105afbb070 Typo fixes in docs 2015-12-01 22:33:49 -08:00
Fabio Yeon
7100d278e3 Revert "SkyDNS is the only NS for Pods with DNSPolicy=ClusterFirst" 2015-12-01 20:58:27 -08:00
resouer
1e065a151e Changed wrong volume mounted path 2015-12-02 03:37:26 +00:00
mqliang
70cce2847a remove TODO:parallize health check 2015-12-02 09:51:13 +08:00
Janet Kuo
36067cf4a4 Fix local cluster script 2015-12-01 17:11:21 -08:00
Brad Erickson
6ac427a501 Minion->Node rename: e2e.sh and resize_nodes.go GCE_FLAKY_TESTS 2015-12-01 16:00:47 -08:00
Brad Erickson
e67667f1b5 Minion->Node rename: comments and vars for e2e.go and e2e.sh 2015-12-01 16:00:47 -08:00
Brendan Burns
661faf4585 Fix api reference generation script on os x. 2015-12-01 15:54:42 -08:00
Mike Danese
e2c5c898fb move vagrant to masterless salt 2015-12-01 15:53:50 -08:00
Isaac Hollander McCreery
421d5e99f6 Add 1.1-master jobs to master 2015-12-01 15:18:39 -08:00
Isaac Hollander McCreery
81cec94ed8 Make job names consistent 2015-12-01 15:18:39 -08:00
Isaac Hollander McCreery
1edd23f4bb Add jobs for kubernetes-upgrade-gke-1.0-master, remove old 1.0 jobs & GCE jobs 2015-12-01 15:18:39 -08:00
k8s-merge-robot
11574ee990 Merge pull request #17925 from mikedanese/tmp-fix 
Auto commit by PR queue bot
 2015-12-01 14:43:37 -08:00
Sebastien LAWNICZAK
3eae5895f8 Passing DomainID/DomainName to AuthOptions 
To be able to use Domains with IdentityV3, domain-id/domain-name in provider config should be passed to gophercloud.AuthOptions
 2015-12-01 23:12:25 +01:00
Isaac Hollander McCreery
5ce2d70414 Clarify what is meant by 'support' 2015-12-01 14:07:23 -08:00
k8s-merge-robot
4602220ad0 Merge pull request #15645 from ArtfulCoder/oneNS 
Auto commit by PR queue bot
 2015-12-01 13:51:37 -08:00
deads2k
a7dd09ec47 update requestScope to fully qualify kind and resource 2015-12-01 16:50:24 -05:00
k8s-merge-robot
727412c5ce Merge pull request #15533 from ZJU-SEL/git-volume 
Auto commit by PR queue bot
 2015-12-01 13:14:23 -08:00
k8s-merge-robot
d524bd8f52 Merge pull request #17942 from gmarek/fix-test 
Auto commit by PR queue bot
 2015-12-01 12:42:57 -08:00
k8s-merge-robot
d282974e13 Merge pull request #18025 from mikedanese/fixmem 
Auto commit by PR queue bot
 2015-12-01 12:10:34 -08:00
k8s-merge-robot
7a8a3ef445 Merge pull request #17689 from mesosphere/dcos-guide-index 
Auto commit by PR queue bot
 2015-12-01 12:05:40 -08:00
Mike Danese
ac097bfe70 add semver parsing of gitversion to pkg/version 2015-12-01 12:03:37 -08:00
Jeff Grafton
be856daab6 Merge pull request #17751 from ixdy/jenkins-e2e-master 
Remove all non-release job definitions from hack/jenkins/e2e.sh
 2015-12-01 11:50:41 -08:00
Maciej Szulik
db0df10b9c Changing ─ (U+2500) to ASCII hyphen in describe command 2015-12-01 20:40:51 +01:00
Andrew Butcher
101a9927e4 Do not update kubernetes endpoints when endpoint address count is less than or equal to master count. 
checkEndpointSubsetFormat ensures that,
1. the current master's IP is in the list of addresses
2. the number of IPs in the list exactly matches the master count

This is problematic while masters are in the process of starting
because it causes frequent updates to the kubernetes endpoints until
all masters have started and added themselves to the list.

checkEndpointSubsetFormat should report success if the current
master's IP is found and the count of addresses is less than or equal
to the expected count.
 2015-12-01 14:31:22 -05:00
Mike Danese
0655e65b43 fall back to old behavior when deciding mem availablity during build 2015-12-01 10:25:14 -08:00
Mike Danese
73f71a7260 godeps: add github.com/blang/semver 2015-12-01 09:53:46 -08:00
Eric Tune
27e89c1f84 Revert the revert of kubernetes/kubernetes#15674 2015-12-01 09:16:06 -08:00
Karl Isenberg
a070bcf187 Add DCOS to getting started guide list 2015-12-01 09:09:44 -08:00
k8s-merge-robot
643cb7a1c7 Merge pull request #17891 from zhengguoyong/consistent_kubelet_package 
Auto commit by PR queue bot
 2015-12-01 08:37:01 -08:00
Harry Zhang
70a9c0bf56 Add directory in GitRepo and updated tests. 
Update validate and gitRepo

Update generated code
 2015-12-02 00:20:38 +08:00
k8s-merge-robot
77e9066ebb Merge pull request #17099 from feihujiang/moveDefaultingFuncsFromInternalToV1 
Auto commit by PR queue bot
 2015-12-01 07:13:26 -08:00
mqliang
9ff765978a add filedselector for Event 2015-12-01 23:02:48 +08:00
k8s-merge-robot
355ac2c58d Merge pull request #17581 from swagiaal/correct-management-predicates 
Auto commit by PR queue bot
 2015-12-01 06:42:15 -08:00
Wojciech Tyczynski
8343c8ce6c Pass ListOptions to List() methods. 2015-12-01 15:00:36 +01:00