Commit Graph

119562 Commits

Author SHA1 Message Date
Dan Winship
e3357d0c5f Clean up Endpoint / BaseEndpointInfo a bit
Remove NodeName, which was unused because we only care about IsLocal
which was tracked separately.

Remove Zone, which was unused because it's from the old topology
system?

Fix up some comments which still referred to Endpoints vs
EndpointSlice differences.

Also remove an unhelpful helper function in endpoints_test.go
2023-10-25 08:59:53 -04:00
Dan Winship
2879ec10d5 Rewrite ipvs/iptables tests that manually construct BaseEndpointInfo
The tests in pkg/proxy already test that EndpointSlice ->
BaseEndpointInfo conversion works correctly; all we need to test in
pkg/proxy/ipvs and pkg/proxy/iptables is that the correct set of
endpoints get picked out where we expect them to, which doesn't
require us to compare the complete BaseEndpointInfo objects.
2023-10-25 08:59:53 -04:00
Kensei Nakada
27bb66fd7b cleanup: rename failedPlugin to plugin in framework.Status 2023-10-25 12:03:56 +00:00
Kubernetes Prow Robot
8caa6fb2e0
Merge pull request #121368 from mimowo/backoff-limit-per-index-e2e-test
Backoff limit per index e2e test
2023-10-25 13:18:37 +02:00
Kubernetes Prow Robot
4294c35fc9
Merge pull request #121297 from calvinballing/spellcheck-markdown
Fix typos in markdown
2023-10-25 13:18:26 +02:00
Krzysztof Wilczyński
2a8982b27b
Remove problematic Dbus restart test
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
2023-10-25 19:53:50 +09:00
Patrick Ohly
39df946c06 golangci-lint: enable doc comment checking for cmd/kubeadm
Some code owners might want this for specific packages, like cmd/kubeadm.

This cannot be enabled for everything because:
- a lot of existing code doesn't pass (-> can't be in base config)
- a lot of packages don't need it (-> shouldn't even be a hint)
2023-10-25 12:30:28 +02:00
adrianc
3738111337
Add unit tests
adjust existing tests and add new test flows
to cover new DRA manager behaviour

Signed-off-by: adrianc <adrianc@nvidia.com>
2023-10-25 13:20:22 +03:00
adrianc
08b942028f
DRA: call plugins for claims even if exist in cache
Today, DRA manager does not call plugin NodePrepareResource
for claims that it previously successfully handled, that is,
if claims are present in cache (checkpoint) even if node
rebooted.

After node reboots, it is required to call DRA plugin
for resource claims so that plugins may prepare them
again in case the resources dont persist reboot.

To achieve that, once kubelet is started, we call DRA
plugins for claims once if a pod sandbox is required
to be created during PodSync.

Signed-off-by: adrianc <adrianc@nvidia.com>
2023-10-25 13:20:16 +03:00
Michal Wozniak
69ca55f136 Do not preallocate node for Job e2e tests to fix flakes 2023-10-25 12:11:08 +02:00
Lubomir I. Ivanov
98bed52fdd kubeadm: make super-admin.conf changes in app/constants
- Add the new file name: super-admin.conf and a function
to return its default path GetSuperAdminKubeConfigPath()
- Add the ClusterAdminsGroupAndClusterRoleBinding object name.
2023-10-25 11:46:49 +03:00
Jan Safranek
e511edf11f Fix SELinux unit tests
Use device mountable volume, to make it impossible to share the same global
mount with different SELinux contexts.

And fix pod2Name to actually refer to pod2.
2023-10-25 10:43:29 +02:00
Jan Safranek
2f5903b4cf Move SELinux warning metric to be counted once per pod
volume_manager_selinux_volume_context_mismatch_warnings_total should be
counted only once per volume + pod. The previous location is evaluated
periodically, so bump the metric only when a new pod is added to volume.
2023-10-25 10:43:29 +02:00
Patrick Ohly
d20edf697a verify-golangci-lint.sh: support arbitrary GOBIN
The in-tree configs use a relative path to find logcheck.so. This is useful
because then the invocation of golangci-lint also works outside of the script.
But when running with a containerized build, GOBIN points somewhere else. For
that case, a temporary copy of the configuration has to be created with an
absolute path.
2023-10-25 09:25:53 +02:00
Kubernetes Prow Robot
8453eb0c24
Merge pull request #121069 from jsafrane/ocp-add-plugin-label
Add volume plugin label to SELinux metrics
2023-10-25 08:13:20 +02:00
Kubernetes Prow Robot
558a6797a2
Merge pull request #121497 from nilekhc/test-hot-reload-test-flake
[KMSv2] tests: fixes flake in TestEncryptionConfigHotReload
2023-10-25 06:57:13 +02:00
Kubernetes Prow Robot
0b884c0e3a
Merge pull request #121494 from aojea/fix/flake-unit-test
Fix/flake TestNewManagerImplStartProbeMode  unit test
2023-10-25 06:57:04 +02:00
Kubernetes Prow Robot
e279e02076
Merge pull request #121465 from kerthcet/cleanup/remove-get-indexer
Remove unnecessary GetIndexer
2023-10-25 06:56:55 +02:00
Kubernetes Prow Robot
b3edbf6027
Merge pull request #121488 from dims/use-the-latest-semver-version-for-the-badge
Use the latest semver version for the badge
2023-10-25 05:46:39 +02:00
Kubernetes Prow Robot
6e04b7d051
Merge pull request #121470 from SataQiu/clean-kubeadm-20231024
kubeadm: cleanup UnknownCRISocket
2023-10-25 05:46:30 +02:00
Kubernetes Prow Robot
dd61cd037d
Merge pull request #121430 from bzsuni/cleanup/fsnotify
Bump the fsnotify from version v1.6.0 to v1.7.0
2023-10-25 05:46:11 +02:00
Kubernetes Prow Robot
925a8dd3d3
Merge pull request #119947 from saschagrunert/keyring-unit
Add unit tests for subdomain match in keyring
2023-10-25 03:32:05 +02:00
Nilekh Chaudhari
a92c1269e2
test: fixes hot reload flake
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
2023-10-25 01:14:00 +00:00
Nilekh Chaudhari
71a1565d06
revert: reverts fixes for TestEncryptionConfigHotReload flake
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
2023-10-25 01:08:04 +00:00
Kubernetes Prow Robot
6817e6a7cc
Merge pull request #119912 from kannon92/pod-replacement-policy-integration-tests
Add a missing integration test for PodReplacementPolicy
2023-10-25 02:09:49 +02:00
Ben Luddy
83f5b5c240
Deep disablement for APF based on --enable-priority-and-fairness.
Avoids starting informers or the config-consuming controller when
--enable-priority-and-fairness=false. For kube-apiserver, the config-producing controller runs if
and only if flowcontrol API storage is enabled.
2023-10-24 17:53:51 -04:00
Kubernetes Prow Robot
8cdab8a5db
Merge pull request #121481 from dejanzele/job-pod-creation-total-metrics
feat: add job_pods_creation_total metric
2023-10-24 23:43:20 +02:00
Antonio Ojea
8e0be64b8f remove data race on the devicemanager client plugin
Change-Id: I45b85440a792e5ed2f75a344ec1f0332854d8d6d
2023-10-24 21:35:13 +00:00
kannon92
aeceec72bb add integration tests 2023-10-24 17:09:40 -04:00
Aldo Culquicondor
97e72d792c
Remove independent tests for metrics
Change-Id: Ibefebf95df47c68e6752e85c61fface9f06cbd38
2023-10-24 16:29:08 -04:00
Davanum Srinivas
84cd6dbb0a
use the latest semver version for the badge
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-10-24 15:30:17 -04:00
Kubernetes Prow Robot
03ba7efb85
Merge pull request #121455 from cici37/test_cost
CRD validation rule: Add stability tests for CEL cost estimation
2023-10-24 21:00:58 +02:00
Kubernetes Prow Robot
413b15a8d9
Merge pull request #120914 from kannon92/kubelet-disk-api-cri-update
Kubelet disk api cri update
2023-10-24 21:00:40 +02:00
Alexander Zielenski
b3525946d5 ratcheting: provide a shared correlated object
will be shared with CEL and used for metrics
2023-10-24 11:26:13 -07:00
Alexander Zielenski
dfeab6eca8 fetch a shared correlated object off the validation options if it exists
c
2023-10-24 11:23:28 -07:00
Alexander Zielenski
0a19b5ab6e fix usage 2023-10-24 11:23:28 -07:00
Alexander Zielenski
432e8937cf add variadic options to ValidateUpdate
stays API compatible while allowing us to pass in our CorrelatedObject

va
2023-10-24 11:20:09 -07:00
Dejan Pejchev
9e2821d585
revert changes to TestMetricsOnSuccesses for job pods creation total metric 2023-10-24 19:41:14 +02:00
Kubernetes Prow Robot
f652e61ca0
Merge pull request #121471 from mimowo/backoff-limit-per-index-api-beta
Indicate Job Backoff Limit Per Index reason consts are beta
2023-10-24 18:55:27 +02:00
Kubernetes Prow Robot
722503e9e5
Merge pull request #121390 from wojtek-t/disable_paging
Remove ability to disable pagination at store level
2023-10-24 18:55:16 +02:00
Dejan Pejchev
88c0a8be1b
feat: add job_pods_creation_total metric 2023-10-24 17:49:04 +02:00
Kubernetes Prow Robot
d2383ce467
Merge pull request #121457 from SteveProXNA/stevepro-topology-endpoint-logging
Add endpoint to skip topology aware log when missing zone hint
2023-10-24 17:10:45 +02:00
Kubernetes Prow Robot
87981480f3
Merge pull request #119186 from seans3/stream-translator-proxy
Stream Translator Proxy and FallbackExecutor for WebSockets
2023-10-24 17:10:34 +02:00
kerthcet
b1ce529b2a Remove unnecessary GetIndexer
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-10-24 23:03:34 +08:00
Shiming Zhang
1224e0e881 Add PodHostIPs test 2023-10-24 22:07:03 +08:00
Dejan Zele Pejchev
f8a4e343a1
Fix tracking of terminating Pods when nothing else changes (#121342)
* cleanup: refactor pod replacement policy integration test into staged assertion

* cleanup: remove typo in job_test.go

* refactor PodReplacementPolicy test and remove test for defaulting the policy

* fix issue with missing update in job controller for terminating status and refactor pod replacement policy integration test

* use t.Cleanup instead of defer in PodReplacementPolicy integration tests

* revert t.Cleanup to defer for reseting feature flag in PodReplacementPolicy integration tests
2023-10-24 15:04:46 +02:00
Kubernetes Prow Robot
9aa04752e7
Merge pull request #118463 from testwill/replace_loop
chore: slice replace loop
2023-10-24 15:04:39 +02:00
Kubernetes Prow Robot
cdd20eebb7
Merge pull request #118381 from SataQiu/fix-controller-20230601
controller: fix the help information format of sorting_deletion_age_ratio metric
2023-10-24 15:04:25 +02:00
Kubernetes Prow Robot
015297a577
Merge pull request #121327 from soltysh/fix_nextScheduleTimeDuration
Fix next schedule time duration
2023-10-24 12:18:35 +02:00
Mengjiao Liu
2cea51221a hack/logcheck.conf: enable contextual logging in kube-scheduler 2023-10-24 17:56:59 +08:00