Commit Graph

113862 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
b8b18ecd85
Merge pull request #114051 from chrishenzie/rwop-preemption
[scheduler] Support preemption of pods using ReadWriteOncePod PVCs
2023-02-13 11:45:30 -08:00
Lars Ekman
50cfd6ca80 Add uablrek in pkg/util/ipvs/OWNERS 2023-02-13 19:11:21 +01:00
Jan Safranek
673ea6af78 Revert "add unit test for check unmounted behavior of Unmount"
This reverts commit bf77290bbf.

Because the unit tests requires to run as root.
2023-02-13 18:50:29 +01:00
Lucas Severo Alves
6b34fafdaf
Add ctx logging involved in KS startup (#115588)
* ctx logging involved in startup

as per https://github.com/kubernetes/kubernetes/pull/111155#pullrequestreview-1283257121

* use klog.Background().Error in flag handling

* revert scheduler_perf changes

* refence issue in code comment

* enable ctx logcheck for cmd/kube-scheduler
2023-02-13 09:19:29 -08:00
Stephen Kitt
b62165f445
Drop cp from the etcd images
This was used by migrate-if-needed.sh, but that has been replaced by
the migrate Go program which doesn't need external cp.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2023-02-13 18:06:59 +01:00
Jan Safranek
e7bd00b0b8 Revert "check umount result"
This reverts commit 368fd9d01e.
2023-02-13 17:52:26 +01:00
ravisantoshgudimetla
d65262d1f9 Remove cgo dependency 2023-02-13 11:16:39 -05:00
Odin Ugedal
7bcc3e00fc client-go/cache: rewrite Replace to check queue first
This is useful to both reduce the code complexity, and to ensure clients
get the "newest" version of an object known when its deleted. This is
all best-effort, but for clients it makes more sense giving them the
newest object they observed rather than an old one.

This is especially useful when an object is recreated. eg.

Object A with key K is in the KnownObjects store;
- DELETE delta for A is queued with key K
- CREATE delta for B is queued with key K
- Replace without any object with key K in it.

In this situation its better to create a DELETE delta with
DeletedFinalStateUnknown with B (with this patch), than it is to give
the client an DeletedFinalStateUnknown with A (without this patch).

Signed-off-by: Odin Ugedal <ougedal@palantir.com>
Signed-off-by: Odin Ugedal <odin@uged.al>
2023-02-13 14:59:56 +00:00
Odin Ugedal
cd3e98b65c client-go/cache: merge ReplaceMakesDeletionsForObjectsInQueue tests
Signed-off-by: Odin Ugedal <ougedal@palantir.com>
Signed-off-by: Odin Ugedal <odin@uged.al>
2023-02-13 14:59:44 +00:00
Odin Ugedal
0bf0546d9f client-go/cache: fix missing delete event on replace without knownObjects
This fixes an issue where a relist could result in a DELETED delta
with an object wrapped in a DeletedFinalStateUnknown object; and then on
the next relist, it would wrap that object inside another
DeletedFinalStateUnknown, leaving the user with a "double" layer
of DeletedFinalStateUnknown's.

Signed-off-by: Odin Ugedal <ougedal@palantir.com>
Signed-off-by: Odin Ugedal <odin@uged.al>
2023-02-13 14:59:33 +00:00
Kubernetes Prow Robot
8d25cc3193
Merge pull request #115723 from aojea/revert_latency
Revert "use kube-proxy defaults values for CI"
2023-02-13 06:49:38 -08:00
Kubernetes Prow Robot
79886690d4
Merge pull request #114920 from astefanutti/pr-codegen-144
fix: applyconfiguration-gen fails for types with non-builtin map fields
2023-02-13 06:49:30 -08:00
Odin Ugedal
25d77218ac client-go/cache: fix missing delete event on replace
This fixes a race condition when a "short lived" object
is created and the create event is still present on the queue
when a relist replaces the state. Previously that would lead in the
object being leaked.

The way this could happen is roughly;

1. new Object is added O, agent gets CREATED event for it
2. watch is terminated, and the agent runs a new list, L
3. CREATE event for O is still on the queue to be processed.
4. informer replaces the old data in store with L, and O is not in L
  - Since O is not in the store, and not in the list L, no DELETED event
    is queued
5. CREATE event for O is still on the queue to be processed.
6. CREATE event for O is processed
7. O is <leaked>; its present in the cache but not in k8s.

With this patch, on step 4. above it would create a DELETED event
ensuring that the object will be removed.

Signed-off-by: Odin Ugedal <ougedal@palantir.com>
Signed-off-by: Odin Ugedal <odin@uged.al>
2023-02-13 14:41:08 +00:00
Stephen Kitt
f69c1c4746
client-go: add an Error() function on Request
Requests can accumulate errors with no obvious indication, e.g. if
their primary purpose is to construct a URL: URL() itself doesn't
return an error if r.err is non-nil.

Instead of changing URL() to return an error, which has quite a large
impact, add an Error() function and indicate on URL() that it should
be checked.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2023-02-13 15:12:43 +01:00
Kubernetes Prow Robot
bf79066749
Merge pull request #115714 from aramase/aramase/f/kubernetes#115595
[KMSv2] Add kind cluster and encryption config for e2e
2023-02-13 05:43:42 -08:00
Kubernetes Prow Robot
4933005b38
Merge pull request #115697 from aojea/lbds
don't run loadbalancer tests on large environments
2023-02-13 05:43:30 -08:00
Antonio Ojea
07fc074a67 Revert "use kube-proxy defaults values for CI"
This reverts commit bafeacd14d.
2023-02-13 11:41:34 +00:00
Kubernetes Prow Robot
8ee0d3b6e8
Merge pull request #115584 from pbeschetnov/master
[HPA e2e] Calculate more precise consumed CPU usage for N replicas
2023-02-13 03:27:29 -08:00
Arda Güçlü
f5b0d728c5 kubectl debug: Use restClientGetter instead cmd.Factory
As the move towards using `restClientGetter` interface instead
gigantic `cmd.Factory`, this PR does that change.
2023-02-13 13:17:36 +03:00
Arda Güçlü
d66b339868 kubectl debug: Initialize pod client and builder in complete
This PR initializes podclient and builder in complete function
instead run function.
2023-02-13 13:17:31 +03:00
Arda Güçlü
3ffdee7d2b kubectl debug: Standartize add flag function
This PR standartize add flag function interface to align with
other kubectl commands.
2023-02-13 12:36:18 +03:00
Anish Ramasekar
4e6d5dddfb
[KMSv2] Add kind cluster and encryption config for e2e
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
2023-02-13 06:42:54 +00:00
SataQiu
b9e5f5ad2f using const systemNodeRoleName instead of string system:node 2023-02-13 14:22:28 +08:00
Kubernetes Prow Robot
cfa295f569
Merge pull request #115594 from wking/included-failed-to-evict-pod-namespace
kubectl/pkg/drain: Include namespace in evictPods return error
2023-02-12 20:27:28 -08:00
Kubernetes Prow Robot
e818649c10
Merge pull request #115690 from tzneal/fix-buildx-check
fix docker buildx check
2023-02-12 14:27:30 -08:00
Yoon
a3405f35b4 Use predefined variable instead of duplicated string 2023-02-12 20:50:39 +09:00
Antonio Ojea
244d7449ce don't run loadbalancer tests on large environments
Change-Id: Id987e9469e563c0837c6437a44a65889cec2e202
2023-02-11 10:28:25 +00:00
Son Dinh
4f75949bcb Ipvs: Add a new FlagSourceHash to "mh" distribution method.
With the flag, ipvs uses both source IP and source port (instead of
only source IP) to distribute new connections evently to endpoints
that avoids sending all connections from the same client (i.e. same
source IP) to one single endpoint.

User can explicitly set sessionAffinity in service spec to keep all
connections from a source IP to end up on the same endpoint if needed.

Change-Id: I42f950c0840ac06a4ee68a7bbdeab0fc5505c71f
2023-02-11 20:51:02 +11:00
Kubernetes Prow Robot
4303743736
Merge pull request #115692 from liggitt/go1.20
Disable unified build and static init optimization for tests
2023-02-10 18:11:30 -08:00
Kubernetes Prow Robot
d0db9a959b
Merge pull request #115677 from aramase/kmsv2-middleware
[KMSv2] implement local KEK service
2023-02-10 16:21:29 -08:00
Kubernetes Prow Robot
0424a530a4
Merge pull request #115678 from pohly/e2e-full-reports
e2e: revise complete report creation
2023-02-10 15:07:29 -08:00
Jordan Liggitt
e20d77bb79
Disable unified build and static init optimization for tests 2023-02-10 17:57:56 -05:00
Monis Khan
ee2e1ff99a
implement service.Service interface and update localKEK generation
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Co-authored-by: Monis Khan <mok@microsoft.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
2023-02-10 22:12:34 +00:00
Kubernetes Prow Robot
1749bb2991
Merge pull request #115579 from ardaguclu/fix-wait-sh-timeout
flaky test wait.sh: Add deployment assertion before running wait
2023-02-10 13:59:29 -08:00
Todd Neal
0c99212e78 fix docker buildx check
In testing, docker reports an exit code of zero if --help
is passed, regardless of the subcommand
2023-02-10 14:26:15 -06:00
Kubernetes Prow Robot
16bd7e6a79
Merge pull request #115674 from mengjiao-liu/update-podsecurity-registry
PodSecurity test: update registry from k8s.gcr.io to registry.k8s.io
2023-02-10 10:45:30 -08:00
Kubernetes Prow Robot
161b00c639
Merge pull request #115617 from cyclinder/cyclinder1
close grpc server in test file to avoid goroutine leak
2023-02-10 07:39:30 -08:00
Kubernetes Prow Robot
70dde8d746
Merge pull request #111453 from ardaguclu/debug-support-files
(kubectl debug): Support debugging via files
2023-02-10 03:43:30 -08:00
Antonin Stefanutti
80246e4469
Update staging modules and vendor dir with new code-generator version 2023-02-10 11:03:05 +01:00
Antonin Stefanutti
634fb1b936
Update client examples with generated apply configurations 2023-02-10 11:01:37 +01:00
Antonin Stefanutti
a6109241a3
code-generator: fix GOPATH unbound variable 2023-02-10 11:01:37 +01:00
Antonin Stefanutti
65c09568d1
Add applyconfiguration-gen to code-generator tools.go 2023-02-10 11:01:37 +01:00
Antonin Stefanutti
299f74c161
code-generator: regen examples with apply configurations 2023-02-10 11:01:35 +01:00
Antonin Stefanutti
d2bd7d8557
Add applyconfiguration generator to code-generator script 2023-02-10 10:59:35 +01:00
Patrick Ohly
3e2b26ce52 e2e: revise complete report creation
The previous approach was based on the observation that some Prow jobs use the
--report-dir parameter instead of the E2E_REPORT_DIR env variable. Parsing the
command line was necessary to use the --json-report and --junit-report
parameters.

But that is complex and can be avoided by triggering the creation of complete
reports in the E2E test suite. The paths are hard-coded and relative to the
report directory to keep the code simple.

There was a report that k8s-triage started processing more data after
6db4b741dd was merged. It's unclear whether
that was because of the new <report-dir>/ginkgo_report.xml file. To avoid
this potential problem, the reports are now in a "ginkgo" sub-directory.

While at it, error checking gets enhanced:
- Create directories at the start of
  the suite and bail out early if that fails.
- *All* e2e suites using the framework do this, not just test/e2e.
- Added missing error checking of truncated JUnit report writing.
2023-02-10 10:20:20 +01:00
Arda Güçlü
c40f9f8bbb Add explicitNamespace into ignore list in debug unit tests
Since, `explicitNamespace` is set by kubeconfig automatically, we can
safely add this field into ignore list.
2023-02-10 11:31:19 +03:00
Arda Güçlü
e0fedec69d (kubectl debug): Support debugging via files
Currently `kubectl debug` only supports passing names in command line.
However, users might want to pass resources in files by passing `-f` flag like
in all other kubectl commands.

This PR adds this ability.
2023-02-10 10:21:30 +03:00
Krzysztof Ostrowski
711a985217
kmsv2: add LocalKEKService
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
2023-02-10 07:18:57 +00:00
SataQiu
d12b4d4c67 kubeadm: show a warning message when detecting that the sandbox image of the container runtime is inconsistent with that used by kubeadm 2023-02-10 14:59:40 +08:00
Kubernetes Prow Robot
d2f40481d1
Merge pull request #115669 from aramase/aramase/f/structured_logging_check_kms
logcheck.conf: ensure that kms and value/encrypt uses structured logging
2023-02-09 20:37:46 -08:00