Commit Graph

82609 Commits

Author SHA1 Message Date
Patrick Ohly
311b66ada1 e2e: unit test for logger.go and ginkgowrapper.go
This test runs a fake Ginkgo suite with various errors and checks how
logger.go respectively ginkgowrapper.go handle this. Right now, the
outcome is sub-optimal:

- some test failures (those that use framework.Failf or
  framework.ExpectNoError) are logged immediately, Gomega failures
  are not
- framework.ExpectNoError logs just the error, which is often useless
  without the additional explanation
- failures that occur after some others are not reported at all;
  this can happen in cleanup code and while that code should better
  be written so that it contines instead of failing on an assertion,
  in practice quite a lot of code fails and when it does, the output
  would be useful to have
- the full stack trace is odd and doesn't start with the expected
  function name

Example output:

• Failure [0.002 seconds]
log
/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:35
  fails [It]
  /nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:39

  Jul 17 12:00:52.545: I'm failing.

  /nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:41

  Full Stack Trace
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger.go:51 +0x143
  k8s.io/kubernetes/test/e2e/framework/log.Failf(...)
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger.go:43
  k8s.io/kubernetes/test/e2e/framework/log_test.glob..func1.2.1(...)
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:41
  k8s.io/kubernetes/test/e2e/framework/log_test.glob..func1.2()
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:42 +0x52
  k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00029b020, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:65 +0x1c8
  testing.tRunner(0xc000358600, 0x19818c0)
  	/nvme/gopath/go/src/testing/testing.go:865 +0xc0
  created by testing.(*T).Run
  	/nvme/gopath/go/src/testing/testing.go:916 +0x35a

------------------------------
Jul 17 12:00:52.545: INFO: before
Jul 17 12:00:52.545: INFO: I'm failing.
Jul 17 12:00:52.547: INFO: after
• Failure [0.002 seconds]
log
/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:35
  asserts [It]
  /nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:44

  false is never true
  Expected
      <bool>: false
  to equal
      <bool>: true

  /nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:45

  Full Stack Trace
  	/nvme/gopath/src/k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:75 +0x1f1
  k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion.(*Assertion).To(0xc00035f6c0, 0x1b42140, 0xc000350dd0, 0xc000350de0, 0x1, 0x1, 0x42e35f)
  	/nvme/gopath/src/k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:38 +0xc7
  k8s.io/kubernetes/test/e2e/framework/log_test.glob..func1.3()
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:45 +0x17e
  k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00029b0e0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:65 +0x1c8
  testing.tRunner(0xc000358600, 0x19818c0)
  	/nvme/gopath/go/src/testing/testing.go:865 +0xc0
  created by testing.(*T).Run
  	/nvme/gopath/go/src/testing/testing.go:916 +0x35a

------------------------------
Jul 17 12:00:52.548: INFO: before
Jul 17 12:00:52.549: INFO: after
• Failure [0.002 seconds]
log
/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:35
  error [It]
  /nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:47

  hard-coded error
  Unexpected error:
      <*errors.errorString | 0xc000351930>: {
          s: "I'm an error, nice to meet to.",
      }
      I'm an error, nice to meet to.
  occurred

  /nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:49

  Full Stack Trace
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/util.go:1376 +0x191
  k8s.io/kubernetes/test/e2e/framework.ExpectNoError(...)
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/util.go:1367
  k8s.io/kubernetes/test/e2e/framework/log_test.glob..func1.4()
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:49 +0xc9
  k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00029b200, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	/nvme/gopath/src/k8s.io/kubernetes/test/e2e/framework/log/logger_test.go:65 +0x1c8
  testing.tRunner(0xc000358600, 0x19818c0)
  	/nvme/gopath/go/src/testing/testing.go:865 +0xc0
  created by testing.(*T).Run
  	/nvme/gopath/go/src/testing/testing.go:916 +0x35a

------------------------------
Jul 17 12:00:52.550: INFO: before
Jul 17 12:00:52.550: INFO: Unexpected error occurred: I'm an error, nice to meet to.
Jul 17 12:00:52.551: INFO: after
2019-08-26 11:32:25 +02:00
toyoda
c3fdb5e7d9 Use log functions of core framework on test/e2e/apps 2019-08-26 17:38:11 +09:00
Kubernetes Prow Robot
8a2def5b51
Merge pull request #81927 from nikhita/publishing-fix-rules
publishing: add missing deps for 1.16 branch
2019-08-26 01:14:21 -07:00
RainbowMango
a36704b444 Clean up staticcheck issues. 2019-08-26 15:35:32 +08:00
Dr. Stefan Schimanski
91bab45a0b apiextension: ratcheting validation of unpruned defaults 2019-08-26 09:01:07 +02:00
Nikhita Raghunath
5c4737d027 publishing: add missing deps for 1.16 branch 2019-08-26 12:18:48 +05:30
SataQiu
d9bfff9976 e2e_kubeadm: use log functions of core framework 2019-08-26 13:56:14 +08:00
Kubernetes Prow Robot
36b2914207
Merge pull request #81809 from oomichi/replace-e2elog-framework-p
Use log functions of core framework on p*
2019-08-25 21:40:21 -07:00
Guangming Wang
c6791aa82b v1beta1: bugfix in Event struct definition
rebase master, handle staticcheck error
2019-08-26 11:06:16 +08:00
Kubernetes Prow Robot
32d8b50fd8
Merge pull request #81812 from Huang-Wei/fix-bug-staticcheck
Tolerate ending slash when running staticcheck
2019-08-25 19:54:20 -07:00
hwdef
0fa8d7177f fix typo in build/platforms.bzl 2019-08-26 10:31:21 +08:00
Ted Yu
55cc0e2957 Correct comment in CertOrKeyExist 2019-08-25 19:30:20 -07:00
Kubernetes Prow Robot
12e6930d8a
Merge pull request #81842 from verb/range-scheduler
Add test for HTTPExtender.IsInterested
2019-08-25 15:48:20 -07:00
Ricardo Pchevuzinske Katz
6c30d23e6c
Remove watching Endpoints of Headless Services
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@serpro.gov.br>
2019-08-25 17:27:08 -03:00
Wei Huang
b2751cf821
Tolerate ending slash when running staticcheck 2019-08-25 11:10:40 -07:00
Kubernetes Prow Robot
55e476356f
Merge pull request #81899 from liggitt/deprecate-crd-v1beta1
Mark v1beta1 webhooks/CRD types deprecated in favor of v1
2019-08-25 00:10:21 -07:00
Kubernetes Prow Robot
7ebbe34d9c
Merge pull request #81794 from codenrhoden/split-host-utils2
Split HostUtil functionality into its own files
2019-08-24 22:28:21 -07:00
Mike Spreitzer
529a168be9 Updated comments in wait.go
The comments on the fields of Backoff did not match the behavior of
the Step() method.

The comment on the Step method did not make it clear whether the
returned amount of time to sleep is based on the original or the
revised duration.

The comments on the ExponentialBackoff function did not exactly and
clearly correspond to the actual behavior.
2019-08-25 00:32:29 -04:00
Jordan Liggitt
078cb91791 generated
Change-Id: I6389f8d1eb169ab89b2f73b7c9f2b3d880a9a6bb
2019-08-24 22:20:35 -04:00
Jordan Liggitt
78277afe1b Mark v1beta1 admissionwebhook and crd types as deprecated 2019-08-24 22:20:34 -04:00
Jordan Liggitt
8c10d929ca Use cached selectors/client for webhooks 2019-08-24 20:00:46 -04:00
Jordan Liggitt
27f535e26a Add admission benchmarks
go test ./vendor/k8s.io/apiserver/pkg/admission/plugin/webhook/validating -bench . -benchmem -run DoNotRun
go test ./vendor/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating -bench . -benchmem -run DoNotRun
2019-08-24 20:00:45 -04:00
Jordan Liggitt
14154c2345 Let webhook accessors construct client/selectors once 2019-08-24 17:10:09 -04:00
Kubernetes Prow Robot
a76d7fdf64
Merge pull request #81884 from sttts/sttts-fix-openapi-spec-generation
Remove preliminarily committed OpenAPI packages
2019-08-24 06:10:24 -07:00
Kubernetes Prow Robot
8e05e8346a
Merge pull request #81693 from oomichi/replace-e2elog-framework-c-n
Use log functions of core framework on [c-n]
2019-08-24 04:48:24 -07:00
Kubernetes Prow Robot
8f6b89f0b9
Merge pull request #81860 from deads2k/allow-http1-only
allow an apiserver to only serve http1
2019-08-24 03:24:24 -07:00
Dr. Stefan Schimanski
566d207165 apiextensions: remove preliminary committed openapi packages 2019-08-24 12:11:45 +02:00
Dr. Stefan Schimanski
10b80fcf8b kube-aggregator: remove preliminary committed openapi packages 2019-08-24 12:11:29 +02:00
Kubernetes Prow Robot
ec344a1c77
Merge pull request #81771 from RainbowMango/pr_fix_static_error_for_gce
Cleanup gce static analysis issues
2019-08-24 00:04:25 -07:00
Kubernetes Prow Robot
ce8cccb966
Merge pull request #81072 from draveness/feature/runtime-class-scheduling-admission-plugin
[RuntimeClassScheduling] Update runtime class admission plugin - Part2
2019-08-23 22:26:37 -07:00
Kubernetes Prow Robot
e2f57be0c0
Merge pull request #77824 from roycaihw/webhook-trace
mutating webhook: audit log mutation existence and patch
2019-08-23 22:26:24 -07:00
Kubernetes Prow Robot
448049927b
Merge pull request #81752 from dims/hack-pick-up-test-go-files-in-verify-import-boss
Pick up *_test.go in verify-import-boss
2019-08-23 20:56:38 -07:00
Kubernetes Prow Robot
8dc4b1b585
Merge pull request #80213 from bclau/tests/skips-windows-unrelated-tests
tests: Skips Windows-unrelated tests on Windows
2019-08-23 20:56:25 -07:00
RainbowMango
4b6ac364f8 Clean up staticcheck issues for gce.
Dealing with deprecated issues. (staticcheck SA1019)
Dealing with error discard issue. (staticcheck SA4006)
Dealing with context overwritten issue. (staticcheck SA4009)
Dealing with unused functions. (staticcheck U1000)
Remove gce from staticcheck failure list
2019-08-24 10:14:39 +08:00
Kubernetes Prow Robot
9a5b87a58b
Merge pull request #81821 from hwdef/fix-typo-cmd/kubeadm/app/util/config/initconfiguration.go
fix-typo-cmd/kubeadm/app/util/config/initconfiguration.go
2019-08-23 17:59:30 -07:00
Kubernetes Prow Robot
f105fef3d5
Merge pull request #81429 from huffmanca/resize_block_volume
Enables resizing of block volumes.
2019-08-23 17:59:05 -07:00
Kubernetes Prow Robot
5ced7377c3
Merge pull request #81428 from MrHohn/cpva-v0.8.1
Bump vertical autoscaler to v0.8.1
2019-08-23 17:58:50 -07:00
Kubernetes Prow Robot
d5f9a81d0f
Merge pull request #79873 from tedyu/kube-runtime
Set runtimeState when RuntimeReady is not set or false
2019-08-23 17:58:37 -07:00
Kubernetes Prow Robot
f9afe46d23
Merge pull request #78829 from sttts/sttts-crd-embedded-resource-metadata-defaulting
apiextensions: complete default-under-metadata validation and storage pruning
2019-08-23 17:58:24 -07:00
Kubernetes Prow Robot
d2e2337744
Merge pull request #81847 from seans3/update-generate-options
Update PrintOptions to more appropriate GenerateOptions in some cases
2019-08-23 15:49:20 -07:00
Kubernetes Prow Robot
b55f3252e1
Merge pull request #81843 from codenrhoden/remove-nsenter
Remove nsenter impl from pkg/vol/util
2019-08-23 15:49:06 -07:00
Kubernetes Prow Robot
9ae0963fb7
Merge pull request #81839 from krzysied/node_controller_pod_informer
Moving podInformer to node controller scope
2019-08-23 15:48:53 -07:00
Kubernetes Prow Robot
0a486d97ed
Merge pull request #81415 from oxddr/asdf
kube-proxy: improve logging around network programming latency SLI.
2019-08-23 15:48:39 -07:00
Kubernetes Prow Robot
4680ec8fde
Merge pull request #81346 from mrkm4ntr/fits-on-node-fast-path
Add fast path to podFitsOnNode
2019-08-23 15:48:26 -07:00
Tim Allclair
c6173b28a9 Enable the RuntimeClass admission controller for scheduling 2019-08-23 13:33:06 -07:00
Kubernetes Prow Robot
220498b83a
Merge pull request #81107 from wongma7/expand-cleanup
Don't overwrite PVC with nil/empty object returned by failed Update
2019-08-23 13:31:31 -07:00
Kubernetes Prow Robot
d52b212189
Merge pull request #79908 from wenjiaswe/remove-aggregator-ca-key
Remove unused aggregator ca key
2019-08-23 13:31:18 -07:00
Dr. Stefan Schimanski
4fd200c148 apiextension: prune default values in storage 2019-08-23 22:20:54 +02:00
Dr. Stefan Schimanski
135902b0f4 apiextension: complete validation of meta data defaults 2019-08-23 22:20:54 +02:00
Dr. Stefan Schimanski
90fed073c7 apiextension: reject x-kubernetes-embedded-resource with empty properties 2019-08-23 22:20:54 +02:00