The name concatenation and ownership check were originally considered small
enough to not warrant dedicated functions, but the intent of the code is more
readable with them.
Moving the registry into its own package will avoid dependency cycles in future
PRs.
Creating loggers through a factory instead of storing pre-created instances
will make it possible to create the loggers differently depending on
configuration parameters.
The factory can also be used to provide additional meta data before creating
instances.
The intention in
ecb3813726
was to use the component-base/OWNERS labels only as fallback when the OWNERS
files in the sub-directories don't set labels. This should never have been
necessary because all of those sub-directories have reasonable labels
configured.
But in practice, the labels were also added to PRs that only touched files in
sub-directory because OWNERS files are inherited, which created noise in
various sigs that shouldn't have been tagged for those PRs.
This patch changes cpuCount to cpuRequest in order to cater to cases
where guaranteed pods make non-integral CPU Requests.
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
apparmor is no longer found in Alpine edge/testing but in
edge/community, presumably in preparation for full-fledged inclusion in
3.15. If so, once that is released, BASEIMAGE can be updated again and
the explicit --repository flag to 'apk add' dropped.
Fixes: https://github.com/kubernetes/kubernetes/issues/105528
I initially noticed a minor typo in --tty, and while fixing it,
I noticed small discrepancies in some other flags. These minor
changes should make the 'kubectl run' flag help slightly more
correct (hopefully). 🙂
Once the node gets deleted, the nodelifecycle controller
is racing to update pod status and the pod deletion logic
is failing causing tests to flake. This commit moves
the testContext creation to within the test loop and deletes nodes,
namespace within the test loop. We don't explicitly call the node
deletion within the loop but the `testutils.CleanupTest(t, testCtx)`
call ensures that the namespace, nodes gets deleted.
The name concatenation and ownership check were originally considered small
enough to not warrant dedicated functions, but the intent of the code is more
readable with them.
There also was a missing owner check in the attach controller.
The name concatenation and ownership check were originally considered small
enough to not warrant dedicated functions, but the intent of the code is more
readable with them.
- Extract the current redirect code into a function
(proxyRedirectsforRootPath) and redirect for only
http.MethodGet or http.MethodHead
- Create a unit test that confirms that only GET &
HEAD methods are redirected
