Commit Graph

116038 Commits

Author SHA1 Message Date
Akihiro Suda
af95a76bb2
cri-api: fix comment lines about PROPAGATION_PRIVATE
The current CRI implementations treat `PROPAGATION_PRIVATE` as "rprivate", not "private":
- https://github.com/containerd/containerd/blob/v1.6.16/pkg/cri/opts/spec_linux.go#L181
- https://github.com/cri-o/cri-o/blob/v1.26.1/server/container_create_linux.go#L982

However, this is not always true for cri-dockerd, which treats `PROPAGATION_PRIVATE` as
noop and lets dockerd use its default propagation mode:
- https://github.com/Mirantis/cri-dockerd/blob/v0.3.1/libdocker/helpers.go#L235-L236
  (The "private is default" comment in L236 is inaccurate)

dockerd's default propagation mode is "rprivate" for most cases, but dockerd changes
its default propagation mode to "rslave" when the mount source contains the daemon root
(`/var/lib/docker`):
- https://github.com/moby/moby/blob/v20.10.23/volume/mounts/linux_parser.go#L145
- https://github.com/moby/moby/blob/v20.10.23/daemon/volumes.go#L137-L143
- https://github.com/moby/moby/blob/v20.10.23/daemon/volumes_linux.go#L11-L36

This behavior was introduced in Docker 18.03 (moby/moby PR 36055).

Related:
- kubernetes/website PR 39385
- Mirantis/cri-dockerd PR 159

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-03-22 21:37:30 +09:00
major1201
daa1d287e4 fix GetPodVolumeClaims in comments 2023-03-22 17:23:05 +08:00
Kubernetes Prow Robot
3cf9f66e90
Merge pull request #116743 from thockin/docs-clarify-publish-not-ready-endpoints
Clarify EPSlice docs wrt the Ready conditions
2023-03-21 23:14:35 -07:00
Tim Allclair
7537cec567
Fix MatchConditions webhook validation testing (#116784)
* Fix MatchConditions webhook validation testing

* #squash verify error type

* #squash fix duplicate registration

* #squash uncomment validation test
2023-03-21 21:38:35 -07:00
Paco Xu
c14068c202 deflake: Add retry with timeout to wait for final conditions 2023-03-22 11:24:09 +08:00
Maxim Patlasov
fbf33e32e6 Fix memory leak in kubelet volume_manager populator processedPods
`findAndRemoveDeletedPods()` processes only pods from volume_manager cache: `dswp.desiredStateOfWorld.GetVolumesToMount()`. `podWorker` calls volume_manager `WaitForUnmount()` asynchronously. If it happens after populator cleaned up resources, an entry is added to `processedPods` and will never be seen. Let's cleanup such entries if they don't have a pod and marked for deletion.
2023-03-21 20:16:02 -07:00
Qirui
ddc13e983b Chore: add selector labels tweak function 2023-03-22 11:02:25 +08:00
Qirui
4cab11f26f Chore: add persistent volume claim retention policy tweak function 2023-03-22 11:02:01 +08:00
Qirui
ba9dfe686f Chore: add persistent volume claim template tweak function 2023-03-22 11:01:37 +08:00
Qirui
f97d3cf748 Chore: add rolling update max unavailable type tweak function 2023-03-22 11:01:25 +08:00
Qirui
1b17b4fa79 Chore: add rolling update partition type tweak function 2023-03-22 11:01:04 +08:00
Qirui
f3ffeae426 Chore: add update strategy type tweak function 2023-03-22 11:00:46 +08:00
Qirui
5e0161b3de Chore: add labels tweak function 2023-03-22 11:00:25 +08:00
Qirui
ec34891782 Chore: add annotation tweak function 2023-03-22 10:51:54 +08:00
Qirui
b907d5af49 Chore: add finalizers tweak function 2023-03-22 10:51:41 +08:00
Qirui
18ba7c0e43 Chore: add ordinal start tweak function 2023-03-22 10:51:18 +08:00
Qirui
3eb34d8b6c Chore: add min ready seconds tweak function 2023-03-22 10:51:03 +08:00
Qirui
2161d095fa Chore: add template restart policy tweak function 2023-03-22 10:50:42 +08:00
Qirui
4418a9f590 Chore: add replicas tweak function 2023-03-22 10:49:51 +08:00
Qirui
7fc08e0ce7 Chore: add pod management policy tweak function 2023-03-22 10:48:29 +08:00
Qirui
77c7d6efcf Chore: add basic make function for stateful set
Add name and namespace tweak functions
2023-03-22 10:47:43 +08:00
Kubernetes Prow Robot
c7cc7886e2
Merge pull request #116702 from vinaykul/restart-free-pod-vertical-scaling-podmutation-fix
Fix pod object update that may cause data race
2023-03-21 19:26:36 -07:00
Kubernetes Prow Robot
9c6414cdfe
Merge pull request #116792 from pacoxu/fix-safe-sysctl-windows
safe-sysctl: skip checking for windows
2023-03-21 17:39:59 -07:00
vinay kulkarni
f41702b8d2 Return updatedPod if resize upon successful checkpointing of allocated resources 2023-03-22 00:24:00 +00:00
Paco Xu
e154b73535 safe-sysctl: skip checking for windows 2023-03-22 07:40:29 +08:00
Kubernetes Prow Robot
b2b9395c51
Merge pull request #116800 from claudiubelu/windows-remove-dns-check
kubelet: Read DNS Config options from file for Windows
2023-03-21 16:36:00 -07:00
Claudiu Belu
c68bc27f73 kubelet: Read DNS Config options from file for Windows
A previous commit added the capability to read the DNS configuration options
from a Windows host, while removing the capability to read from a resolv.conf-like
file.

This commit addresses this issue: if the given ``--resolv-conf`` option is not set to
``Host``, it will consider it as a file, preserving the previous behavior.
2023-03-21 22:21:57 +00:00
Kubernetes Prow Robot
8dd3807f4d
Merge pull request #116770 from alexzielenski/agg-discovery-err-sources
Fix aggregated discovery race when using CRD and Aggregated APIService under same group
2023-03-21 15:18:12 -07:00
Alexander Zielenski
933dfe3a51 use longer timeouts to avoid flakes on heavily loaded systems 2023-03-21 14:18:34 -07:00
Kubernetes Prow Robot
2f002862f0
Merge pull request #116820 from Jefftree/patch-1
Update kube_features comment for aggregated discovery and openapi v3
2023-03-21 14:16:12 -07:00
Alexander Zielenski
0740b11073 allow multiple sources to add/remove from discovery without clobbering each other 2023-03-21 14:14:23 -07:00
Kubernetes Prow Robot
786316f0b6
Merge pull request #116780 from KnVerey/applyset-annotation-domain
Use standard *.kubernetes.io instead of *.k8s.io for ApplySet
2023-03-21 12:28:24 -07:00
Kubernetes Prow Robot
6ec366261c
Merge pull request #116658 from Riaankl/add-get-resources-endpoint
Add 12 get * V1APIResources to file pending_eligible_endpoints.yaml
2023-03-21 12:28:11 -07:00
Jeffrey Ying
0e4cece0e8
Update kube_features comment for aggregated discovery and openapi v3 2023-03-21 15:18:41 -04:00
Kubernetes Prow Robot
94daf7f4b2
Merge pull request #116806 from sourcelliu/improvemap
Improve the performance of map usage
2023-03-21 11:30:24 -07:00
Kubernetes Prow Robot
956fa9b9ce
Merge pull request #116785 from enj/enj/i/clean_front_proxy_headers
Clear front proxy headers after authentication is complete
2023-03-21 11:30:11 -07:00
Kubernetes Prow Robot
9e622d2364
Merge pull request #116809 from liggitt/ci-regex
Fix CI regex for missing rc.0 tags
2023-03-21 09:56:24 -07:00
Kubernetes Prow Robot
9614d7c03b
Merge pull request #116783 from tallclair/cel-authz
[CEL] Clean up reference to deleted denied function
2023-03-21 09:56:11 -07:00
Kubernetes Prow Robot
42f54ccf9c
Merge pull request #116724 from tallclair/gc-test-flake
Deflake GC e2e test
2023-03-21 08:19:08 -07:00
Monis Khan
e9866d2794
Clear front proxy headers after authentication is complete
This matches the logic we have for the Authorization header as well
as the impersonation headers.

Signed-off-by: Monis Khan <mok@microsoft.com>
2023-03-21 10:51:22 -04:00
Jordan Liggitt
188844c3db
Make prerelease tag optional in CI versions 2023-03-21 09:23:45 -04:00
Jordan Liggitt
2010eaac52
Annotate CI version regexes 2023-03-21 09:08:05 -04:00
Jordan Liggitt
9ba4df15f8
Drop unused regex grouping 2023-03-21 09:08:05 -04:00
Jordan Liggitt
bff737d328
Update comments 2023-03-21 09:08:04 -04:00
Jordan Liggitt
e33a233c3b
Delete unused version regex function 2023-03-21 09:08:04 -04:00
mantuliu
0567c93b2a Improve the performance of map usage
Signed-off-by: mantuliu <240951888@qq.com>
2023-03-21 20:37:53 +08:00
Paco Xu
a2cf4e7345
use describe node to print node events as well 2023-03-21 14:57:12 +08:00
Tim Allclair
d109f60a05 Clean up reference to deleted denied function 2023-03-20 18:24:10 -07:00
Tim Allclair
9cce3fa107 Deflake GC e2e test 2023-03-20 16:09:30 -07:00
Kubernetes Prow Robot
c9ff286668
Merge pull request #116772 from jiahuif-forks/fix/validating-admission-policy/message-expression-validation
ValidatingAdmissionPolicy: fix policy object validation
2023-03-20 15:21:11 -07:00