Andrew Sy Kim
4bb30c3b0e
kubelet: add feature gate check for exec probe timeouts
...
This change also involves adding a custom error type for probe timeouts
so that the kubelet exec prober can distinguish between failed probes
that have exited or probes that have timed out.
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:05:09 -05:00
Andrew Sy Kim
0b6ef21233
features: add ExecProbeTimeout feature gate
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:05:08 -05:00
Andrew Sy Kim
8ef299552b
kubelet: allow dockershim exec timeouts to be longer than 10s
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:03:28 -05:00
Andrew Sy Kim
81ad32e3a4
kubelet: add e2e test for exec readiness probe timeout
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:03:28 -05:00
Andrew Sy Kim
733862ed7f
kubelet: stop skipping docker exec livenessprobe timeout test
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:03:28 -05:00
Andrew Sy Kim
2887e707f8
kubelet: respect probe exec timeout from CRI by returning utilexec.CodeExitError
...
This fixes a bug where the exec timeouts are not respected with
containerd
Exec prober expects a utilexec.CodeExitError on failed probes, otherwise
the prober returns 'Unknown' and a non-nil error which the kubelet throws
away. As a temporary fix, ExecSync as part of the CRI remote runtime
should return utilexec.CodeExitError when the grpc error code is
DeadlineContextExceeded. This ensure the exec prober registers exec
timeouts as real probe failures to the kubelet. We should also add a
TimededError type to k8s.io/utils/exec since it doesn't really make
sense to use CodeExitError for exec time outs.
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:03:28 -05:00
Andrew Sy Kim
1dc5fb0190
kubelet: respect dockershim exec timeout
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-09 13:03:28 -05:00
Kubernetes Prow Robot
23839ba649
Merge pull request #96305 from twosigma/fixe2etestbug
...
Fixing expected pod subdomain to match framework.TestContext.ClusterD…
2020-11-09 08:22:26 -08:00
Kubernetes Prow Robot
0cba30d891
Merge pull request #95954 from sttts/sttts-go-openapi
...
apiextensions: replace go-openapi with kube-openapi fork for validation
2020-11-09 07:18:27 -08:00
Kubernetes Prow Robot
d2fd467123
Merge pull request #96310 from tsmetana/fix-recycler-test
...
PV e2e: fix race in NFS recycling test
2020-11-09 05:52:26 -08:00
Kubernetes Prow Robot
c7291adca2
Merge pull request #96309 from rf232/logfilter
...
Implement log sanitization filter
2020-11-09 04:50:25 -08:00
Rob Franken
3999f7ffbb
Implement log sanitization
...
Implement a LogFilter using the datapol library to prevent accidental
logging of secrets and other confidential data.
2020-11-09 12:59:35 +01:00
Dr. Stefan Schimanski
f63b6772ca
Update bazel
2020-11-09 10:26:39 +01:00
Gautier Delorme
f59a6c7810
apiextensions: adapt error tests to fixed validation messages
...
Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
2020-11-09 10:26:39 +01:00
Dr. Stefan Schimanski
69b0699610
apiextensions: switch validation to kube-openapi
2020-11-09 10:26:38 +01:00
Dr. Stefan Schimanski
dd1709ba46
bump(k8s.io/kube-openapi)
2020-11-09 10:26:38 +01:00
Kubernetes Prow Robot
ef16faf409
Merge pull request #92312 from Sh4d1/kep_1860
...
Make Kubernetes aware of the LoadBalancer behaviour
2020-11-08 23:34:24 -08:00
Kubernetes Prow Robot
2343b8a68b
Merge pull request #95872 from 22dm/kube-proxy-comment-fix
...
Fix the kube-proxy document
2020-11-08 19:23:37 -08:00
Haowei Cai
1c2d446648
require APIServerIdentity to be enabled to run StorageVersionAPI
...
without APIServerIdentity enabled, stale apiserver leases won't be GC'ed
and the same for stale storage version entries. In that case the storage
migrator won't operate correctly without manual intervention.
2020-11-08 19:06:30 -08:00
Haowei Cai
7bcd25907a
apiserver correctly validates encoding/decodable versions
2020-11-08 18:53:40 -08:00
Haowei Cai
23ef9b51a8
updater correctly updates storageversion status
2020-11-08 18:53:40 -08:00
Haowei Cai
8a1d8f7fd5
return a Status formatted JSON response
2020-11-08 18:53:40 -08:00
Haowei Cai
b5b93004b5
generated
2020-11-08 18:53:40 -08:00
Chao Xu
fa1805cc5c
Add an integration test.
...
To make sure that the storage version filter can block certain requests until
the storage version updates are completed, and that the apiserver works
properly after the storage version updates are done.
2020-11-08 18:53:40 -08:00
Chao Xu
22452917c2
make some rbac and scheduling post start hooks tolerate the apiserver
...
bootstrap delay caused by installing storage versions.
2020-11-08 18:53:40 -08:00
Chao Xu
7218978716
Add a generic filter that blocks certain write requests before
...
StorageVersions are updated during apiserver bootstrap.
Also add a poststarthook to the aggregator which updates the
StorageVersions via the storageversion.Manager
2020-11-08 18:53:40 -08:00
Kubernetes Prow Robot
f43007543c
Merge pull request #96326 from Huang-Wei/cleanup-sched-perf
...
Update docs and fix redundant logic of scheduler perf
2020-11-08 18:35:37 -08:00
Chao Xu
3694756816
Collect storage versions as ResourceInfo when installing API endpoints.
...
Co-authored-by: Haowei Cai <haoweic@google.com>
2020-11-08 18:34:59 -08:00
Chao Xu
56369375e0
Add a feature gate
2020-11-08 18:34:59 -08:00
Kubernetes Prow Robot
ce036e0800
Merge pull request #96340 from andyzhangx/patch-1
...
add andyzhangx as reviewer
2020-11-08 03:47:37 -08:00
Andy Zhang
9056e3a86a
add andyzhangx as reviewer
2020-11-08 16:55:03 +08:00
Kubernetes Prow Robot
2570a9d94c
Merge pull request #96306 from SataQiu/small-fix-20201106
...
kubeadm: fix the lint failure where return value is not checked
2020-11-07 11:43:37 -08:00
Patrik Cyvoct
dd5646d56d
fix ingress comparaison
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 11:46:42 +01:00
Kubernetes Prow Robot
0e42122270
Merge pull request #96308 from andyzhangx/update-max-azuredisk-count
...
update max azure data disk count map
2020-11-07 02:33:38 -08:00
Patrik Cyvoct
20fc86df25
fix defaulting
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:59 +01:00
Patrik Cyvoct
0768b45e7b
add nil case in proxy
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:58 +01:00
Patrik Cyvoct
fea88f44a7
fix build
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:57 +01:00
Patrik Cyvoct
40dcef27c4
fix nit in validation
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:56 +01:00
Patrik Cyvoct
11b97e9ef8
fix tests
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:55 +01:00
Patrik Cyvoct
1fd08bc92e
Update generated
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:54 +01:00
Patrik Cyvoct
540901779c
fix reviews
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:53 +01:00
Patrik Cyvoct
af7494e896
Update generated
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:52 +01:00
Patrik Cyvoct
7bdf2af648
fix review
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:51 +01:00
Patrik Cyvoct
88330eafef
fix typo
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:50 +01:00
Patrik Cyvoct
7977e0ac44
add owner for feature gate
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:48 +01:00
Patrik Cyvoct
7460f9e00b
fix rebase
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:30 +01:00
Patrik Cyvoct
0153b96ab8
fix review
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 10:00:27 +01:00
Patrik Cyvoct
d562b6924a
Add tests
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 09:59:59 +01:00
Patrik Cyvoct
47ae7cbf52
Add route type field to loadbalancer status ingress
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-11-07 09:59:58 +01:00
Wei Huang
267acdbe81
Update docs and fix redundant logic of scheduler perf
2020-11-06 23:45:09 -08:00