Patrick Ohly
cd943dd95e
scheduler: fix tracking of concurrent events
...
The previous approach was based on the assumption that an in-flight pod can use
the head of the received event list as marker for identifying all events that
occur while the pod is in flight. That assumption is incorrect: when that
existing element gets removed from the list because all pods that were
in-flight when it was received are done, that marker's Next method returns nil
and the code which should have seen several concurrent events (if there were
any) missed all of those.
As a result, a pod with concurrent events could incorrectly get moved to the
unschedulable queue where it could got stuck until the next periodic purging
after 5 minutes if there was no other event for it.
The approach with maintaining a single list of concurrent events can be fixed
by inserting each in-flight pod into the list and using that element to
identify "more recent" events for the pod.
2023-09-05 19:58:38 +02:00
Kubernetes Prow Robot
5bc659eb7b
Merge pull request #120422 from neolit123/1.29-fix-cmd-kubeapiserver-import-pkiutils
...
cmd/kube-apiserver: remove import of cmd/kubeadm, add import-boss rules
2023-09-05 10:20:51 -07:00
Kubernetes Prow Robot
e00af59d0f
Merge pull request #120340 from pohly/dra-helper-logging-improvements
...
DRA: helper logging improvements
2023-09-05 09:05:51 -07:00
Antonio Ojea
933bcc123b
only drop invalid cstate packets if non liberal
...
Conntrack invalid packets may cause unexpected and subtle bugs
on esblished connections, because of that we install by default an
iptables rules that drops the packets with this conntrack state.
However, there are network scenarios, specially those that use multihoming
nodes, that may have legit traffic that is detected by conntrack as
invalid, hence these iptables rules are causing problems dropping this
traffic.
An alternative to solve the spurious problems caused by the invalid
connectrack packets is to set the sysctl nf_conntrack_tcp_be_liberal
option, but this is a system wide setting and we don't want kube-proxy
to be opinionated about the whole node networking configuration.
Kube-proxy will only install the DROP rules for invalid conntrack states
if the nf_conntrack_tcp_be_liberal is not set.
Change-Id: I5eb326931ed915f5ae74d210f0a375842b6a790e
2023-09-05 14:16:17 +00:00
Lubomir I. Ivanov
7c75b018d5
cmd/kube-apiserver: add .import-restrictions
...
Allow only /pkg, /plugin, /third_party, /cmd/kube-apiserver, /test/utils.
This disallows imports of other cmd packages like cmd/kubeadm.
2023-09-05 16:03:28 +03:00
Kubernetes Prow Robot
7e9fbc449d
Merge pull request #120425 from akhilerm/drop-1.24
...
drop release-1.24 rules from publishing-bot
2023-09-05 06:01:51 -07:00
Akhil Mohan
43783aeb18
drop release-1.24 rules from publishing-bot
...
release-1.24 has been EOL since May 2023 and the last patch release
came out in August 2023
Signed-off-by: Akhil Mohan <makhil@vmware.com>
2023-09-05 17:25:42 +05:30
Lubomir I. Ivanov
6ec8dbe5b5
cmd/kube-apiserver: avoid importing the kubeadm pkiutils package
...
The package "k8s.io/kubernetes/cmd/kubeadm/app/util/pkiutil"
is used for a couple of function calls:
- pkiutil.NewCertAndKey() to generate a cert/key pair
- pkiutil.WriteCertAndKey() to write the pair to disk
Unroll and simplify the functions to obtain the same functionality
while removing the cmd/kubeadm dependency.
2023-09-05 14:14:47 +03:00
Kubernetes Prow Robot
8e2b12a220
Merge pull request #119068 from lauchokyip/podgc-unit-test
...
added podgc orphaned pod unit tests
2023-09-05 03:19:49 -07:00
Kubernetes Prow Robot
9fca4ec44a
Merge pull request #120399 from SataQiu/clean-scheduler-20230904
...
scheduler: remove unused constant SchedulerPolicyConfigMapKey
2023-09-05 00:05:52 -07:00
jinye
9795df456f
cleanup:e2e:stop using deprecated wait.ErrWaitTimeout
2023-09-04 21:53:08 +08:00
Kubernetes Prow Robot
294bde0079
Merge pull request #120119 from Ithrael/fix/kubectl-events-doesnt-filter-events-by-GroupVersion-for-resource-with-full-name
...
fix(kubectl): kubectl events doesn't filter events by GroupVersion fo…
2023-09-04 06:45:48 -07:00
kerthcet
e6dfdb240f
Output the error message for better analylsis
...
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-09-04 20:31:48 +08:00
Kubernetes Prow Robot
6586296afc
Merge pull request #120305 from Rei1010/cleanUp
...
e2e_scheduling:stop using deprecated framework.ExpectError
2023-09-04 04:49:59 -07:00
Kubernetes Prow Robot
a800e8534e
Merge pull request #119487 from carlory/cleanup-e2e-autoscaling-framework-equal
...
e2e_autoscaling: stop using deprecated framework.ExpectEqual
2023-09-04 04:49:48 -07:00
Kubernetes Prow Robot
5d94b2a8e8
Merge pull request #118709 from ty-dc/pr/ut
...
[UT] add ut for pkg/registry/networking/ipaddress
2023-09-04 02:49:48 -07:00
SataQiu
cae090e7fe
scheduler: remove unused constant SchedulerPolicyConfigMapKey
2023-09-04 17:48:36 +08:00
Patrick Ohly
3c2cfd9a4f
resource claim controller: separate generated suffix from base
...
When the resource claim name inside the pod had some suffix like "1a" in
"resource-1a", the generated name suffix got added directly after that, leading
to "my-pod-resource-1ax6zgt".
Adding another hyphen makes the result more readable: "my-pod-resource-1a-x6zgt".
2023-09-04 09:45:25 +02:00
Akhil Mohan
214772c110
dependencies: update opencontainers/selinux to v1.11.0
...
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
2023-09-04 10:24:26 +05:30
Kubernetes Prow Robot
cd04f47e8b
Merge pull request #120381 from my-git9/dnsut1
...
kubeadm: increase ut coverage for addons/dns/dns.go
2023-09-03 20:21:47 -07:00
Kubernetes Prow Robot
d4050a80c7
Merge pull request #119394 from aroradaman/fix/proxy-conntrack
...
Fix stale conntrack flow detection logic
2023-09-03 14:53:46 -07:00
Kubernetes Prow Robot
1bfced5848
Merge pull request #120392 from dims/set-external-credential-provider-to-true-by-default-in-kube-up.sh
...
Set external credential provider to true by default in kube-up.sh
2023-09-03 13:51:47 -07:00
Davanum Srinivas
3f8f14397e
Set external credential provider to true by default in kube-up.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-09-03 15:39:53 -04:00
Kubernetes Prow Robot
6fa2df07d6
Merge pull request #120389 from aojea/external_provider_test
...
Don't run the nodeipam controller on KCM if cloud provider external
2023-09-03 12:19:46 -07:00
Antonio Ojea
410ac1456c
Don't run the nodeipam controller on KCM if cloud provider external
...
Change-Id: Ic1da0e9ced2dc8d3d382fee5636bbee18b3a29f7
Signed-off-by: Antonio Ojea <aojea@google.com>
2023-09-03 18:18:36 +00:00
Kubernetes Prow Robot
ea3353dd6b
Merge pull request #119410 from Jefftree/kubectl-cleanup
...
Cleanup kubectl legacy server fallback
2023-09-03 07:15:46 -07:00
Kubernetes Prow Robot
751058c0a4
Merge pull request #120285 from wlq1212/cleanup/e2e/clouod
...
e2e_cloud&common:stop using deprecated framework.ExpectError
2023-09-03 01:21:45 -07:00
Kubernetes Prow Robot
03762cbcb5
Merge pull request #120316 from dims/move-to-new-repo-for-reference
...
New repo who dis? distribution/reference
2023-09-02 21:05:11 -07:00
xin.li
6f55437472
kubeadm: increase ut coverage for addons/dns/dns.go
...
Signed-off-by: xin.li <xin.li@daocloud.io>
2023-09-03 11:07:59 +08:00
Kubernetes Prow Robot
a607dfb3ff
Merge pull request #117503 from dims/phase-4-kep-2395-removing-in-tree-cloud-providers
...
[KEP-2395] Phase 4 - Disabling In-Tree Providers
2023-09-02 11:07:11 -07:00
Davanum Srinivas
ceaed508ce
Validate the cloud-provider passed in and the corresponding feature flags
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-09-02 13:08:04 -04:00
Kubernetes Prow Robot
84faedfbfe
Merge pull request #119989 from bzsuni/cleanup/e2e/auth
...
[e2e_auth] stop using deprecated framework.ExpectNotEqual
2023-09-02 07:33:11 -07:00
Daman Arora
2e5f17166b
pkg/proxy: fix stale detection logic
...
Signed-off-by: Daman Arora <aroradaman@gmail.com>
2023-09-02 12:45:19 +05:30
Kubernetes Prow Robot
4619f7e9d9
Merge pull request #120370 from enj/enj/f/kmsv2_default_kdf
...
kmsv2: add legacy data integration test
2023-09-01 14:35:11 -07:00
Monis Khan
95121fe846
kmsv2: add legacy data integration test
...
Signed-off-by: Monis Khan <mok@microsoft.com>
2023-09-01 15:33:28 -04:00
Davanum Srinivas
42e8cfa28a
fix failing metadata test
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-09-01 15:22:07 -04:00
Davanum Srinivas
cdcbfcc0a6
[KEP-2395] Phase 4 - Disabling In-Tree Providers
...
https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/2395-removing-in-tree-cloud-providers#phase-4---disabling-in-tree-providers
DisableCloudProviders - this feature gate will disable any functionality
in kube-apiserver, kube-controller-manager and kubelet related to the
--cloud-provider component flag.
DisableKubeletCloudCredentialProvider - this feature gate will disable
in-tree functionality in the kubelet to authenticate to the Azure and
GCP container registries for image pull credentials.
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-09-01 15:22:07 -04:00
Jefftree
8255858a7c
remove SkipFilterSchemaForKubectlOpenAPIV2Validation
2023-09-01 14:39:12 -04:00
Kubernetes Prow Robot
b89f564539
Merge pull request #120353 from liggitt/cloud-deps
...
Add unwanted cloud deps to track
2023-09-01 11:28:51 -07:00
Kubernetes Prow Robot
470fe396bd
Merge pull request #120275 from danwinship/kep-3705-to-beta
...
Bump CloudDualStackNodeIPs to beta for 1.29
2023-09-01 11:28:43 -07:00
Kubernetes Prow Robot
1cadbd5887
Merge pull request #120172 from DrAuYueng/fix-log-in-deployment-controller
...
Fix pod deletion log in deployment controller
2023-09-01 11:28:31 -07:00
Kubernetes Prow Robot
a99e377a54
Merge pull request #120221 from enj/enj/i/kms_cache_metrics_lock
...
kmsv2: fix race in simpleCache.set when setting cache size metric
2023-09-01 10:00:31 -07:00
ithrael
39e433891b
fix(test): delete cronjobs.v1.example.com pi for clean up
2023-09-01 23:13:26 +08:00
Kubernetes Prow Robot
a42f4f61c2
Merge pull request #120304 from p0lyn0mial/upstream-storage-options-progress-notification
...
storage: document ProgressNotify from storage.ListOptions
2023-09-01 07:54:51 -07:00
Kubernetes Prow Robot
42275daaaa
Merge pull request #119870 from Jefftree/agg-discovery-406
...
Fallback to legacy discovery on a wider range of conditions
2023-09-01 07:54:44 -07:00
Kubernetes Prow Robot
c3aa3ac3bd
Merge pull request #119468 from Songjoy/cleanup-e2e-upgrades-framework-equal
...
e2e_upgrades: stop using deprecated framework.ExpectEqual
2023-09-01 07:54:32 -07:00
ithrael
36e33cd88e
fix(test): Remove 'shortNames' Property from CronJob Fields in e2e-test
2023-09-01 22:16:06 +08:00
Kubernetes Prow Robot
9a0c389fd7
Merge pull request #120352 from saschagrunert/distroless-bump
...
Update distroless-iptables image version to v0.3.1
2023-09-01 06:52:43 -07:00
Kubernetes Prow Robot
5dd4f1245c
Merge pull request #120118 from Ithrael/doc/kubectl-restart-without-specific-deployment-will-restart-all-deployments
...
doc(kubectl): Kubectl restart command without specific deployment wil…
2023-09-01 06:52:31 -07:00
Jordan Liggitt
3e252857c1
Add unwanted cloud deps to track
2023-09-01 08:58:21 -04:00