Commit Graph

87858 Commits

Author SHA1 Message Date
nolancon
baeff9ec5d Move test case "HintProvider returns empty non-nil map[string][]TopologyHint from
provider" into specific policy tests.
2020-01-16 08:13:06 +00:00
nolancon
599217d482 Move test case "HintProvider returns -nil map[string][]TopologyHint from provider" into specific policy tests 2020-01-16 08:13:06 +00:00
nolancon
57661ee946 Move test case 'HintProvider returns empty non-nil map[string][]TopologyHint' into specific policy tests. 2020-01-16 08:13:06 +00:00
nolancon
51f1af0395 Move test case 'TopologyHint not set' into individual policy tests 2020-01-16 08:13:06 +00:00
nolancon
8466a5852a Restore policy_test.go to upstream
Following commits will contain incremental changes to this file to ease
review process and ensure all tests are accounted for.
2020-01-16 08:13:06 +00:00
nolancon
59bb6c4d6f Update checks in mergeProvidersHints:
- Initialize best Hint to TopologyHint{}
- Update checks.
- Move generic unit test case into policy specific tests and updated
expected outcome to reflect changes.
2020-01-16 08:13:06 +00:00
nolancon
6758f95117 Restore original policy none test cases:
Mistakenly overwritten in earlier commit
2020-01-16 08:13:06 +00:00
nolancon
2d1a535a35 Make mergePermutation generic:
- Remove policy parameters to make function generic
- Move function into top level policy.go
2020-01-16 08:13:06 +00:00
nolancon
5487941485 Refactor filterHints:
- Restructure function
- Remove bug fix for catching {nil true} - To be fixed in later commit
- Restore unit tests to original state for testing filterHints
2020-01-16 08:13:06 +00:00
nolancon
adfd11f38f Make iterateAllProviderTopologyHints generic:
- Remove policy parameters to make this function generic.
- Move function out of individual policies and into policy.go
2020-01-16 08:13:06 +00:00
nolancon
e43f0a5293 Reinstate canAdmitPodResult in policy_none:
This is to keep consistency with the other policies.
This change may be made across all policies in a future PR, but removing it
from the scope of this PR for now.
2020-01-16 08:13:05 +00:00
nolancon
4cc5b9e46c Edit hints returned from policies and unit tests:
- Best Effort Policy: Return hint with nil affinity as opposed to
defaultAffinity when provider has no preference for NUMA affinty or no
possible NUMA affinities.
- Single NUMA Node Policy: Remove defaultHint from mergeProvidersHints.
Instead return appropriate TopologyHint where required.
- Update unit tests to reflect changes. Some test cases moved into
individual policy test functions due to differing returned affinties
per policy.
2020-01-16 08:13:05 +00:00
nolancon
e3d0c9397f Updates to single-numa-node policy:
- Remove getHintMatch method.
- Replace with simplified versions of mergePermutation and
iterateAllProviderTopologyHints methods - as used in best-effort.
- Remove getHintMatch unit tests.
2020-01-16 08:13:05 +00:00
nolancon
b5ca4989e3 Update unit tests:
- Update filterHints test to reflect changes in previous commit.
- Some common test cases achieve differing expected results based on
policy due to independent merge strategies. These cases are moved into
individual policy based test functions.
2020-01-16 08:13:05 +00:00
nolancon
17d615bca2 Update filterHints:
- Only append valid preferred-true hints to filtered
- Return true if allResourceHints only consist of
nil-affinity/preferred-true hints: {nil true}, update defaultHint
preference accordingly.
2020-01-16 08:13:05 +00:00
Adrian Chiris
9f21f49493 Additional unit tests for Topology Manager methods 2020-01-16 08:13:05 +00:00
Adrian Chiris
f886d2a832 Update single-numa-node policy unit tests 2020-01-16 08:13:05 +00:00
Adrian Chiris
2825a7be1a Add new functionality for single-numa-node policy:
Explanation taken from original commit:
- Change the current method of finding the best hint.
  Instead of going over all permutations, sort the hints and find
  the narrowest hint common to all resources.
- Break out early when merging to a preferred hint is not possible
2020-01-16 08:13:05 +00:00
Adrian Chiris
5ce2ea2773 Return defaultAffinity from PolicyBestEffort:
Now that PolicySingleNUMANode is not considered here, return
defaultAffinity as was the original case before previous bug fix
2020-01-16 08:13:05 +00:00
Adrian Chiris
eda1521562 Make mergeProviderHints policy-specific:
- Remove need to pass policy and numaNodes as arguments
- Remove PolicySingleNUMANode special case check in policy_best_effort
- Add mergeProviderHints base to policy_single_numa_node for upcoming
commit
2020-01-16 08:13:05 +00:00
Adrian Chiris
dc36924c37 Update policy_none removing canAdmitPodResult
Update unit tests for none_policy
Add Name test for policy_restricted
2020-01-16 08:13:05 +00:00
Adrian Chiris
cf8b098dda Refactor policy-best-effort
- Modularize code with mergePermutation method
2020-01-16 08:13:05 +00:00
Sascha Grunert
278717bc57
Fix ineffectual assignment to CPUSets
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-01-16 08:57:42 +01:00
Guangwen Feng
e2e5bf5e0b Fix golint warning for pkg/util/procfs/procfs_linux.go
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2020-01-16 15:16:47 +08:00
tanjunchen
1db3f45dc5 test/e2e/framework/rc/:refactor function ByNameContainer 2020-01-16 13:49:02 +08:00
Kubernetes Prow Robot
f437ff75d4
Merge pull request #87254 from egernst/lame-typo-fix
simple typo fix
2020-01-15 21:21:57 -08:00
Kubernetes Prow Robot
550034022f
Merge pull request #87238 from yuzhiquan/patch-scheduler
cleanup(scheduler): remove unused function, remove duplicate comment
2020-01-15 21:21:46 -08:00
Kubernetes Prow Robot
47475c69d1
Merge pull request #87181 from tanjunchen/add-comment-hack-update
add comment in hack/update-*.sh
2020-01-15 21:21:38 -08:00
Kubernetes Prow Robot
fd7c857da7
Merge pull request #87175 from YuikoTakada/move_skip_e2e_cloud
use e2eskipper package in test/e2e/cloud
2020-01-15 21:21:26 -08:00
Kubernetes Prow Robot
ca16ebfa49
Merge pull request #87106 from ialidzhikov/enh/golang@1.13.6
Update to golang@1.13.6
2020-01-15 21:21:15 -08:00
Kubernetes Prow Robot
3a9df0eab3
Merge pull request #87062 from YuikoTakada/move_skip_e2e_auth
Use e2eskipper package in test/e2e/auth
2020-01-15 21:21:01 -08:00
Kubernetes Prow Robot
7ffa2b9c46
Merge pull request #87042 from oomichi/e2e-alias
Add import-aliases check of e2e sub framework
2020-01-15 21:20:48 -08:00
Kubernetes Prow Robot
d9bf22f8f7
Merge pull request #85281 from RainbowMango/pr_add_metrics_flag_to_controller_manager
Allow show hidden metrics in kube-controller-manager
2020-01-15 21:20:34 -08:00
Jin Hase
e1eabf8576 Add comments in several hack/verify-*.sh 2020-01-16 13:54:58 +09:00
tanjunchen
69461d26d8 move function GetKubemarkMasterComponentResoureUsage 2020-01-16 12:35:39 +08:00
Kubernetes Prow Robot
2b6d875504
Merge pull request #87192 from notpad/inte_test
Add integration test for NodeResourceLimits plugin
2020-01-15 19:04:35 -08:00
Kubernetes Prow Robot
2cbd474597
Merge pull request #86400 from Huang-Wei/fix-flaky-preemption-e2e
Fix a flaky scheduler preemption e2e
2020-01-15 19:04:22 -08:00
YuikoTakada
aa2691eeac Fix static check failures in test/e2e/instrumentation/monitoring 2020-01-16 02:42:07 +00:00
RainbowMango
4573428b87 Deal with auto-generated files.
Update bazel by hack/update-bazel.sh
2020-01-16 10:14:18 +08:00
tanjunchen
0c77101b90 add README.md in hack/ 2020-01-16 10:12:18 +08:00
RainbowMango
a4f31e0de7 Add NewFakeKubeRegistry() for testing deprecated metrics. 2020-01-16 10:12:11 +08:00
tanjunchen
b2f76cc780 add comment in hack/update-*.sh 2020-01-16 10:05:49 +08:00
yuzhiquan
0e81e39465 cleanup(scheduler): remove unused function, remove duplicate comment, implement interface
update bazel
2020-01-16 09:07:09 +08:00
Caleb Woodbine
7ac8f58ff6 Fix: formatting 2020-01-16 00:56:06 +00:00
Caleb Woodbine
3ba8f42f96 Update: podTemplateList name; Fix: initial fetching of PodTemplates 2020-01-16 00:52:57 +00:00
Kubernetes Prow Robot
5d1c301610
Merge pull request #87158 from dims/pick-closest-tags-for-a-few-packages
Pick closest tags for a few packages and avoid random SHA
2020-01-15 16:40:22 -08:00
Kubernetes Prow Robot
82c9e5c814
Merge pull request #87217 from prameshj/patch-helper
Add PatchService method in service/helper.
2020-01-15 14:01:33 -08:00
Kubernetes Prow Robot
6a156c9815
Merge pull request #87202 from ahg-g/aldo
Nominate alculquicondor to sig-scheduling-maintainers
2020-01-15 14:00:24 -08:00
Caleb Woodbine
961c13ecba Fix: formatting 2020-01-15 21:48:23 +00:00
Caleb Woodbine
77e31bd110 Fix: formatting 2020-01-15 21:24:36 +00:00