Commit Graph

33 Commits

Author SHA1 Message Date
saadali
99acb9688c Have Http Probe report "Unhealthy" on connection failure instead of "Unknown". 2014-12-29 11:09:06 -08:00
Clayton Coleman
dadb8431c4 Remove internal PodState in favor of internal PodStatus object 2014-12-15 16:50:05 -05:00
Craig Wickesser
1c02137f48 Update exec health check message logged
Update message logged after performing exec health check per #2708.
2014-12-02 07:15:02 -05:00
Tim Hockin
ea960711ff Clean up error logs.
Use %v for errors, tidy some messages, make error messages start lowe-case
(as per go guidelines).  Just accumulated nits.
2014-11-21 09:45:26 +08:00
Daniel Smith
4630948ad7 Merge pull request #2150 from claire921/fix_health_test
Fix health_test.go
2014-11-04 13:16:47 -08:00
Daniel Smith
0ed0858d1d Merge pull request #2149 from claire921/r_health
Refactor Status.String() in health pkg
2014-11-04 13:15:47 -08:00
Claire Li
51a55d3146 Refactor formatURL in health/http.go 2014-11-03 22:19:25 -08:00
Claire Li
d9a6cfd169 Fix health_test.go 2014-11-03 22:03:34 -08:00
Claire Li
5e3193afd1 Refactor Status.String() in health pkg 2014-11-03 21:57:01 -08:00
Deyuan Deng
acf9d23b32 Stop httptest server. 2014-10-30 21:37:08 -04:00
Vishnu Kannan
7b3db4d41b Use native exec support in docker instead of execing nsinit in kubelet. 2014-10-17 10:04:46 +00:00
Clayton Coleman
95cb2e3eb3 Refactor HealthCheck to take podUUID arguments
PodState is going away (won't have podUUID anymore)
2014-10-09 16:42:55 -04:00
Tim Hockin
1c02af3d16 Kill LivenessProbe.Type 2014-09-27 21:16:30 -07:00
Brendan Burns
f8844ce69e Add a validator for validating components in the cluster infrastructure. 2014-09-16 13:37:01 -07:00
Dawn Chen
7ace5a3e83 Passing pod UUID to Kubelet. 2014-09-08 14:24:09 -07:00
Brendan Burns
dd9ecf5b79 Add types for lifecycle events. 2014-09-02 15:14:13 -07:00
Vojtech Vitek (V-Teq)
59f58cd043 Unify Godoc formatting, fix various typos
Signed-off-by: Vojtech Vitek (V-Teq) <vvitek@redhat.com>
2014-09-02 13:41:03 +02:00
Tim Hockin
0f97a73c1b Rename a bunch of "Make" functions to "New"
Also rename some to other names that make better reading.  There are still a
bunch of "make" functions but they do things like assemble a string from parts
or build an array of things.  It seemed that "make" there seemed fine.  "New"
is for "constructors".
2014-08-20 21:27:19 -07:00
Brendan Burns
05ab1e49fb Address some follow up comments. 2014-08-18 12:49:52 -07:00
Brendan Burns
0caae9c1d4 Add a in container exec based health check. 2014-08-18 12:00:11 -07:00
Tim Hockin
bca90f4866 Reduce and comment exports 2014-08-11 00:11:59 -07:00
Tim Hockin
7beac7a9af Split health_check.go into smaller parts.
Distinct files for core, http, and tcp.
2014-08-11 00:01:17 -07:00
Tim Hockin
24c516ec1d Move HTTP code out of health.go
Put it with the related HTTP code.
2014-08-10 23:50:06 -07:00
Tim Hockin
c67c1edfb4 Use IntOrString for TCP health check ports
Clean up code to be more testable.  Add test cases for named and numeric
ports in TCP health checks.  Improve tests.
2014-08-10 23:44:42 -07:00
Tim Hockin
7201227cb1 Use IntOrString for HTTP health check ports
Clean up code to be more testable.  Add test cases for named and numeric
ports in HTTP health checks.  Improve tests.
2014-08-10 23:26:42 -07:00
Brendan Burns
490bb28bf9 Add TCP socket based health checking. 2014-08-01 14:13:56 -07:00
Kelsey Hightower
c860ac3afc health: Improve test coverage 2014-07-27 08:44:59 -07:00
Kelsey Hightower
fce90dc761 Improve test coverage for the health package and remove mocks
The current tests for the health package utilize a fake HTTP client
for testing health checks and only cover a limited set of test cases.

This patch removes the need for mocks by using the httptest package
from the standard library. After removing the fake HTTP client a bug
was found in the health.Check function; it incorrectly assumes that
a http.Response is always non-nil. Fix the issue by moving the defer
that closes the http.Response.Body after error handling.

Related tests in the registry package have be refactored to work with
the changes made to the health.Check function. All methods that implement
the health.HTTPGetInterface interface now return a http.Response with
with a noop http.Response.Body.

This patch does not introduce any changes in behavior.
2014-07-21 15:30:29 -07:00
Yuki Yugui Sonoda
e0d749f952 fix typo 2014-07-18 14:13:55 +09:00
Yuki Yugui Sonoda
5e31ca3b27 Correct godoc messages according to review comments 2014-07-17 12:27:58 +09:00
Yuki Sonoda (Yugui)
df9da65939 Rename a function according to go convention 2014-07-16 22:05:06 +09:00
Yuki Sonoda (Yugui)
f368e4be68 Fixes golint errors in pkg/health 2014-07-16 21:59:21 +09:00
Brendan Burns
c5db874090 Addressed comments. 2014-07-15 15:16:36 -07:00