Commit Graph

91631 Commits

Author SHA1 Message Date
Monis Khan
fc4f91f10b cmd/*: fail on unrecognized flags/arguments for component CLI
In case a malformed flag is passed to k8s components
such as "–foo", where "–" is not an ASCII dash character,
the components currently silently ignore the flag
and treat it as a positional argument.

Make k8s components/commands exit with an error if a positional argument
that is not empty is found. Include a custom error message for all
components except kubeadm, as cobra.NoArgs is used in a lot of
places already (can be fixed in a followup).

The kubelet already handles this properly - e.g.:
'unknown command: "–foo"'

This change affects:
- cloud-controller-manager
- kube-apiserver
- kube-controller-manager
- kube-proxy
- kubeadm {alpha|config|token|version}
- kubemark

Signed-off-by: Monis Khan <mok@vmware.com>
Signed-off-by: Lubomir I. Ivanov <lubomirivanov@vmware.com>
2020-05-28 22:06:01 +03:00
Abdullah Gharaibeh
d650b57141 Added Preemption benchmark 2020-05-28 14:05:52 -04:00
wojtekt
5d93888f20 Bump addon resizer to 1.8.9 version 2020-05-28 19:37:01 +02:00
Kubernetes Prow Robot
fb9e1946b0
Merge pull request #91481 from zhouya0/fix_create_deployment_port_not_working
Fix create deployment port not working
2020-05-28 10:24:17 -07:00
Kubernetes Prow Robot
40e61d8a50
Merge pull request #90365 from janosi/createsctpservice
e2e test framework change for the SCTP e2e tests
2020-05-28 10:24:04 -07:00
Jordan Liggitt
add5770e2d Update API compatibility fixtures
compatibility.go:302: json differs
            compatibility.go:303:   strings.Join({
                  	... // 61 identical lines
                  	"      {",
                  	`        "type": "o,c鮽ort昍řČ扷5Ɨ",`,
                + 	`        "status": "ěĂ凗蓏Ŋ蛊ĉy緅縕",`,
                  	`        "reason": "25",`,
                  	`        "message": "26",`,
                - 	`        "lastUpdateTime": "2901-11-14T22:54:07Z"`,
                + 	`        "lastUpdateTime": "1985-03-23T14:10:57Z",`,
                + 	`        "lastTransitionTime": "2352-05-22T04:29:36Z"`,
                  	"      }",
                  	"    ],",
                - 	`    "certificate": "9Q=="`,
                + 	`    "certificate": "cw=="`,
                  	"  }",
                  	"}",
                  }, "\n")

            compatibility.go:308: yaml differs
            compatibility.go:309:   strings.Join({
                  	... // 42 identical lines
                  	`  username: "20"`,
                  	"status:",
                - 	"  certificate: 9Q==",
                + 	"  certificate: cw==",
                  	"  conditions:",
                - 	`  - lastUpdateTime: "2901-11-14T22:54:07Z"`,
                + 	`  - lastTransitionTime: "2352-05-22T04:29:36Z"`,
                + 	`    lastUpdateTime: "1985-03-23T14:10:57Z"`,
                  	`    message: "26"`,
                  	`    reason: "25"`,
                + 	"    status: ěĂ凗蓏Ŋ蛊ĉy緅縕",
                  	"    type: o,c鮽ort昍řČ扷5Ɨ",
                  	"",
                  }, "\n")

            compatibility.go:314: proto differs
            compatibility.go:316:   strings.Join({
                  	... // 62 identical lines
                  	`      3: "26"`,
                  	"      4 {",
                - 	"        1: 29407013647",
                + 	"        1: 480435057",
                  	"        2: 0",
                  	"      }",
                + 	"      5 {",
                + 	"        1: 12066985776",
                + 	"        2: 0",
                + 	"      }",
                + 	`      6: "\304\233\304\202\345\207\227\350\223\217\305\212\350\233\212\304\211y\347\267\205\347\270\225"`,
                  	"    }",
                - 	`    2: "\365"`,
                + 	`    2: "s"`,
                  	"  }",
                  	"}",
                  	... // 3 identical lines
                  }, "\n")
2020-05-28 12:20:40 -04:00
Jordan Liggitt
94fd1d76ca Switch issued check to inspect certificate length 2020-05-28 12:20:40 -04:00
Jordan Liggitt
184b3f81ad Stop waiting for failed CSRs 2020-05-28 12:20:40 -04:00
Jordan Liggitt
6b61cb2907 Print and describe failed CSRs 2020-05-28 12:20:40 -04:00
Jordan Liggitt
d33a19cee7 Clean failed CSRs 2020-05-28 12:20:40 -04:00
Jordan Liggitt
57eddd5e04 Record Failed condition in signer controller 2020-05-28 12:20:40 -04:00
Jordan Liggitt
377adfa2b7 Make signer admission plugin check on condition update 2020-05-28 12:20:40 -04:00
Jordan Liggitt
aed0621f2e Plumb version info to validation, separate main/status/approval validation 2020-05-28 12:20:40 -04:00
Jordan Liggitt
9f49d98ccd Add conditions status field 2020-05-28 12:20:39 -04:00
Andrew Sy Kim
18741157ef proxier/ipvs: remove redundant length check for node addresses
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-05-28 11:48:48 -04:00
Jordan Liggitt
6604b79796 Add signerName constants 2020-05-28 10:53:14 -04:00
Kubernetes Prow Robot
56ad0cefbd
Merge pull request #91508 from vareti/typo-fix
Fix the description for Namespace field in ObjectMeta Structure
2020-05-28 06:28:02 -07:00
Davanum Srinivas
42b061fb83
Add dims as feature approver
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-28 06:54:27 -04:00
Kubernetes Prow Robot
570cdb86b8
Merge pull request #91487 from mrbobbytables/update-sched-owners
Update sig-scheduling aliases
2020-05-27 20:50:16 -07:00
Kubernetes Prow Robot
8b3c00c661
Merge pull request #89799 from julianvmodesto/patcher
Make kubectl client-side apply with server-side dry-run safer
2020-05-27 20:50:02 -07:00
Gaurav Singh
793dd7fc99 Change Fprint to Fprintf
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-05-27 22:41:16 -04:00
Gaurav Singh
353140a67a [Provider/Azure] remove extra Sprintf 2020-05-27 22:38:29 -04:00
weijiehu
f11ad05f6f Improves unittest CC for azure_config 2020-05-27 19:25:43 -07:00
Kubernetes Prow Robot
5fc4f4d548
Merge pull request #90469 from uthark/oatamanenko/describe-node-leases
Ignore forbidden error for leases when describing node
2020-05-27 17:56:02 -07:00
Walter Fender
66284b220b Adds staging directory for controller-manager code
* Creates staging directory for common controller-manager code
* Adds the following initial files to this directory:

  * .github/PULL_REQUEST_TEMPLATE.md
  * code-of-conduct.md
  * LICENSE
  * OWNERS
  * README.md
  * SECURITY_CONTACTS
* Code committed to the controller-manager staging directory will be published to: https://github.com/kubernetes/controller-manager

Initial approval deads2k (sig-api-machinery chair)

The config we would expect any controller manager to need to connect to the API server, set up metrics endpoints, create per-controller-loop API clients, and spin up the individual loops could make sense under a k8s.io/controller-manager package.

Then cmd/kube-controller-manager could continue to contain the weirdnesses specific to kube-controller-manager.

This is similar to the way we split out recommended API server setup into k8s.io/apiserver and tried to limit kube-apiserver oddities to cmd/kube-apiserver and pkg/kubeapiserver

Removed extraneous release reference. Ran update-vendor.
Fixed Readme.
Added a doc.go to staging/controller-manager
Fix package to not have dash.

```
NONE
```

/kind cleanup
/sig api-machinery
/area kube-controller-manager
/area cloud-controller-manager
2020-05-27 17:30:36 -07:00
Brian Pursley
482646af2a Added issue templates for kubectl 2020-05-27 20:00:50 -04:00
Kubernetes Prow Robot
02637bb250
Merge pull request #91145 from tnqn/kubeadm-reset-error
kubeadm: skip removing last etcd member in reset phase
2020-05-27 15:04:01 -07:00
David Eads
e857adbdfd remove-api 2020-05-27 16:58:05 -04:00
Kubernetes Prow Robot
d680e053f1
Merge pull request #91409 from johscheuer/update-api-server-flag-help
Update kube-apiserver flag comments
2020-05-27 13:11:52 -07:00
Kubernetes Prow Robot
789917b508
Merge pull request #91401 from iobuf/fix-kubectl
[kubectl/pkg/cmd/rollout]: fix typo & tidy imports
2020-05-27 13:11:38 -07:00
David Eads
ed4e6f1026 remove dynamic audit 2020-05-27 15:18:53 -04:00
Siva
9c5b306ab7 fix namespace field description string 2020-05-27 14:02:55 -05:00
Prasad Katti
c253ccca00 Add tests for ValidateEtcd 2020-05-27 10:40:13 -07:00
Kubernetes Prow Robot
356c121c6d
Merge pull request #91431 from prasadkatti/add_validate_urls_tests
Add tests for ValidateURLs (kubeadm validation)
2020-05-27 08:54:41 -07:00
Amim Knabben
896cc4c0c4 Deprecating Kubelet mount related flags 2020-05-27 09:33:27 -04:00
Kubernetes Prow Robot
87473a5d27
Merge pull request #91488 from mrbobbytables/update-gh-owners
Move Phillels to emeritus
2020-05-27 05:32:41 -07:00
Wojciech Tyczynski
7787ebc85b
Revert "Revert "Rely on default watch cache capacity and ignore its requested size"" 2020-05-27 14:19:38 +02:00
Bob Killen
186e72f7fe
Move Phillels to emeritus 2020-05-27 07:13:51 -04:00
Bob Killen
7a469d0043
Update sig-scheduling aliases 2020-05-27 06:57:31 -04:00
Kubernetes Prow Robot
c1707541d8
Merge pull request #91456 from tosi3k/propagate-am-whitelist-override
Propagate KUBECTL_PRUNE_WHITELIST_OVERRIDE to master kube-env
2020-05-27 02:20:40 -07:00
zhouya0
24766024c1 Fix create deployment port not working 2020-05-27 15:56:35 +08:00
Kubernetes Prow Robot
7c3f7065db
Merge pull request #91113 from soltysh/create_deployment
Refactor create deployment and add --port flag
2020-05-26 23:24:54 -07:00
Kubernetes Prow Robot
65c0a1e64b
Merge pull request #89716 from Jefftree/bdd-initial-link
Add behavior <-> conformance test linkage example for pods
2020-05-26 23:24:41 -07:00
Kubernetes Prow Robot
73641d35c7
Merge pull request #91451 from gaurav1086/scheduler_test_fix_goroutine_leak
scheduler_test: fix goroutine leak
2020-05-26 21:09:03 -07:00
Kubernetes Prow Robot
5e8a7477ee
Merge pull request #91403 from colin404/fix
fix the wrong function description
2020-05-26 21:08:53 -07:00
Kubernetes Prow Robot
7134718c5a
Merge pull request #91392 from prameshj/getlb
Check for GCE finalizer in GetLoadBalancer.
2020-05-26 21:08:40 -07:00
Prasad Katti
a85fc1038c Add tests for ValidateURLs (kubeadm validation) 2020-05-26 20:31:04 -07:00
andyzhangx
a39eeda381 feat: azure disk and azure file migration go beta
fix comments
2020-05-27 02:31:38 +00:00
Kubernetes Prow Robot
bc06f367d4
Merge pull request #91466 from prameshj/dns-autoscaler
Include Unschedulable nodes to compute kube-dns replica in DNS autoscaler.
2020-05-26 19:13:28 -07:00
Kubernetes Prow Robot
b0e0692490
Merge pull request #91446 from pancernik/scheduler-plugin-args-validation-nr
Move Node Resources scheduler plugin args validation to apis/config/validation
2020-05-26 19:13:18 -07:00